[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40074] branches/bmesh/blender/source/ blender: correct edit some comments

Campbell Barton ideasman42 at gmail.com
Fri Sep 9 16:51:30 CEST 2011


Revision: 40074
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=40074
Author:   campbellbarton
Date:     2011-09-09 14:51:30 +0000 (Fri, 09 Sep 2011)
Log Message:
-----------
correct edit some comments

Modified Paths:
--------------
    branches/bmesh/blender/source/blender/blenkernel/intern/editderivedbmesh.c
    branches/bmesh/blender/source/blender/blenkernel/intern/mesh.c
    branches/bmesh/blender/source/blender/blenlib/intern/scanfill.c

Modified: branches/bmesh/blender/source/blender/blenkernel/intern/editderivedbmesh.c
===================================================================
--- branches/bmesh/blender/source/blender/blenkernel/intern/editderivedbmesh.c	2011-09-09 14:44:36 UTC (rev 40073)
+++ branches/bmesh/blender/source/blender/blenkernel/intern/editderivedbmesh.c	2011-09-09 14:51:30 UTC (rev 40074)
@@ -1289,9 +1289,6 @@
 		face_r->v1 = BM_GetIndex(l[0]->v);
 		face_r->v2 = BM_GetIndex(l[1]->v);
 		face_r->v3 = BM_GetIndex(l[2]->v);
-		/*BMESH_TODO: zero is not the best way to signal that
-		  the face is a triangle and not a quad, since 0 is
-		  also the index assigned to a real vertex*/
 		face_r->v4 = 0;
 
 		test_index_face(face_r, NULL, 0, 3);

Modified: branches/bmesh/blender/source/blender/blenkernel/intern/mesh.c
===================================================================
--- branches/bmesh/blender/source/blender/blenkernel/intern/mesh.c	2011-09-09 14:44:36 UTC (rev 40073)
+++ branches/bmesh/blender/source/blender/blenkernel/intern/mesh.c	2011-09-09 14:51:30 UTC (rev 40074)
@@ -1961,7 +1961,8 @@
 		bmesh_corners_to_loops(mesh, i, mp->loopstart, numTex, numCol);
 	}
 
-	/*BMESH_TODO now to deal with fgons*/
+	/* note, we dont convert FGons at all, these are not even real ngons,
+	 * they have their own UV's, colors etc - its more an editing feature. */
 
 	BLI_edgehash_free(eh, NULL);
 }

Modified: branches/bmesh/blender/source/blender/blenlib/intern/scanfill.c
===================================================================
--- branches/bmesh/blender/source/blender/blenlib/intern/scanfill.c	2011-09-09 14:44:36 UTC (rev 40073)
+++ branches/bmesh/blender/source/blender/blenlib/intern/scanfill.c	2011-09-09 14:51:30 UTC (rev 40074)
@@ -818,8 +818,8 @@
 		float vec1[3], vec2[3];
 
 		eve = fillvertbase.first;
-		
-		if (1 && eve->next && eve->next->next && eve->next->next->next) { //BMESH_TODO) {
+		/* no need to check 'eve->next->next->next' is valid, already counted */
+		if (1) { //BMESH_TODO) {
 			/*use shortest diagonal for quad*/
 			sub_v3_v3v3(vec1, eve->co, eve->next->next->co);
 			sub_v3_v3v3(vec2, eve->next->co, eve->next->next->next->co);




More information about the Bf-blender-cvs mailing list