[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40015] trunk/blender/source/blender/ editors/mesh/editmesh_mods.c: Fix #28551: Select similar by normals ignores z component of normal angles

Sergey Sharybin g.ulairi at gmail.com
Wed Sep 7 17:09:04 CEST 2011


Revision: 40015
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=40015
Author:   nazgul
Date:     2011-09-07 15:09:03 +0000 (Wed, 07 Sep 2011)
Log Message:
-----------
Fix #28551: Select similar by normals ignores z component of normal angles

Select grouped used angle_v2v2 instead of angle_v3v3.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/mesh/editmesh_mods.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_mods.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_mods.c	2011-09-07 14:44:52 UTC (rev 40014)
+++ trunk/blender/source/blender/editors/mesh/editmesh_mods.c	2011-09-07 15:09:03 UTC (rev 40015)
@@ -827,7 +827,7 @@
 				float angle;
 				for(efa= em->faces.first; efa; efa= efa->next) {
 					if (!(efa->f & SELECT) && !efa->h) {
-						angle= RAD2DEGF(angle_v2v2(base_efa->n, efa->n));
+						angle= RAD2DEGF(angle_v3v3(base_efa->n, efa->n));
 						if (angle/180.0f<=thresh) {
 							EM_select_face(efa, 1);
 							selcount++;
@@ -842,7 +842,7 @@
 				base_dot= dot_v3v3(base_efa->cent, base_efa->n);
 				for(efa= em->faces.first; efa; efa= efa->next) {
 					if (!(efa->f & SELECT) && !efa->h) {
-						angle= RAD2DEGF(angle_v2v2(base_efa->n, efa->n));
+						angle= RAD2DEGF(angle_v3v3(base_efa->n, efa->n));
 						if (angle/180.0f<=thresh) {
 							dot=dot_v3v3(efa->cent, base_efa->n);
 							if (fabsf(base_dot-dot) <= thresh) {
@@ -989,7 +989,7 @@
 				for(eed= em->edges.first; eed; eed= eed->next) {
 					if (!(eed->f & SELECT) && !eed->h) {
 						sub_v3_v3v3(dir, eed->v1->co, eed->v2->co);
-						angle= RAD2DEGF(angle_v2v2(base_dir, dir));
+						angle= RAD2DEGF(angle_v3v3(base_dir, dir));
 						
 						if (angle>90.0f) /* use the smallest angle between the edges */
 							angle= fabsf(angle-180.0f);
@@ -1159,7 +1159,7 @@
 				float angle;
 				for(eve= em->verts.first; eve; eve= eve->next) {
 					if (!(eve->f & SELECT) && !eve->h) {
-						angle= RAD2DEGF(angle_v2v2(base_eve->no, eve->no));
+						angle= RAD2DEGF(angle_v3v3(base_eve->no, eve->no));
 						if (angle/180.0f<=thresh) {
 							eve->f |= SELECT;
 							selcount++;




More information about the Bf-blender-cvs mailing list