[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [39955] branches/bmesh/blender/source/ blender: fix for flip normals 'inside' option not working.

[Campbell Barton]

Revision: 39955
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=39955
Author:   campbellbarton
Date:     2011-09-06 04:06:05 +0000 (Tue, 06 Sep 2011)
Log Message:
-----------
fix for flip normals 'inside' option not working.

Modified Paths:
--------------
    branches/bmesh/blender/source/blender/bmesh/operators/utils.c
    branches/bmesh/blender/source/blender/editors/mesh/bmesh_tools.c

Modified: branches/bmesh/blender/source/blender/bmesh/operators/utils.c
===================================================================
--- branches/bmesh/blender/source/blender/bmesh/operators/utils.c	2011-09-06 03:32:58 UTC (rev 39954)
+++ branches/bmesh/blender/source/blender/bmesh/operators/utils.c	2011-09-06 04:06:05 UTC (rev 39955)
@@ -234,24 +234,24 @@
 #define FACE_FLIP	8
 
 /* NOTE: these are the original righthandfaces comment in editmesh_mods.c,
-         copied here for reference.
-*/
-       /* based at a select-connected to witness loose objects */
+ *       copied here for reference. */
 
-	/* count per edge the amount of faces */
+ /* based at a select-connected to witness loose objects */
 
-	/* find the ultimate left, front, upper face (not manhattan dist!!) */
-	/* also evaluate both triangle cases in quad, since these can be non-flat */
+/* count per edge the amount of faces
+ * find the ultimate left, front, upper face (not manhattan dist!!)
+ * also evaluate both triangle cases in quad, since these can be non-flat
+ *
+ * put normal to the outside, and set the first direction flags in edges
+ *
+ * then check the object, and set directions / direction-flags: but only for edges with 1 or 2 faces
+ * this is in fact the 'select connected'
+ *
+ * in case (selected) faces were not done: start over with 'find the ultimate ...' */
 
-	/* put normal to the outside, and set the first direction flags in edges */
+/* NOTE: this function uses recursion, which is a little unusual for a bmop
+         function, but acceptable I think. */
 
-	/* then check the object, and set directions / direction-flags: but only for edges with 1 or 2 faces */
-	/* this is in fact the 'select connected' */
-	
-	/* in case (selected) faces were not done: start over with 'find the ultimate ...' */
-
-/*note: this function uses recursion, which is a little unusual for a bmop
-        function, but acceptable I think.*/
 void bmesh_righthandfaces_exec(BMesh *bm, BMOperator *op)
 {
 	BMIter liter, liter2;

Modified: branches/bmesh/blender/source/blender/editors/mesh/bmesh_tools.c
===================================================================
--- branches/bmesh/blender/source/blender/editors/mesh/bmesh_tools.c	2011-09-06 03:32:58 UTC (rev 39954)
+++ branches/bmesh/blender/source/blender/editors/mesh/bmesh_tools.c	2011-09-06 04:06:05 UTC (rev 39955)
@@ -1704,13 +1704,13 @@
 	Object *obedit= CTX_data_edit_object(C);
 	BMEditMesh *em= ((Mesh *)obedit->data)->edit_btmesh;
 	
-	/*doflip has to do with bmesh_rationalize_normals, it's an internal
-	thing*/
+	/* doflip has to do with bmesh_rationalize_normals, it's an internal
+	 * thing*/
 	if (!EDBM_CallOpf(em, op, "righthandfaces faces=%hf doflip=%d", BM_SELECT, 1))
 		return OPERATOR_CANCELLED;
-	
+
 	if (RNA_boolean_get(op->ptr, "inside"))
-		EDBM_CallOpf(em, op, "reversefaces faces=%hf doflip=%d", BM_SELECT, 1);
+		EDBM_CallOpf(em, op, "reversefaces faces=%hf", BM_SELECT);
 
 	DAG_id_tag_update(obedit->data, OB_RECALC_DATA);
 	WM_event_add_notifier(C, NC_GEOM|ND_DATA, obedit->data);