[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [42149] branches/bmesh/blender/source/ blender/bmesh/intern/bmesh_polygon.c: remove redundant array copy ( was being done twice), for BM_Face_UpdateNormal

Campbell Barton ideasman42 at gmail.com
Fri Nov 25 00:27:25 CET 2011


Revision: 42149
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42149
Author:   campbellbarton
Date:     2011-11-24 23:27:20 +0000 (Thu, 24 Nov 2011)
Log Message:
-----------
remove redundant array copy (was being done twice), for BM_Face_UpdateNormal

Modified Paths:
--------------
    branches/bmesh/blender/source/blender/bmesh/intern/bmesh_polygon.c

Modified: branches/bmesh/blender/source/blender/bmesh/intern/bmesh_polygon.c
===================================================================
--- branches/bmesh/blender/source/blender/bmesh/intern/bmesh_polygon.c	2011-11-24 23:09:55 UTC (rev 42148)
+++ branches/bmesh/blender/source/blender/bmesh/intern/bmesh_polygon.c	2011-11-24 23:27:20 UTC (rev 42149)
@@ -85,18 +85,15 @@
  * computing newell normal.
  *
 */
-#define FEQ(f1, f2) (ABS((double)(f1)-(double)(f2)) < 0.1)
 
 static void compute_poly_normal(float normal[3], float (*verts)[3], int nverts)
 {
 
 	float u[3], v[3], w[3];/*, *w, v1[3], v2[3];*/
-	float n[3]/*, l, v1[3], v2[3] */;
+	float n[3]= {0.0f, 0.0f, 0.0f} /*, l, v1[3], v2[3] */;
 	/* double l2; */
 	int i /*, s=0 */;
 
-	zero_v3(n);
-
 	/*this fixes some weird numerical error*/
 	add_v3_fl(verts[0], 0.0001f);
 
@@ -388,16 +385,8 @@
 {
 	float projverts[200][3];
 	float (*proj)[3] = f->len < 200 ? projverts : MEM_mallocN(sizeof(float)*f->len*3, "projvertsn");
-	BMIter iter;
-	BMLoop *l;
-	int i=0;
 
 	if (f->len < 3) return;
-	
-	BM_ITER(l, &iter, bm, BM_LOOPS_OF_FACE, f) {
-		copy_v3_v3(proj[i], l->v->co);
-		i += 1;
-	}
 
 	bmesh_update_face_normal(bm, f, proj);
 
@@ -474,7 +463,6 @@
 		int i = 0;
 		BM_ITER(l, &iter, bm, BM_LOOPS_OF_FACE, f) {
 			copy_v3_v3(projectverts[i], l->v->co);
-			l = l->next;
 			i += 1;
 		}
 




More information about the Bf-blender-cvs mailing list