[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [37802] trunk/blender: Fix [#27748] undeterministic behaviour of volumetric renderer

[Matt Ebb]

Revision: 37802
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=37802
Author:   broken
Date:     2011-06-25 00:33:36 +0000 (Sat, 25 Jun 2011)
Log Message:
-----------
Fix [#27748] undeterministic behaviour of volumetric renderer

* Made clearer in the UI that the approximate multiple scattering always enables light cache
* Fixed a potential problem in anisotropic scattering

Modified Paths:
--------------
    trunk/blender/release/scripts/startup/bl_ui/properties_material.py
    trunk/blender/source/blender/render/intern/source/volume_precache.c
    trunk/blender/source/blender/render/intern/source/volumetric.c

Modified: trunk/blender/release/scripts/startup/bl_ui/properties_material.py
===================================================================
--- trunk/blender/release/scripts/startup/bl_ui/properties_material.py	2011-06-24 23:58:13 UTC (rev 37801)
+++ trunk/blender/release/scripts/startup/bl_ui/properties_material.py	2011-06-25 00:33:36 UTC (rev 37802)
@@ -883,7 +883,7 @@
             sub = col.column()
             sub.enabled = True
             sub.active = False
-            sub.prop(vol, "use_light_cache")
+            sub.label("Light Cache Enabled")
             col.prop(vol, "cache_resolution")
 
             sub = col.column(align=True)

Modified: trunk/blender/source/blender/render/intern/source/volume_precache.c
===================================================================
--- trunk/blender/source/blender/render/intern/source/volume_precache.c	2011-06-24 23:58:13 UTC (rev 37801)
+++ trunk/blender/source/blender/render/intern/source/volume_precache.c	2011-06-25 00:33:36 UTC (rev 37802)
@@ -523,7 +523,6 @@
 					continue;
 				}
 				
-				/* this view coordinate is very wrong! */
 				copy_v3_v3(shi->view, cco);
 				normalize_v3(shi->view);
 				vol_get_scattering(shi, scatter_col, cco);

Modified: trunk/blender/source/blender/render/intern/source/volumetric.c
===================================================================
--- trunk/blender/source/blender/render/intern/source/volumetric.c	2011-06-24 23:58:13 UTC (rev 37801)
+++ trunk/blender/source/blender/render/intern/source/volumetric.c	2011-06-25 00:33:36 UTC (rev 37802)
@@ -534,6 +534,7 @@
 	
 	if (luminance(lacol) < 0.001f) return;
 	
+	normalize_v3(lv);
 	p = vol_get_phasefunc(shi, shi->mat->vol.asymmetry, shi->view, lv);
 	
 	/* physically based scattering with non-physically based RGB gain */