[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [32480] trunk/blender: enable warning for unused args with gcc: -Wunused-parameter

[Campbell Barton]

Revision: 32480
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=32480
Author:   campbellbarton
Date:     2010-10-15 04:24:48 +0200 (Fri, 15 Oct 2010)

Log Message:
-----------
enable warning for unused args with gcc: -Wunused-parameter
- for cmake only apply this to source/blender, will apply globally later.
- ./extern/ ./source/blender/makesrna/intern/ ignore this.

Modified Paths:
--------------
    trunk/blender/CMakeLists.txt
    trunk/blender/build_files/scons/config/linux2-config.py
    trunk/blender/extern/CMakeLists.txt
    trunk/blender/source/blender/CMakeLists.txt
    trunk/blender/source/blender/makesrna/intern/CMakeLists.txt

Modified: trunk/blender/CMakeLists.txt
===================================================================
--- trunk/blender/CMakeLists.txt	2010-10-15 01:36:14 UTC (rev 32479)
+++ trunk/blender/CMakeLists.txt	2010-10-15 02:24:48 UTC (rev 32480)
@@ -318,6 +318,7 @@
 	SET(PLATFORM_LINKFLAGS "-pthread")
 
 	# Better warnings
+	# note: -Wunused-parameter should be added but for now only apply to ./source/blender
 	SET(C_WARNINGS "-Wall -Wno-char-subscripts -Wpointer-arith -Wcast-align -Wdeclaration-after-statement -Wno-unknown-pragmas")
 	SET(CXX_WARNINGS "-Wall -Wno-invalid-offsetof -Wno-sign-compare")
 

Modified: trunk/blender/build_files/scons/config/linux2-config.py
===================================================================
--- trunk/blender/build_files/scons/config/linux2-config.py	2010-10-15 01:36:14 UTC (rev 32479)
+++ trunk/blender/build_files/scons/config/linux2-config.py	2010-10-15 02:24:48 UTC (rev 32480)
@@ -204,7 +204,7 @@
 ##ARFLAGS = ruv
 ##ARFLAGSQUIET = ru
 ##
-C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement']
+C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement', '-Wunused-parameter']
 CC_WARN = ['-Wall']
 CXX_WARN = ['-Wno-invalid-offsetof', '-Wno-sign-compare']
 

Modified: trunk/blender/extern/CMakeLists.txt
===================================================================
--- trunk/blender/extern/CMakeLists.txt	2010-10-15 01:36:14 UTC (rev 32479)
+++ trunk/blender/extern/CMakeLists.txt	2010-10-15 02:24:48 UTC (rev 32480)
@@ -24,6 +24,9 @@
 #
 # ***** END GPL LICENSE BLOCK *****
 
+# Otherwise we get warnings here that we cant fix in external projects
+STRING(REGEX REPLACE "-Wunused-parameter" "" CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
+
 IF(WITH_BULLET)
 	ADD_SUBDIRECTORY(bullet2)
 ENDIF(WITH_BULLET)

Modified: trunk/blender/source/blender/CMakeLists.txt
===================================================================
--- trunk/blender/source/blender/CMakeLists.txt	2010-10-15 01:36:14 UTC (rev 32479)
+++ trunk/blender/source/blender/CMakeLists.txt	2010-10-15 02:24:48 UTC (rev 32480)
@@ -24,6 +24,11 @@
 #
 # ***** END GPL LICENSE BLOCK *****
 
+# TODO: remove this and uncommend the global arg, but for now adding here keeps it managable
+IF(CMAKE_COMPILER_IS_GNUCC)
+	SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wunused-parameter")
+ENDIF(CMAKE_COMPILER_IS_GNUCC)
+
 ADD_SUBDIRECTORY(windowmanager)
 ADD_SUBDIRECTORY(editors)
 ADD_SUBDIRECTORY(avi)

Modified: trunk/blender/source/blender/makesrna/intern/CMakeLists.txt
===================================================================
--- trunk/blender/source/blender/makesrna/intern/CMakeLists.txt	2010-10-15 01:36:14 UTC (rev 32479)
+++ trunk/blender/source/blender/makesrna/intern/CMakeLists.txt	2010-10-15 02:24:48 UTC (rev 32480)
@@ -24,6 +24,9 @@
 #
 # ***** END GPL LICENSE BLOCK *****
 
+# this warning on generated files gets annoying
+STRING(REGEX REPLACE "-Wunused-parameter" "" CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
+
 FILE(GLOB DEFSRC RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "*.c")
 FILE(GLOB APISRC RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "*_api.c")
 LIST(REMOVE_ITEM DEFSRC rna_access.c rna_define.c makesrna.c)