[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [33250] trunk/blender/source/blender: use zero initializers instead of memset(), also change PointerRNA_NULL from an extern into a define.
Campbell Barton
ideasman42 at gmail.com
Tue Nov 23 09:44:21 CET 2010
Revision: 33250
http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=33250
Author: campbellbarton
Date: 2010-11-23 09:44:21 +0100 (Tue, 23 Nov 2010)
Log Message:
-----------
use zero initializers instead of memset(), also change PointerRNA_NULL from an extern into a define.
Modified Paths:
--------------
trunk/blender/source/blender/avi/intern/avi.c
trunk/blender/source/blender/blenkernel/intern/anim.c
trunk/blender/source/blender/blenkernel/intern/anim_sys.c
trunk/blender/source/blender/editors/animation/keyframing.c
trunk/blender/source/blender/editors/object/object_relations.c
trunk/blender/source/blender/editors/render/render_preview.c
trunk/blender/source/blender/editors/sculpt_paint/paint_image.c
trunk/blender/source/blender/imbuf/intern/iris.c
trunk/blender/source/blender/makesrna/RNA_access.h
trunk/blender/source/blender/makesrna/intern/rna_access.c
trunk/blender/source/blender/python/intern/bpy_rna.c
trunk/blender/source/blender/windowmanager/intern/wm_operators.c
Modified: trunk/blender/source/blender/avi/intern/avi.c
===================================================================
--- trunk/blender/source/blender/avi/intern/avi.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/avi/intern/avi.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -213,15 +213,13 @@
int AVI_is_avi (const char *name) {
int temp, fcca, j;
- AviMovie movie;
+ AviMovie movie= {0};
AviMainHeader header;
AviBitmapInfoHeader bheader;
int movie_tracks = 0;
DEBUG_PRINT("opening movie\n");
- memset(&movie, 0, sizeof(AviMovie));
-
movie.type = AVI_MOVIE_READ;
movie.fp = fopen (name, "rb");
movie.offset_table = NULL;
Modified: trunk/blender/source/blender/blenkernel/intern/anim.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/anim.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/blenkernel/intern/anim.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -1441,7 +1441,7 @@
static void font_duplilist(ListBase *lb, Scene *scene, Object *par, int level, int animated)
{
- Object *ob, *obar[256];
+ Object *ob, *obar[256]= {0};
Curve *cu;
struct chartrans *ct, *chartransdata;
float vec[3], obmat[4][4], pmat[4][4], fsize, xof, yof;
@@ -1456,9 +1456,7 @@
chartransdata= BKE_text_to_curve(scene, par, FO_DUPLI);
if(chartransdata==0) return;
-
- memset(obar, 0, 256*sizeof(void *));
-
+
cu= par->data;
slen= strlen(cu->str);
fsize= cu->fsize;
Modified: trunk/blender/source/blender/blenkernel/intern/anim_sys.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/anim_sys.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/blenkernel/intern/anim_sys.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -1610,9 +1610,6 @@
*/
static void animsys_evaluate_nla (PointerRNA *ptr, AnimData *adt, float ctime)
{
- ListBase dummy_trackslist = {NULL, NULL};
- NlaStrip dummy_strip;
-
NlaTrack *nlt;
short track_index=0;
short has_strips = 0;
@@ -1655,7 +1652,9 @@
/* if there are strips, evaluate action as per NLA rules */
if ((has_strips) || (adt->actstrip)) {
/* make dummy NLA strip, and add that to the stack */
- memset(&dummy_strip, 0, sizeof(NlaStrip));
+ NlaStrip dummy_strip= {0};
+ ListBase dummy_trackslist;
+
dummy_trackslist.first= dummy_trackslist.last= &dummy_strip;
if ((nlt) && !(adt->flag & ADT_NLA_EDIT_NOMAP)) {
Modified: trunk/blender/source/blender/editors/animation/keyframing.c
===================================================================
--- trunk/blender/source/blender/editors/animation/keyframing.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/editors/animation/keyframing.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -287,13 +287,12 @@
*/
int insert_vert_fcurve (FCurve *fcu, float x, float y, short flag)
{
- BezTriple beztr;
+ BezTriple beztr= {{{0}}};
int a;
/* set all three points, for nicer start position
* NOTE: +/- 1 on vec.x for left and right handles is so that 'free' handles work ok...
*/
- memset(&beztr, 0, sizeof(BezTriple));
beztr.vec[0][0]= x-1.0f;
beztr.vec[0][1]= y;
beztr.vec[1][0]= x;
@@ -1355,7 +1354,7 @@
{
Main *bmain= CTX_data_main(C);
Scene *scene= CTX_data_scene(C);
- PointerRNA ptr;
+ PointerRNA ptr= {{0}};
PropertyRNA *prop= NULL;
char *path;
float cfra= (float)CFRA; // XXX for now, don't bother about all the yucky offset crap
@@ -1367,7 +1366,6 @@
flag = ANIM_get_keyframing_flags(scene, 1);
/* try to insert keyframe using property retrieved from UI */
- memset(&ptr, 0, sizeof(PointerRNA));
uiContextActiveProperty(C, &ptr, &prop, &index);
if ((ptr.id.data && ptr.data && prop) && RNA_property_animateable(&ptr, prop)) {
Modified: trunk/blender/source/blender/editors/object/object_relations.c
===================================================================
--- trunk/blender/source/blender/editors/object/object_relations.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/editors/object/object_relations.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -357,7 +357,7 @@
/* Generic itemf's for operators that take library args */
static EnumPropertyItem *proxy_group_object_itemf(bContext *C, PointerRNA *UNUSED(ptr), int *free)
{
- EnumPropertyItem *item= NULL, item_tmp;
+ EnumPropertyItem item_tmp= {0}, *item= NULL;
int totitem= 0;
int i= 0;
Object *ob= ED_object_active_context(C);
@@ -366,8 +366,6 @@
if(!ob || !ob->dup_group)
return DummyRNA_DEFAULT_items;
- memset(&item_tmp, 0, sizeof(item_tmp));
-
/* find the object to affect */
for (go= ob->dup_group->gobject.first; go; go= go->next) {
item_tmp.identifier= item_tmp.name= go->ob->id.name+2;
Modified: trunk/blender/source/blender/editors/render/render_preview.c
===================================================================
--- trunk/blender/source/blender/editors/render/render_preview.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/editors/render/render_preview.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -1085,14 +1085,13 @@
if(idtype == ID_IM) {
Image *ima= (Image*)id;
ImBuf *ibuf= NULL;
- ImageUser iuser;
+ ImageUser iuser= {0};
/* ima->ok is zero when Image cannot load */
if(ima==NULL || ima->ok==0)
return;
/* setup dummy image user */
- memset(&iuser, 0, sizeof(ImageUser));
iuser.ok= iuser.framenr= 1;
iuser.scene= sp->scene;
Modified: trunk/blender/source/blender/editors/sculpt_paint/paint_image.c
===================================================================
--- trunk/blender/source/blender/editors/sculpt_paint/paint_image.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/editors/sculpt_paint/paint_image.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -5412,13 +5412,11 @@
{
Image *image= BLI_findlink(&CTX_data_main(C)->image, RNA_enum_get(op->ptr, "image"));
Scene *scene= CTX_data_scene(C);
- ProjPaintState ps;
+ ProjPaintState ps= {0};
int orig_brush_size;
IDProperty *idgroup;
IDProperty *view_data= NULL;
- memset(&ps, 0, sizeof(ps));
-
project_state_init(C, OBACT, &ps);
if(ps.ob==NULL || ps.ob->type != OB_MESH) {
Modified: trunk/blender/source/blender/imbuf/intern/iris.c
===================================================================
--- trunk/blender/source/blender/imbuf/intern/iris.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/imbuf/intern/iris.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -175,9 +175,8 @@
static int writeheader(FILE *outf, IMAGE *image)
{
- IMAGE t;
+ IMAGE t= {0};
- memset(&t, 0, sizeof(IMAGE));
fwrite(&t,sizeof(IMAGE),1,outf);
fseek(outf,0,SEEK_SET);
putshort(outf,image->imagic);
Modified: trunk/blender/source/blender/makesrna/RNA_access.h
===================================================================
--- trunk/blender/source/blender/makesrna/RNA_access.h 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/makesrna/RNA_access.h 2010-11-23 08:44:21 UTC (rev 33250)
@@ -583,7 +583,7 @@
void RNA_blender_rna_pointer_create(PointerRNA *r_ptr);
void RNA_pointer_recast(PointerRNA *ptr, PointerRNA *r_ptr);
-extern PointerRNA PointerRNA_NULL;
+#define PointerRNA_NULL ((PointerRNA){{0}})
/* Structs */
Modified: trunk/blender/source/blender/makesrna/intern/rna_access.c
===================================================================
--- trunk/blender/source/blender/makesrna/intern/rna_access.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/makesrna/intern/rna_access.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -90,8 +90,6 @@
/* Pointer */
-PointerRNA PointerRNA_NULL = {{0}, 0, 0};
-
void RNA_main_pointer_create(struct Main *main, PointerRNA *r_ptr)
{
r_ptr->id.data= NULL;
@@ -168,9 +166,8 @@
PointerRNA rna_pointer_inherit_refine(PointerRNA *ptr, StructRNA *type, void *data)
{
- PointerRNA result;
-
if(data) {
+ PointerRNA result;
result.data= data;
result.type= type;
rna_pointer_inherit_id(type, ptr, &result);
@@ -183,11 +180,11 @@
else
result.type= type;
}
+ return result;
}
- else
- memset(&result, 0, sizeof(result));
-
- return result;
+ else {
+ return PointerRNA_NULL;
+ }
}
/**/
@@ -1972,8 +1969,7 @@
return RNA_property_pointer_get(ptr, prop);
}
else {
- PointerRNA result= {{0}};
- return result;
+ return PointerRNA_NULL;
}
}
@@ -3561,12 +3557,9 @@
return RNA_property_pointer_get(ptr, prop);
}
else {
- PointerRNA result;
-
printf("RNA_pointer_get: %s.%s not found.\n", ptr->type->identifier, name);
- memset(&result, 0, sizeof(result));
- return result;
+ return PointerRNA_NULL;
}
}
Modified: trunk/blender/source/blender/python/intern/bpy_rna.c
===================================================================
--- trunk/blender/source/blender/python/intern/bpy_rna.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/python/intern/bpy_rna.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -1156,8 +1156,7 @@
else {
/* data==NULL, assign to RNA */
if(value == Py_None) {
- PointerRNA valueptr;
- memset(&valueptr, 0, sizeof(valueptr));
+ PointerRNA valueptr= {{0}};
RNA_property_pointer_set(ptr, prop, valueptr);
}
else if(RNA_struct_is_a(param->ptr.type, ptype)) {
Modified: trunk/blender/source/blender/windowmanager/intern/wm_operators.c
===================================================================
--- trunk/blender/source/blender/windowmanager/intern/wm_operators.c 2010-11-23 00:23:57 UTC (rev 33249)
+++ trunk/blender/source/blender/windowmanager/intern/wm_operators.c 2010-11-23 08:44:21 UTC (rev 33250)
@@ -3426,12 +3426,10 @@
/* Generic itemf's for operators that take library args */
static EnumPropertyItem *rna_id_itemf(bContext *UNUSED(C), PointerRNA *UNUSED(ptr), int *free, ID *id, int local)
{
- EnumPropertyItem *item= NULL, item_tmp;
+ EnumPropertyItem item_tmp= {0}, *item= NULL;
int totitem= 0;
int i= 0;
- memset(&item_tmp, 0, sizeof(item_tmp));
-
for( ; id; id= id->next) {
if(local==FALSE || id->lib==NULL) {
item_tmp.identifier= item_tmp.name= id->name+2;
More information about the Bf-blender-cvs
mailing list