[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [28767] branches/render25/source/blender/ blenkernel/intern/implicit.c: Render Branch: disable threading for vector dot product in implicit solver

Brecht Van Lommel brecht at blender.org
Fri May 14 16:48:58 CEST 2010


Revision: 28767
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=28767
Author:   blendix
Date:     2010-05-14 16:48:57 +0200 (Fri, 14 May 2010)

Log Message:
-----------
Render Branch: disable threading for vector dot product in implicit solver
for now, due to non-commutative nature of floating point ops the sim would
give different results each time! Sometimes subtle, but sometimes also very
different.

Modified Paths:
--------------
    branches/render25/source/blender/blenkernel/intern/implicit.c

Modified: branches/render25/source/blender/blenkernel/intern/implicit.c
===================================================================
--- branches/render25/source/blender/blenkernel/intern/implicit.c	2010-05-14 13:38:29 UTC (rev 28766)
+++ branches/render25/source/blender/blenkernel/intern/implicit.c	2010-05-14 14:48:57 UTC (rev 28767)
@@ -230,8 +230,11 @@
 {
 	long i = 0;
 	float temp = 0.0;
+// XXX brecht, disabled this for now (first schedule line was already disabled),
+// due to non-commutative nature of floating point ops this makes the sim give
+// different results each time you run it!
 // schedule(guided, 2)
-#pragma omp parallel for reduction(+: temp)
+//#pragma omp parallel for reduction(+: temp)
 	for(i = 0; i < (long)verts; i++)
 	{
 		temp += INPR(fLongVectorA[i], fLongVectorB[i]);





More information about the Bf-blender-cvs mailing list