[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [30676] branches/soc-2010-nicolasbishop/ source/blender/blenlib/BLI_pbvh.h: == Sculpt ==

[Jason Wilkins]

Nicholas, I'm guessing this is because you've changed the iterator in your
branch somehow so that it has more fields or uses them differently.  I made
this change because memset was taking a noticeable portion of my profile
times so I eliminated as many as I could (although in this case it is
probably not a huge problem as it gets called once per dab).

On Fri, Jul 23, 2010 at 4:08 PM, Nicholas Bishop
<nicholasbishop at gmail.com>wrote:

> Revision: 30676
>
> http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=30676
> Author:   nicholasbishop
> Date:     2010-07-23 23:08:27 +0200 (Fri, 23 Jul 2010)
>
> Log Message:
> -----------
> == Sculpt ==
>
> Fix for some brushes exploding
>
> * Replaced partial initialization of pbvh iterator with memset (this was
> how it was originally, probably changed after merging from trunk some time I
> guess)
>
> Modified Paths:
> --------------
>    branches/soc-2010-nicolasbishop/source/blender/blenlib/BLI_pbvh.h
>
> Modified: branches/soc-2010-nicolasbishop/source/blender/blenlib/BLI_pbvh.h
> ===================================================================
> --- branches/soc-2010-nicolasbishop/source/blender/blenlib/BLI_pbvh.h
> 2010-07-23 20:57:52 UTC (rev 30675)
> +++ branches/soc-2010-nicolasbishop/source/blender/blenlib/BLI_pbvh.h
> 2010-07-23 21:08:27 UTC (rev 30676)
> @@ -225,11 +225,7 @@
>                int *grid_indices, totgrid, gridsize, *vert_indices,
> uniq_verts, totvert; \
>                struct GridKey *gridkey; \
>                \
> -               vi.grid= 0; \
> -               vi.no= 0; \
> -               vi.fno= 0; \
> -               vi.mvert= 0; \
> -               vi.skip= 0; \
> +               memset(&vi, 0, sizeof(PBVHVertexIter)); \
>                \
>                BLI_pbvh_node_get_grids(bvh, node, &grid_indices, &totgrid,
> NULL, &gridsize, &grids, NULL, &gridkey); \
>                BLI_pbvh_node_num_verts(bvh, node, &uniq_verts, &totvert); \
>
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.blender.org/pipermail/bf-blender-cvs/attachments/20100725/757a1397/attachment.html>