[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [26619] trunk/blender/source/blender/ editors/space_view3d/view3d_select.c: bugfix [#20936] Making lasso-selection of verts in weightpaint-mode "misses target"

[Campbell Barton]

Revision: 26619
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=26619
Author:   campbellbarton
Date:     2010-02-05 11:17:43 +0100 (Fri, 05 Feb 2010)

Log Message:
-----------
bugfix [#20936] Making lasso-selection of verts in weightpaint-mode "misses target"
xray objects can overwrite the view's obmat.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_view3d/view3d_select.c

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_select.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_select.c	2010-02-05 08:14:33 UTC (rev 26618)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_select.c	2010-02-05 10:17:43 UTC (rev 26619)
@@ -468,9 +468,8 @@
 	data.pass = 0;
 
 	/* workaround: init mats first, EM_mask_init_backbuf_border can change
-	   view matrix to pixel space, breaking edge select with backbuf .. */
-	// XXX not needed anymore, check here if selection is broken
-	//ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
+	   view matrix to pixel space, breaking edge select with backbuf. fixes bug #20936 */
+	ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
 	bbsel= EM_mask_init_backbuf_border(vc, mcords, moves, rect.xmin, rect.ymin, rect.xmax, rect.ymax);
 	
 	if(ts->selectmode & SCE_SELECT_VERTEX) {
@@ -1396,10 +1395,9 @@
 		EM_deselect_all(vc->em);
 	}
 
-	/* XXX Don't think we need this, it break selection of transformed objects.
-	 * Also, it's not done by Circle select and that works fine
-	 */
-	//ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
+	/* workaround: init mats first, EM_mask_init_backbuf_border can change
+	   view matrix to pixel space, breaking edge select with backbuf. fixes bug #20936 */
+	ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
 	bbsel= EM_init_backbuf_border(vc, rect->xmin, rect->ymin, rect->xmax, rect->ymax);
 
 	if(ts->selectmode & SCE_SELECT_VERTEX) {