[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [28006] trunk/blender/source/blender/ editors/space_view3d/view3d_edit.c: 'Fix' [#21843] Manipulating Set Render Border sliders causes a crash

Matt Ebb matt at mke3.net
Mon Apr 5 10:13:05 CEST 2010


Revision: 28006
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=28006
Author:   broken
Date:     2010-04-05 10:13:04 +0200 (Mon, 05 Apr 2010)

Log Message:
-----------
'Fix' [#21843] Manipulating Set Render Border sliders causes a crash

Just make the operator cancel if the region in the context is not a RegionView3d.
This is not an issue isolated to this operator, it affects other ones that require a
RegionView3d too, like knife. One to solve for later, at least this doesn't crash now.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_view3d/view3d_edit.c

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_edit.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_edit.c	2010-04-05 07:57:05 UTC (rev 28005)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_edit.c	2010-04-05 08:13:04 UTC (rev 28006)
@@ -1493,6 +1493,9 @@
 	rect.xmax= RNA_int_get(op->ptr, "xmax");
 	rect.ymax= RNA_int_get(op->ptr, "ymax");
 
+	if (!ar || ar->regiontype != RGN_TYPE_WINDOW)
+		return OPERATOR_CANCELLED;
+	
 	/* calculate range */
 	calc_viewborder(scene, ar, v3d, &vb);
 





More information about the Bf-blender-cvs mailing list