[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [24080] trunk/blender/source/blender/ editors/space_view3d/view3d_select.c: Bugreports #19724 and #19725 for Lasso Select

Joshua Leung aligorith at gmail.com
Mon Oct 26 04:35:38 CET 2009


Revision: 24080
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=24080
Author:   aligorith
Date:     2009-10-26 04:35:37 +0100 (Mon, 26 Oct 2009)

Log Message:
-----------
Bugreports #19724 and #19725 for Lasso Select

Fixes for these were provided by the submitter, Clark Tucker (ctucker_toc). Thanks!

- #19724: Fix for problems with lasso select with 'occlude background geometry' turned off. Removed a duplicate call to ED_view3d_init_mats_rv3d(). 
(NOTE: I couldn't reproduce the error on my system, but the duplicate call does look rather fishy. Removing it doesn't seem to have any negative effects at least)
- #19725: Lasso select does not update 'selected vertex count' in 'INFO bar'. Added a notifier here to get the counter refreshed.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_view3d/view3d_select.c

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_select.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_select.c	2009-10-25 10:52:18 UTC (rev 24079)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_select.c	2009-10-26 03:35:37 UTC (rev 24080)
@@ -146,10 +146,6 @@
 
 /* ********************** view3d_select: selection manipulations ********************* */
 
-/* XXX to solve *************** */
-static void BIF_undo_push() {}
-/* XXX end ********************* */
-
 /* local prototypes */
 
 void EM_backbuf_checkAndSelectVerts(EditMesh *em, int select)
@@ -461,8 +457,6 @@
 	bbsel= EM_mask_init_backbuf_border(vc, mcords, moves, rect.xmin, rect.ymin, rect.xmax, rect.ymax);
 	ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
 	
-	ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
-
 	if(ts->selectmode & SCE_SELECT_VERTEX) {
 		if (bbsel) {
 			EM_backbuf_checkAndSelectVerts(vc->em, select);
@@ -723,9 +717,8 @@
 		do_lasso_select_lattice(vc, mcords, moves, select);
 	else if(vc->obedit->type==OB_ARMATURE)
 		do_lasso_select_armature(vc, mcords, moves, select);
-
-	BIF_undo_push("Lasso select");
 	
+	WM_event_add_notifier(C, NC_GEOM|ND_SELECT, vc->obedit->data);
 }
 
 





More information about the Bf-blender-cvs mailing list