[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [23808] trunk/blender/source/blender/ editors/space_view3d/drawarmature.c: Armature Ghosting Bugfix:

Joshua Leung aligorith at gmail.com
Tue Oct 13 14:09:12 CEST 2009


Revision: 23808
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=23808
Author:   aligorith
Date:     2009-10-13 14:09:11 +0200 (Tue, 13 Oct 2009)

Log Message:
-----------
Armature Ghosting Bugfix:

I noticed that armature drawing seemed to be using the wrong colours for ghosting in some situations (in particular, Cessen's biped rig for 2.5). Commented out what appears to be the offending code for now. 

Not totally sure why this broke yet, but as possible bonus of this, we sometimes get coloured ghosted controls (if bone groups were in use). 

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_view3d/drawarmature.c

Modified: trunk/blender/source/blender/editors/space_view3d/drawarmature.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/drawarmature.c	2009-10-13 11:32:03 UTC (rev 23807)
+++ trunk/blender/source/blender/editors/space_view3d/drawarmature.c	2009-10-13 12:09:11 UTC (rev 23808)
@@ -1654,6 +1654,7 @@
 							/* prepare colors */
 							if (arm->flag & ARM_POSEMODE)	
 								set_pchan_colorset(ob, pchan);
+#if 0 // XXX - 13 October 2009, Disabled this to make ghosting show the right colors (Aligorith)
 							else {
 								if ((scene->basact)==base) {
 									if (base->flag & (SELECT+BA_WAS_SEL)) UI_ThemeColor(TH_ACTIVE);
@@ -1664,6 +1665,7 @@
 									else UI_ThemeColor(TH_WIRE);
 								}
 							}
+#endif
 								
 							/* catch exception for bone with hidden parent */
 							flag= bone->flag;
@@ -1755,7 +1757,7 @@
 					
 					/* extra draw service for pose mode */
 					constflag= pchan->constflag;
-					if (pchan->flag & (POSE_ROT|POSE_LOC|POSE_SIZE))	// XXX this is useless crap
+					if (pchan->flag & (POSE_ROT|POSE_LOC|POSE_SIZE))
 						constflag |= PCHAN_HAS_ACTION;
 					if (pchan->flag & POSE_STRIDE)
 						constflag |= PCHAN_HAS_STRIDE;





More information about the Bf-blender-cvs mailing list