[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [19429] trunk/blender/source/blender: removed unneeded arg from makeknots() and replaced some numbers with defines
Campbell Barton
ideasman42 at gmail.com
Sat Mar 28 06:51:20 CET 2009
Revision: 19429
http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=19429
Author: campbellbarton
Date: 2009-03-28 06:51:18 +0100 (Sat, 28 Mar 2009)
Log Message:
-----------
removed unneeded arg from makeknots() and replaced some numbers with defines
Modified Paths:
--------------
trunk/blender/source/blender/blenkernel/BKE_curve.h
trunk/blender/source/blender/blenkernel/intern/curve.c
trunk/blender/source/blender/python/api2_2x/CurNurb.c
trunk/blender/source/blender/python/api2_2x/SurfNurb.c
trunk/blender/source/blender/src/buttons_editing.c
trunk/blender/source/blender/src/drawobject.c
trunk/blender/source/blender/src/drawview.c
trunk/blender/source/blender/src/editcurve.c
trunk/blender/source/blender/src/editobject.c
Modified: trunk/blender/source/blender/blenkernel/BKE_curve.h
===================================================================
--- trunk/blender/source/blender/blenkernel/BKE_curve.h 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/blenkernel/BKE_curve.h 2009-03-28 05:51:18 UTC (rev 19429)
@@ -63,7 +63,7 @@
void test2DNurb( struct Nurb *nu);
void minmaxNurb( struct Nurb *nu, float *min, float *max);
-void makeknots( struct Nurb *nu, short uv, short type);
+void makeknots( struct Nurb *nu, short uv);
void makeNurbfaces(struct Nurb *nu, float *coord_array, int rowstride);
void makeNurbcurve(struct Nurb *nu, float *coord_array, float *tilt_array, float *radius_array, int resolu);
Modified: trunk/blender/source/blender/blenkernel/intern/curve.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/curve.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/blenkernel/intern/curve.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -554,8 +554,8 @@
}
-/* type - 0: uniform, 1: endpoints, 2: bezier, note, cyclic nurbs are always uniform */
-void makeknots(Nurb *nu, short uv, short type)
+
+void makeknots(Nurb *nu, short uv)
{
if( (nu->type & 7)==CU_NURBS ) {
if(uv == 1) {
@@ -566,7 +566,7 @@
calcknots(nu->knotsu, nu->pntsu, nu->orderu, 0); /* cyclic should be uniform */
makecyclicknots(nu->knotsu, nu->pntsu, nu->orderu);
} else {
- calcknots(nu->knotsu, nu->pntsu, nu->orderu, type);
+ calcknots(nu->knotsu, nu->pntsu, nu->orderu, nu->flagu>>1);
}
}
else nu->knotsu= NULL;
@@ -579,7 +579,7 @@
calcknots(nu->knotsv, nu->pntsv, nu->orderv, 0); /* cyclic should be uniform */
makecyclicknots(nu->knotsv, nu->pntsv, nu->orderv);
} else {
- calcknots(nu->knotsv, nu->pntsv, nu->orderv, type);
+ calcknots(nu->knotsv, nu->pntsv, nu->orderv, nu->flagv>>1);
}
}
else nu->knotsv= NULL;
@@ -2333,7 +2333,7 @@
if(code==1 || code==2) {
nu= editNurb.first;
while(nu) {
- if( (nu->type & 7)==1) {
+ if( (nu->type & 7)==CU_BEZIER) {
bezt= nu->bezt;
a= nu->pntsu;
while(a--) {
@@ -2363,7 +2363,7 @@
} else {
/* Toggle */
while(nu) {
- if( (nu->type & 7)==1) {
+ if( (nu->type & 7)==CU_BEZIER) {
bezt= nu->bezt;
a= nu->pntsu;
while(a--) {
@@ -2380,7 +2380,7 @@
}
nu= editNurb.first;
while(nu) {
- if( (nu->type & 7)==1) {
+ if( (nu->type & 7)==CU_BEZIER) {
bezt= nu->bezt;
a= nu->pntsu;
while(a--) {
Modified: trunk/blender/source/blender/python/api2_2x/CurNurb.c
===================================================================
--- trunk/blender/source/blender/python/api2_2x/CurNurb.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/python/api2_2x/CurNurb.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -564,7 +564,7 @@
tmp->radius = radius;
tmp->weight = 0.0; /* softbody weight TODO - add access to this, is zero elsewhere but through blender is 1.0 by default */
- makeknots( nurb, 1, nurb->flagu >> 1 );
+ makeknots(nurb, 1);
} else {
/* bail with error */
@@ -649,7 +649,7 @@
if( self->nurb->flagu != value ) {
self->nurb->flagu = (short)value;
- makeknots( self->nurb, 1, self->nurb->flagu >> 1 );
+ makeknots(self->nurb, 1);
}
return 0;
@@ -698,7 +698,7 @@
if( self->nurb->flagv != value ) {
self->nurb->flagv = (short)value;
- makeknots( self->nurb, 2, self->nurb->flagv >> 1 );
+ makeknots( self->nurb, 2);
}
return 0;
@@ -728,7 +728,7 @@
order = self->nurb->pntsu;
self->nurb->orderu = (short)order;
- makeknots( self->nurb, 1, self->nurb->flagu >> 1 );
+ makeknots(self->nurb, 1);
return 0;
}
Modified: trunk/blender/source/blender/python/api2_2x/SurfNurb.c
===================================================================
--- trunk/blender/source/blender/python/api2_2x/SurfNurb.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/python/api2_2x/SurfNurb.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -195,7 +195,7 @@
nurb->bp[npoints].alfa = 0.0f;
}
- makeknots( nurb, 1, nurb->flagu >> 1 );
+ makeknots(nurb, 1);
} else {
return EXPP_ReturnPyObjError( PyExc_TypeError,
@@ -322,7 +322,7 @@
flagu = (flagu << 1) | (self->nurb->flagu & CU_CYCLIC);
if( self->nurb->flagu != flagu ) {
self->nurb->flagu = (short)flagu;
- makeknots( self->nurb, 1, self->nurb->flagu >> 1 );
+ makeknots(self->nurb, 1);
}
return 0;
@@ -366,7 +366,7 @@
flagv = (flagv << 1) | (self->nurb->flagv & CU_CYCLIC);
if( self->nurb->flagv != flagv ) {
self->nurb->flagv = (short)flagv;
- makeknots( self->nurb, 2, self->nurb->flagv >> 1 );
+ makeknots(self->nurb, 2);
}
return 0;
@@ -402,7 +402,7 @@
order = self->nurb->pntsu;
self->nurb->orderu = (short)order;
- makeknots( self->nurb, 1, self->nurb->flagu >> 1 );
+ makeknots(self->nurb, 1);
return 0;
}
@@ -431,7 +431,7 @@
order = self->nurb->pntsv;
self->nurb->orderv = (short)order;
- makeknots( self->nurb, 2, self->nurb->flagv >> 1 );
+ makeknots(self->nurb, 2);
return 0;
}
@@ -467,7 +467,7 @@
self->nurb->flagu |= CU_CYCLIC;
else
self->nurb->flagu &= ~CU_CYCLIC;
- makeknots( self->nurb, 1, self->nurb->flagu >> 1 );
+ makeknots(self->nurb, 1);
return 0;
}
@@ -482,7 +482,7 @@
self->nurb->flagv |= CU_CYCLIC;
else
self->nurb->flagv &= ~CU_CYCLIC;
- makeknots( self->nurb, 2, self->nurb->flagv >> 1 );
+ makeknots(self->nurb, 2);
return 0;
}
Modified: trunk/blender/source/blender/src/buttons_editing.c
===================================================================
--- trunk/blender/source/blender/src/buttons_editing.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/src/buttons_editing.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -3311,13 +3311,13 @@
nu->flagu &= CU_CYCLIC; /* disable all flags except for CU_CYCLIC */
nu->flagu |= ((event-B_UNIFU)<<1);
clamp_nurb_order_u(nu);
- makeknots(nu, 1, nu->flagu>>1);
+ makeknots(nu, 1);
}
else if(nu->pntsv>1) {
nu->flagv &= CU_CYCLIC; /* disable all flags except for CU_CYCLIC */
nu->flagv |= ((event-B_UNIFV)<<1);
clamp_nurb_order_v(nu);
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 2);
}
}
}
@@ -3359,11 +3359,11 @@
if(clamp_nurb_order_u(nu)) {
scrarea_queue_winredraw(curarea);
}
- makeknots(nu, 1, nu->flagu>>1);
+ makeknots(nu, 1);
if(clamp_nurb_order_v(nu)) {
scrarea_queue_winredraw(curarea);
}
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 2);
}
BIF_undo_push("Make knots");
DAG_object_flush_update(G.scene, G.obedit, OB_RECALC_DATA);
Modified: trunk/blender/source/blender/src/drawobject.c
===================================================================
--- trunk/blender/source/blender/src/drawobject.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/src/drawobject.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -3777,7 +3777,7 @@
glBegin(GL_LINES);
- if( (nu->type & 7)==1) {
+ if( (nu->type & 7)==CU_BEZIER) {
if(sel) col= nurbcol+4;
else col= nurbcol;
@@ -3834,7 +3834,7 @@
bglBegin(GL_POINTS);
- if((nu->type & 7)==1) {
+ if((nu->type & 7)==CU_BEZIER) {
bezt= nu->bezt;
a= nu->pntsu;
Modified: trunk/blender/source/blender/src/drawview.c
===================================================================
--- trunk/blender/source/blender/src/drawview.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/src/drawview.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -1773,7 +1773,7 @@
nu= editNurb.first;
while(nu) {
- if((nu->type & 7)==1) {
+ if((nu->type & 7)==CU_BEZIER) {
bezt= nu->bezt;
a= nu->pntsu;
while(a--) {
Modified: trunk/blender/source/blender/src/editcurve.c
===================================================================
--- trunk/blender/source/blender/src/editcurve.c 2009-03-28 04:25:21 UTC (rev 19428)
+++ trunk/blender/source/blender/src/editcurve.c 2009-03-28 05:51:18 UTC (rev 19429)
@@ -691,7 +691,7 @@
nu->bp= newbp;
clamp_nurb_order_v(nu);
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 2);
}
else {
/* is the nurb in V direction selected */
@@ -737,7 +737,7 @@
nu->pntsu= newu;
clamp_nurb_order_u(nu);
}
- makeknots(nu, 1, nu->flagu>>1);
+ makeknots(nu, 1);
}
}
}
@@ -785,7 +785,7 @@
nu->pntsv= 2;
nu->orderv= 2;
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 2);
}
}
else {
@@ -828,7 +828,7 @@
MEM_freeN(nu->bp);
nu->bp= newbp;
nu->pntsv++;
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 2);
}
else if(v==0 || v== nu->pntsu-1) { /* collumn in v-direction selected */
ok= 1;
@@ -855,7 +855,7 @@
MEM_freeN(nu->bp);
nu->bp= newbp;
nu->pntsu++;
- makeknots(nu, 1, nu->flagu>>1);
+ makeknots(nu, 1);
}
}
}
@@ -949,7 +949,7 @@
/* knots */
newnu->knotsu= NULL;
- makeknots(newnu, 1, newnu->flagu>>1);
+ makeknots(newnu, 1);
}
bp++;
}
@@ -1013,14 +1013,14 @@
if(nu->pntsu==newnu->pntsu && nu->knotsu) {
newnu->knotsu= MEM_dupallocN( nu->knotsu );
} else {
- makeknots(newnu, 1, newnu->flagu>>1);
+ makeknots(newnu, 1);
}
}
if (check_valid_nurb_v(newnu)) {
if(nu->pntsv==newnu->pntsv && nu->knotsv) {
newnu->knotsv= MEM_dupallocN( nu->knotsv );
} else {
- makeknots(newnu, 2, newnu->flagv>>1);
+ makeknots(newnu, 2);
}
}
}
@@ -1779,8 +1779,8 @@
nu->bp= bpnew;
nu->pntsu+= amount;
- if(nu->type & 4) {
- makeknots(nu, 1, nu->flagu>>1);
+ if(nu->type & CU_NURBS) {
+ makeknots(nu, 1);
}
}
} /* End of 'else if(nu->pntsv==1)' */
@@ -1891,8 +1891,8 @@
nu->bp= bpnew;
nu->pntsu= 2*nu->pntsu-1;
nu->pntsv= 2*nu->pntsv-1;
- makeknots(nu, 1, nu->flagu>>1);
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 1);
+ makeknots(nu, 2);
} /* End of 'if(sel== nu->pntsu*nu->pntsv)' (subdivide entire NURB) */
else {
/* subdivide in v direction? */
@@ -1935,7 +1935,7 @@
MEM_freeN(nu->bp);
nu->bp= bpnew;
nu->pntsv+= sel;
- makeknots(nu, 2, nu->flagv>>1);
+ makeknots(nu, 2);
}
else {
/* or in u direction? */
@@ -1975,7 +1975,7 @@
@@ Diff output truncated at 10240 characters. @@
More information about the Bf-blender-cvs
mailing list