[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [21145] trunk/blender/source/blender/ python/api2_2x/quat.c: Mathutils quat1 * quat2 was broken, returned quat1*quat1 instead.

Campbell Barton ideasman42 at gmail.com
Thu Jun 25 03:37:27 CEST 2009


Revision: 21145
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=21145
Author:   campbellbarton
Date:     2009-06-25 03:37:19 +0200 (Thu, 25 Jun 2009)

Log Message:
-----------
Mathutils quat1 * quat2 was broken, returned quat1*quat1 instead.

Modified Paths:
--------------
    trunk/blender/source/blender/python/api2_2x/quat.c

Modified: trunk/blender/source/blender/python/api2_2x/quat.c
===================================================================
--- trunk/blender/source/blender/python/api2_2x/quat.c	2009-06-25 01:08:14 UTC (rev 21144)
+++ trunk/blender/source/blender/python/api2_2x/quat.c	2009-06-25 01:37:19 UTC (rev 21145)
@@ -417,7 +417,6 @@
 {
 	int x;
 	float quat[4], scalar;
-	double dot = 0.0f;
 	QuaternionObject *quat1 = NULL, *quat2 = NULL;
 	PyObject *f = NULL;
 	VectorObject *vec = NULL;
@@ -466,10 +465,7 @@
 				return quat_rotation((PyObject*)quat1, (PyObject*)vec);
 			}
 		}else{  //QUAT * QUAT (dot product)
-			for(x = 0; x < 4; x++) {
-				dot += quat1->quat[x] * quat1->quat[x];
-			}
-			return PyFloat_FromDouble(dot);
+			return PyFloat_FromDouble(QuatDot(quat1->quat, quat2->quat));
 		}
 	}
 





More information about the Bf-blender-cvs mailing list