[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20868] trunk/blender/source/blender/gpu/ intern/gpu_extensions.c: coverity issue CID: 275
Kent Mein
mein at cs.umn.edu
Sun Jun 14 00:31:14 CEST 2009
Revision: 20868
http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20868
Author: sirdude
Date: 2009-06-14 00:31:14 +0200 (Sun, 14 Jun 2009)
Log Message:
-----------
coverity issue CID: 275
Checker: FORWARD_NULL (help)
File: base/src/source/blender/gpu/intern/gpu_extensions.c
Function: GPU_shader_create
Description: Variable "fragcode" tracked as NULL was passed to a function that dereferences it.
fix provided by Brecht. :)
Kent
Modified Paths:
--------------
trunk/blender/source/blender/gpu/intern/gpu_extensions.c
Modified: trunk/blender/source/blender/gpu/intern/gpu_extensions.c
===================================================================
--- trunk/blender/source/blender/gpu/intern/gpu_extensions.c 2009-06-13 22:23:24 UTC (rev 20867)
+++ trunk/blender/source/blender/gpu/intern/gpu_extensions.c 2009-06-13 22:31:14 UTC (rev 20868)
@@ -746,7 +746,9 @@
glGetObjectParameterivARB(shader->object, GL_OBJECT_LINK_STATUS_ARB, &status);
if (!status) {
glGetInfoLogARB(shader->object, sizeof(log), &length, log);
- shader_print_errors("linking", log, fragcode);
+ if (fragecode) shader_print_errors("linking", log, fragcode);
+ else if (vertexcode) shader_print_errors("linking", log, vertexcode);
+ else if (libcode) shader_print_errors("linking", log, libcode);
GPU_shader_free(shader);
return NULL;
More information about the Bf-blender-cvs
mailing list