[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20861] trunk/blender/source/blender/imbuf /intern/radiance_hdr.c: coverity issue CID: 401

Kent Mein mein at cs.umn.edu
Sat Jun 13 18:52:03 CEST 2009


Revision: 20861
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20861
Author:   sirdude
Date:     2009-06-13 18:52:01 +0200 (Sat, 13 Jun 2009)

Log Message:
-----------
coverity issue CID: 401
Checker: NULL_RETURNS (help)
File: base/src/source/blender/imbuf/intern/radiance_hdr.c
Function: imb_loadhdr
Description: Incrementing possibly NULL value "ptr"

Make sure were not trying to index past our array.

Kent

Modified Paths:
--------------
    trunk/blender/source/blender/imbuf/intern/radiance_hdr.c

Modified: trunk/blender/source/blender/imbuf/intern/radiance_hdr.c
===================================================================
--- trunk/blender/source/blender/imbuf/intern/radiance_hdr.c	2009-06-13 16:49:30 UTC (rev 20860)
+++ trunk/blender/source/blender/imbuf/intern/radiance_hdr.c	2009-06-13 16:52:01 UTC (rev 20861)
@@ -191,7 +191,7 @@
 				break;
 			}
 		}
-		if (found) {
+		if (found && (x<(size + 2))) {
 			if (sscanf((char *)&mem[x+1], "%79s %d %79s %d", (char*)&oriY, &height, 
 				(char*)&oriX, &width) != 4) return NULL;
 





More information about the Bf-blender-cvs mailing list