[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20657] trunk/blender/source/blender/src/ poseobject.c: coverity issue CID: 97

Kent Mein mein at cs.umn.edu
Fri Jun 5 18:53:23 CEST 2009


Revision: 20657
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20657
Author:   sirdude
Date:     2009-06-05 18:53:21 +0200 (Fri, 05 Jun 2009)

Log Message:
-----------
coverity issue CID: 97
Checker: FORWARD_NULL (help)
File: base/src/source/blender/src/poseobject.c
Function: pose_special_editmenu
Description: Variable "ob" tracked as NULL was dereferenced.

logic was wrong (gets complicated when you use !'s ;))

Kent

Modified Paths:
--------------
    trunk/blender/source/blender/src/poseobject.c

Modified: trunk/blender/source/blender/src/poseobject.c
===================================================================
--- trunk/blender/source/blender/src/poseobject.c	2009-06-05 16:11:35 UTC (rev 20656)
+++ trunk/blender/source/blender/src/poseobject.c	2009-06-05 16:53:21 UTC (rev 20657)
@@ -551,7 +551,7 @@
 	short nr;
 	
 	/* paranoia checks */
-	if(!ob && !ob->pose) return;
+	if(!ob || !ob->pose) return;
 	if(ob==G.obedit || (ob->flag & OB_POSEMODE)==0) return;
 	
 	nr= pupmenu("Specials%t|Select Constraint Target%x1|Flip Left-Right Names%x2|Calculate Paths%x3|Clear Paths%x4|Clear User Transform %x5|Relax Pose %x6|%l|AutoName Left-Right%x7|AutoName Front-Back%x8|AutoName Top-Bottom%x9");





More information about the Bf-blender-cvs mailing list