[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20643] trunk/blender/source/blender/imbuf /intern/anim.c: coverity issue CID: 484

Kent Mein mein at cs.umn.edu
Fri Jun 5 05:40:58 CEST 2009


Revision: 20643
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20643
Author:   sirdude
Date:     2009-06-05 05:40:58 +0200 (Fri, 05 Jun 2009)

Log Message:
-----------
coverity issue CID: 484
Checker: REVERSE_INULL (help)
File: base/src/source/blender/imbuf/intern/anim.c
Function: IMB_anim_absolute
Description: Pointer "anim" dereferenced before NULL check

again moving init code after check to valid pointer.

Kent

Modified Paths:
--------------
    trunk/blender/source/blender/imbuf/intern/anim.c

Modified: trunk/blender/source/blender/imbuf/intern/anim.c
===================================================================
--- trunk/blender/source/blender/imbuf/intern/anim.c	2009-06-05 03:24:06 UTC (rev 20642)
+++ trunk/blender/source/blender/imbuf/intern/anim.c	2009-06-05 03:40:58 UTC (rev 20643)
@@ -1046,10 +1046,11 @@
 	char head[256], tail[256];
 	unsigned short digits;
 	int pic;
-	int filter_y = (anim->ib_flags & IB_animdeinterlace);
-
+	int filter_y;
 	if (anim == NULL) return(0);
 
+	filter_y = (anim->ib_flags & IB_animdeinterlace);
+
 	if (anim->curtype == 0)	{
 		ibuf = anim_getnew(anim);
 		if (ibuf == NULL) {





More information about the Bf-blender-cvs mailing list