[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20604] trunk/blender/source/blender/src/ toolbox.c: coverity CID: 374

Kent Mein mein at cs.umn.edu
Wed Jun 3 17:24:43 CEST 2009


Revision: 20604
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20604
Author:   sirdude
Date:     2009-06-03 17:24:42 +0200 (Wed, 03 Jun 2009)

Log Message:
-----------
coverity CID: 374
Checker: FORWARD_NULL (help)
File: base/src/source/blender/src/toolbox.c
Function: tb_do_render
Description: Variable "ca" tracked as NULL was dereferenced.

Moved check for null to include else statement.

Kent

Modified Paths:
--------------
    trunk/blender/source/blender/src/toolbox.c

Modified: trunk/blender/source/blender/src/toolbox.c
===================================================================
--- trunk/blender/source/blender/src/toolbox.c	2009-06-03 15:17:52 UTC (rev 20603)
+++ trunk/blender/source/blender/src/toolbox.c	2009-06-03 15:24:42 UTC (rev 20604)
@@ -1545,10 +1545,12 @@
 				ca= G.vd->camera->data;
 			else return;
 				
-			if (ca && (ca->flag & CAM_SHOWPASSEPARTOUT))
-				ca->flag &= ~CAM_SHOWPASSEPARTOUT;
-			else
-				ca->flag |= CAM_SHOWPASSEPARTOUT;
+			if (ca) {
+				if (ca->flag & CAM_SHOWPASSEPARTOUT)
+					ca->flag &= ~CAM_SHOWPASSEPARTOUT;
+				else
+					ca->flag |= CAM_SHOWPASSEPARTOUT;
+			}
 			allqueue(REDRAWVIEW3D, 0);
 		}
 			break;





More information about the Bf-blender-cvs mailing list