[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20601] trunk/blender/source/blender/ python/api2_2x/sceneSequence.c: This is coverity issue:

Kent Mein mein at cs.umn.edu
Wed Jun 3 16:55:41 CEST 2009


Revision: 20601
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20601
Author:   sirdude
Date:     2009-06-03 16:55:41 +0200 (Wed, 03 Jun 2009)

Log Message:
-----------
This is coverity issue:
CID: 595
Checker: OVERRUN_STATIC (help)
File: base/src/source/blender/python/api2_2x/sceneSequence.c
Function: Sequence_setProxyDir
Description: Overrun of static array "&((((self)->seq)->strip)->proxy)->dir" of size 160 bytes by passing it to a function which indexes it with argument "248" at byte position 247

Wasn't using the size of dir it was using the sizeof the struct dir is in.

Fixed.

Kent

Modified Paths:
--------------
    trunk/blender/source/blender/python/api2_2x/sceneSequence.c

Modified: trunk/blender/source/blender/python/api2_2x/sceneSequence.c
===================================================================
--- trunk/blender/source/blender/python/api2_2x/sceneSequence.c	2009-06-03 14:42:28 UTC (rev 20600)
+++ trunk/blender/source/blender/python/api2_2x/sceneSequence.c	2009-06-03 14:55:41 UTC (rev 20601)
@@ -727,7 +727,7 @@
 	else
 	{
 		self->seq->strip->proxy = MEM_callocN(sizeof (struct StripProxy), "StripProxy");
-		strncpy(self->seq->strip->proxy->dir, name, sizeof (struct StripProxy));
+		strncpy(self->seq->strip->proxy->dir, name, 160);
 	}
 	return 0;
 }





More information about the Bf-blender-cvs mailing list