[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [21889] branches/soc-2008-mxcurioni/source /blender/freestyle/intern/stroke/ChainingIterators.h: Fixed a problem related to AdjacencyIterator.

Tamito Kajiyama rd6t-kjym at asahi-net.or.jp
Sat Jul 25 20:02:35 CEST 2009


Revision: 21889
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=21889
Author:   kjym3
Date:     2009-07-25 20:02:34 +0200 (Sat, 25 Jul 2009)

Log Message:
-----------
Fixed a problem related to AdjacencyIterator.  In the Python layer,
AdjacencyIterator::isBegin() and AdjacencyIterator::isEnd() always
returned a False value and printed a "not implemented" warning message.
This caused an infinite loop in a few chaining iterators, resulting in
a crash of the program.  The origin of the issue seemed to be a fact
that in the C++ layer, the AdjacencyIterator class had not properly
overloaded the definitions of the methods in the Iterator superclass.
The fix here looks okay, although I'm not sure why this inconsistency
was not addressed for a long time.

Modified Paths:
--------------
    branches/soc-2008-mxcurioni/source/blender/freestyle/intern/stroke/ChainingIterators.h

Modified: branches/soc-2008-mxcurioni/source/blender/freestyle/intern/stroke/ChainingIterators.h
===================================================================
--- branches/soc-2008-mxcurioni/source/blender/freestyle/intern/stroke/ChainingIterators.h	2009-07-25 16:10:17 UTC (rev 21888)
+++ branches/soc-2008-mxcurioni/source/blender/freestyle/intern/stroke/ChainingIterators.h	2009-07-25 18:02:34 UTC (rev 21889)
@@ -79,10 +79,10 @@
     return "AdjacencyIterator";
   }
 
-  virtual inline bool isEnd(){
+  virtual inline bool isEnd() const {
     return _internalIterator.isEnd();
   }
-  virtual inline bool isBegin(){
+  virtual inline bool isBegin() const {
     return _internalIterator.isBegin();
   }
   /*! Returns true if the current ViewEdge is is coming





More information about the Bf-blender-cvs mailing list