[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [25632] trunk/blender/source/blender/ editors/space_view3d/view3d_edit.c: Fix crash in View -> Navigation menu ( not all view3d regions have a regionview3d, especially not menus.

Martin Poirier theeth at yahoo.com
Wed Dec 30 23:23:51 CET 2009


Revision: 25632
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=25632
Author:   theeth
Date:     2009-12-30 23:23:50 +0100 (Wed, 30 Dec 2009)

Log Message:
-----------
Fix crash in View -> Navigation menu (not all view3d regions have a regionview3d, especially not menus. Meh, stupid work around)

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_view3d/view3d_edit.c

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_edit.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_edit.c	2009-12-30 22:14:32 UTC (rev 25631)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_edit.c	2009-12-30 22:23:50 UTC (rev 25632)
@@ -686,7 +686,12 @@
 		return 0;
 	} else {
 		RegionView3D *rv3d= CTX_wm_region_view3d(C);
-		return rv3d->viewlock == 0;
+		/* rv3d is null in menus, but it's ok when the menu is clicked on */
+		/* XXX of course, this doesn't work with quadview
+		 * Maybe having exec return PASSTHROUGH would be better than polling here
+		 * Poll functions are full of problems anyway.
+		 * */
+		return rv3d == NULL || rv3d->viewlock == 0;
 	}
 }
 





More information about the Bf-blender-cvs mailing list