[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [25563] trunk/blender/source/blender/ editors/interface/interface_handlers.c: the user interface could access invalid RNA on deleting objects since checking the button ran after freeing the data .

Campbell Barton ideasman42 at gmail.com
Sat Dec 26 02:04:46 CET 2009


Revision: 25563
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=25563
Author:   campbellbarton
Date:     2009-12-26 02:04:46 +0100 (Sat, 26 Dec 2009)

Log Message:
-----------
the user interface could access invalid RNA on deleting objects since checking the button ran after freeing the data.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/interface/interface_handlers.c

Modified: trunk/blender/source/blender/editors/interface/interface_handlers.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_handlers.c	2009-12-26 00:17:54 UTC (rev 25562)
+++ trunk/blender/source/blender/editors/interface/interface_handlers.c	2009-12-26 01:04:46 UTC (rev 25563)
@@ -4100,7 +4100,11 @@
 
 	data->state= state;
 
-	ui_check_but(but);
+	if(state != BUTTON_STATE_EXIT) {
+		/* When objects for eg. are removed, running ui_check_but()
+		 * can access the removed data - so disable update on exit */
+		ui_check_but(but);
+	}
 
 	/* redraw */
 	ED_region_tag_redraw(data->region);





More information about the Bf-blender-cvs mailing list