[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [11950] trunk/blender/source/blender/src/ view.c: [#7299] Orbit around selected causes panning to be reversed

Martin Poirier theeth at yahoo.com
Thu Sep 6 23:35:52 CEST 2007

Revision: 11950
Author:   theeth
Date:     2007-09-06 23:35:51 +0200 (Thu, 06 Sep 2007)

Log Message:
[#7299] Orbit around selected causes panning to be reversed

The actual "bug" is much more general than simple viewmove. In fact, any time the center (for viewmove, or transform, or ...) on which initgrabz is called was behind the camera (in perspective, then), all mouse motion where reversed.

What I added is a special handling case that reverts those situation to the default case (center = viewport offset).

This changes the behavior for those case to something much more predictable/useable, but I doubt anyone expected it to work incorrectly, so I'd say that's alright.

This covers other cases than transform and viewmove (which are the only ones I really tested), but I don't expect breakage elsewhere.

If anyone disagrees with the change, feel free to offer a better solution.

Modified Paths:

Modified: trunk/blender/source/blender/src/view.c
--- trunk/blender/source/blender/src/view.c	2007-09-06 20:49:40 UTC (rev 11949)
+++ trunk/blender/source/blender/src/view.c	2007-09-06 21:35:51 UTC (rev 11950)
@@ -152,6 +152,11 @@
 	 * (accounting for near zero values)
 	 * */
 	if (G.vd->zfac < 1.e-6f && G.vd->zfac > -1.e-6f) G.vd->zfac = 1.0f;
+	/* Negative zfac means x, y, z was behind the camera (in perspective).
+	 * This gives flipped directions, so revert back to ok default case.
+	 */
+	if (G.vd->zfac < 0.0f) G.vd->zfac = 1.0f;
 void window_to_3d(float *vec, short mx, short my)

More information about the Bf-blender-cvs mailing list