[Bf-blender-cvs] CVS commit: blender/source/blender/render/intern/source imagetexture.c texture.c

[Ton Roosendaal]

ton (Ton Roosendaal) 2005/11/21 23:47:23 CET

  Modified files:
    blender/source/blender/render/intern/source imagetexture.c 
                                                texture.c 
  
  Log:
  Bugfix #2841
  
  Ancient issue with Image bumpmap & orientation... this report was about
  UV textures, which flipped bump direction when UV coordinates rotate.
  So... time to dive deeper into it, and I found a very bad old construction
  in the way image textures handled bump normals. Instead of using the
  correct dx,dy vectors it was calculating the boundbox for it, and applied
  it as such (loosing negative direction for the dx or dy that way).
  
  Anyhoo! To make a long story short; the weird "correct Nor Map" option
  now can be removed... but requires careful testing!
  
  Here's renders from file I got from env, 239 means old and 240 is this cvs.
  
  http://www.blender.org/bf/dino239.jpg
  http://www.blender.org/bf/dino240.jpg
  
  http://www.blender.org/bf/dino239a.jpg
  http://www.blender.org/bf/dino240a.jpg
  
  Note the much finer detail, and the more consistant normals direction.
  No, go render testing dudes!
  
  Revision  Changes    Path
  1.5       +19 -15    blender/source/blender/render/intern/source/imagetexture.c
    <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/render/intern/source/imagetexture.c.diff?r1=1.4&r2=1.5&cvsroot=bf-blender>
  1.53      +3 -5      blender/source/blender/render/intern/source/texture.c
    <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/blender/render/intern/source/texture.c.diff?r1=1.52&r2=1.53&cvsroot=bf-blender>