[Bf-animsys] Graph editor - selecting things

Jess Balint jbalint at gmail.com
Fri May 29 23:28:13 CEST 2009


On Fri, May 29, 2009 at 10:07:51PM +1200, Joshua Leung wrote:
> Hi,
> 
> I think you should have done this at the more global-level in anim_filter.c
> instead of modifying each function where this might apply. The whole goal of
> this animation filtering system was to avoid having to do hacks like that
> all over the place (see the old 2.4x branches/trunk, especially the NLA
> Editor for an example of how nasty the old filtering stuff was). Keep in
> mind also that if this option is broken for the Graph Editor, it is also
> broken for the DopeSheet (and soon the NLA too).

> What you've done here is really to restrict many select tools to operating
> only on curves that are selected. This doesn't really match what that
> setting is supposed to be used for. Also, you've only 'fixed' this
> selection, while there are also editing tools which should get affected by
> the setting in the exact same way.

Ok, thanks for clarifying this. I had mis-interpreted the way it was
supposed to work to applying the selected channels to curve display.
I've looked through the code (in anim_filter.c), and see that it will
only display the objects selected in the scene, and it is, in fact,
working correctly. :)

> On Fri, May 29, 2009 at 3:32 PM, Jess Balint <jbalint at gmail.com> wrote:
> 
> > Hi,
> > I've attached a patch to get "Only display selected Objects" option
> > working in the graph editor. I think it makes sense, unless there's some
> > other global way to enforce this constraint.
> >
> > However, the fact that border select (and some others), don't select the
> > associated channel when the control points are selected, means you can
> > still have some keys selected (and invisible) that would be translated
> > with a visible key selection. Would it make sense for all selection
> > operations to sync the channel selection to match that of the keys?
> > (and likewise for deselection, eg deselect a channel when none of its
> > keys are selected)
> 
> Yes. There are some syncing issues here that need to be cleaned up.

Are the channel selections between the dope sheet and graph editor
supposed to stay in sync? They seem to want to, but don't seem to be
updated frequently enough.

Jess




More information about the Bf-animsys mailing list