[Bf-animsys] Graph editor - selecting things

Joshua Leung aligorith at gmail.com
Fri May 29 12:07:51 CEST 2009


Hi,

I think you should have done this at the more global-level in anim_filter.c
instead of modifying each function where this might apply. The whole goal of
this animation filtering system was to avoid having to do hacks like that
all over the place (see the old 2.4x branches/trunk, especially the NLA
Editor for an example of how nasty the old filtering stuff was). Keep in
mind also that if this option is broken for the Graph Editor, it is also
broken for the DopeSheet (and soon the NLA too).

What you've done here is really to restrict many select tools to operating
only on curves that are selected. This doesn't really match what that
setting is supposed to be used for. Also, you've only 'fixed' this
selection, while there are also editing tools which should get affected by
the setting in the exact same way.

On Fri, May 29, 2009 at 3:32 PM, Jess Balint <jbalint at gmail.com> wrote:

> Hi,
> I've attached a patch to get "Only display selected Objects" option
> working in the graph editor. I think it makes sense, unless there's some
> other global way to enforce this constraint.
>
> However, the fact that border select (and some others), don't select the
> associated channel when the control points are selected, means you can
> still have some keys selected (and invisible) that would be translated
> with a visible key selection. Would it make sense for all selection
> operations to sync the channel selection to match that of the keys?
> (and likewise for deselection, eg deselect a channel when none of its
> keys are selected)

Yes. There are some syncing issues here that need to be cleaned up.


Joshua
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.blender.org/pipermail/bf-animsys/attachments/20090529/6b18cdc1/attachment.html>


More information about the Bf-animsys mailing list