[Verse-dev] Bug in server handling of method group subscription

Emil Brink verse-dev@blender.org
Fri, 11 Jun 2004 13:04:13 +0200 (MEST)


Eskil,

the following code from vs_node_object.c, in the function
callback_send_o_method_group_subscribe(), seems wrong:

if(node->groups[group_id].methods[i].name[0] != 0)
{
	char *names[255];
	for(j = 0; j < node->groups[group_id].methods[i].param_count; j++)
		names[j] = &node->groups[group_id].methods[i].name[j * 16];
                                                              ^^^ HELLO
	verse_send_o_method_create(node_id, group_id, i, node->groups[group_id].methods[i].name, node->groups[group_id].methods[i].param_count, node->groups[group_id].methods[i].param_types, names);
}

The marked field should be param_name, as it is now it describes all
parameters as having the name of the method itself, which I doubt is
correct.

Regards,

/Emil