<div dir="ltr"><div>Thanks for the tests. To me the before renders still look better? While 3x gives similar noise levels, the results are less accurate, the hair is noticeably brighter.<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 24, 2018 at 10:40 PM Leonardo E. Segovia <<a href="mailto:leonardo.segovia@cs.uns.edu.ar">leonardo.segovia@cs.uns.edu.ar</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hey all, hi Brecht,</div><div><br></div>As regards noise and fireflies, they come from basically two places:<div>- Low Roughness. This compress (longitudinally) the glints so much, they look like fireflies.</div><div>- Low Radial Roughness. These make the hair look SO soft!<br></div><div>- Very lightly colored hair (this one is non fixeable by us)<br></div><div><br></div><div>Possible mitigations include:</div><div>- Raising the clamp from 0.001 to 0.01 to at least have a reasonable glint when Roughness < 0.1</div><div>- Filter Glossy</div><div><br></div><div>I've already uploaded a fix for the former. I'd like to discuss the behavior of Filter Glossy.<br></div><div><br></div><div>When doing the CPU profiling that you requested, I realised that Filter Glossy is executed after the closure setup (before closure setup = roughness, after = logistic parameters), which means it isn't affecting the roughness properly.</div><div><a href="https://developer.blender.org/rB52a0e67fe0050683a888d6643ec2035bd2b3ea1c" target="_blank">rB52a0e67fe005</a> is the commit that includes both mitigations, however, the new implementation is noticeably less effective. I've obtained decent results when applying <span style="font-family:monospace,monospace">fmaxf(3*roughness<font face="arial,helvetica,sans-serif"> to both Roughness and Radial Roughness; you'll find a visual comparison of the fixes below. (The original picture is up at <a href="https://framapic.org/ksZ7ftOaGvqk/gS2Cv0cjrdUg.jpg" target="_blank">https://framapic.org/ksZ7ftOaGvqk/gS2Cv0cjrdUg.jpg</a>.)</font><br></span></div><div><br></div><div><div><img src="https://framapic.org/ksZ7ftOaGvqk/gS2Cv0cjrdUg.jpg" style="margin-right:0px" width="525" height="175"><br></div><br></div><div>I'm not sure if there is any need to strengthen Filter Glossy wrt. Radial Roughness in this way; please let me know what you think.<br></div><div><br></div><div>Best regards,</div><div>Leonardo<br></div><br><div class="gmail_quote"><div dir="ltr">El lun., 23 de jul. de 2018 a la(s) 08:16, Brecht Van Lommel (<a href="mailto:brechtvanlommel@gmail.com" target="_blank">brechtvanlommel@gmail.com</a>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi,<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> - The regression test suite has not been uploaded yet to SVN.<br></blockquote><div><br></div><div>I've committed these as well now.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> - It's been asked in the BA thread if I have extra objectives for the<br> shaders. Do you feel that more features/controls should be added?<br></blockquote><div><br></div><div>More features could be good, but also part of the GSoC plan was to investigate optimizations for the shader, since it still is relatively slow / noisy.</div><div><br></div><div>So I think you should at least profile the shader, and look into fireflies to see where they come from and if they are expected or not. I don't know if there is anything major to find, but it's worth investigating.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> - I came up with controls for each of the modes (R, TT, TRT, TRRT+).<br> - It's been also suggested to prune the UI into a "Basic" and<br> "Advanced" mode.<br></blockquote><div><br></div><div>I'd be hesitant to add features to break physical correctness and energy conservation so early, before people have really tested the shader. I rather users test it and then give us feedback saying they can't achieve this or that look, and then we see what the best solution is.<br></div><div><br></div><div>Maybe commit it to your branch and then we can always add it later if there is a need for it.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">About the GSoC project deliverables:<br><br> - If I read the mail correctly, Google wants us students to summarize<br> and show off our work in a single place e.g. a blog post. How does Blender<br> handle this?<br> - My preference would be to add a page (similar to when one publishes<br> a paper) in <a href="http://amyspark.me" target="_blank">amyspark.me</a> explaining the work we did. We could embed<br> the resulting pictures, credits, etc. and the demonstration video from<br> Youtube.<br> - As for "Get the code", perhaps I could add links to the relevant<br> commits?<br></blockquote><div><br></div><div>A webpage is fine, for the code you can link to the git branch.</div><div><br></div><div>Thanks,<br></div><div>Brecht.</div><div><br></div><div> </div></div>
-- <br>
Soc-2018-dev mailing list<br>
<a href="mailto:Soc-2018-dev@blender.org" target="_blank">Soc-2018-dev@blender.org</a><br>
<a href="https://lists.blender.org/mailman/listinfo/soc-2018-dev" rel="noreferrer" target="_blank">https://lists.blender.org/mailman/listinfo/soc-2018-dev</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_8508644456541739915m_5683236972958504923gmail_signature" data-smartmail="gmail_signature">Lic. Leonardo E. Segovia<br>Departamento de Ciencias e Ingeniería de la Computación<br>Universidad Nacional del Sur<br>San Andrés 800 - Campus Palihue, B8000 Bahía Blanca, Argentina</div></div>
-- <br>
Soc-2018-dev mailing list<br>
<a href="mailto:Soc-2018-dev@blender.org" target="_blank">Soc-2018-dev@blender.org</a><br>
<a href="https://lists.blender.org/mailman/listinfo/soc-2018-dev" rel="noreferrer" target="_blank">https://lists.blender.org/mailman/listinfo/soc-2018-dev</a><br>
</blockquote></div>