<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Rohan,</p>
<p>Agree polishing and bugfixing should be top priority now. <br>
</p>
<p>Did quick review of code (nothing in-depth yet), overall looks
very good. Noted the following points that you are still using
BMO_OPTYPE_FLAG_INVALIDATE_CLNOR_ALL in addition to
BMO_OPTYPE_FLAG_NORMALS_CALC, already said it, but imho this is
needlessly verbose - I can’t imagine any case where you'd want to
invalidate basic normals, while keeping clnors one valid? So imho,
BMO_OPTYPE_FLAG_NORMALS_CALC should be redefined to also contain
BMO_OPTYPE_FLAG_INVALIDATE_CLNOR_ALL, such that using the former
automatically also triggers the later, without having to change
any code for that.</p>
<p>Cheers,<br>
Bastien<br>
</p>
<div class="moz-cite-prefix">Le 04/08/2017 à 20:12, Rohan Rathi a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:CAE7L-22dv+raLjS-PLZpN263dj8RVdQsSLXL=zRe0+8pjvrCEA@mail.gmail.com">
<div dir="ltr">
<div><b>Would really appreciate feedback on the tools added and
the weighted normal modifier. Latest Windows release is
included.</b></div>
<div><br>
</div>
What I did this week:
<div>I've added some functionality to the weighted normals
modifier. It had some serious bugs and glitches so I've spent
the majority of my time to refine and work on the features
I've added. Most likely, the modifier will work completely
fine now.</div>
<div><br>
</div>
<div>Added the following:</div>
<div>1) Modifier now respects sharp edges similar to sharp edges
with smooth shading.</div>
<div>2) Added vertex group support. Modifier will only affect
vertex groups and leave all other loop data unchanged.</div>
<div>3) Add smooth/sharp flags as boolean weights. A check as
well whether to use this function.</div>
<div><br>
</div>
<div>What I plan on doing next week:</div>
<div>With just over 2 weeks left for the project. I feel adding
more tools is not a good option, not that I have anything
important left to add. I'll go on to maintaining and
documenting the code from next week onwards and prepare for
final eval. There are some bugs and tasks that need attention
so I'll put on focus on those.</div>
<div><br>
</div>
<div>Latest Windows Release: <a
href="https://drive.google.com/file/d/0B9gCAchc4CLIV0lISFU5ZWptNXM/view?usp=sharing"
moz-do-not-send="true">https://drive.google.com/file/d/0B9gCAchc4CLIV0lISFU5ZWptNXM/view?usp=sharing</a></div>
<div><br>
</div>
<div>
<div style="font-size:12.8px">Links:</div>
<div style="font-size:12.8px">
<div style="font-size:12.8px">My proposal: <a
href="https://wiki.blender.org/index.php/User:RohanRathi/GSoC_2017/Proposal"
target="_blank" moz-do-not-send="true">https://wiki.blender<wbr>.org/index.php/User:RohanRathi<wbr>/GSoC_2017/Proposal</a></div>
<div style="font-size:12.8px">Documentation: <a
href="https://docs.google.com/document/d/1YXOLuiYjUgaoxawtXqcRkET-G2M3MbASVop88lKaKbg/edit"
target="_blank" moz-do-not-send="true">https://docs.<wbr>google.com/document/d/<wbr>1YXOLuiYjUgaoxawtXqcRkET-<wbr>G2M3MbASVop88lKaKbg/edit</a></div>
<div style="font-size:12.8px">Git branch: <a
href="https://developer.blender.org/diffusion/B/browse/soc-2017-normal-tools/"
target="_blank" moz-do-not-send="true">https://developer.blen<wbr>der.org/diffusion/B/browse/soc<wbr>-2017-normal-tools/</a></div>
</div>
<div style="font-size:12.8px">Blender Artists Thread: <a
href="https://blenderartists.org/forum/showthread.php?427746-GSoC-2017-Normal-Editing-Tools"
target="_blank" moz-do-not-send="true">https://blenderartists<wbr>.org/forum/showthread.php?4277<wbr>46-GSoC-2017-Normal-Editing-To<wbr>ols</a></div>
<div style="font-size:12.8px"><br>
</div>
<div style="font-size:12.8px">
<div style="font-size:12.8px">Thank You,</div>
<div style="font-size:12.8px">Rohan Rathi</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Soc-2017-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Soc-2017-dev@blender.org">Soc-2017-dev@blender.org</a>
<a class="moz-txt-link-freetext" href="https://lists.blender.org/mailman/listinfo/soc-2017-dev">https://lists.blender.org/mailman/listinfo/soc-2017-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>