<div dir="ltr"><div>Hi,</div><div>The name is a bit odd, but was the first thing that came to mind. I'll rename it.</div><div>As for a small demo, I can create one, but I'm not quite sure what it's supposed to be like.</div><div><br></div><div>Thanks for your advice,</div><div>Rohan</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 1:15 PM, Bastien Montagne <span dir="ltr"><<a href="mailto:montagne29@wanadoo.fr" target="_blank">montagne29@wanadoo.fr</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<p>Hi Rohan,</p>
<p>Did first check of the branch, had to move bmspacearr to be a
pointer in BMesh struct, we really do not want to include headers
into other headers if at all possible to avoid (as a bonus, fixes
building of bmesh gtests, and allows for fully lazy initialization
of those). I think you should rename them to 'lnor_spacearr' btw,
we already know they are in BMesh struct, and 'spacearray' is a
bit too generic of a name. :)</p>
<p>Also, please remember to merge master often in your branch
(several times a week at least). Otherwise, you can end up with
critical issues when branches diverge too much.</p>
<p>Did quick check of the 'rotate normals' (R-N) tool, seems to be
working nicely! Think you could prepare a first small demo video
already? <br>
</p>
<p>Keep up the good work,<br>
Bastien<br>
</p><div><div class="h5">
<div class="m_-1578557968837757426moz-cite-prefix">Le 09/06/2017 à 19:27, Rohan Rathi a
écrit :<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">What I did this week:
<div><br>
</div>
<div>Added generic structures and functions that will be used to
initialize the loop normals data required for editing tools.
Other than that I've added normal rotation. I'm also close to
finishing my second feature, point normals to target.</div>
<div><br>
</div>
<div>Normal Rotation:</div>
<div>Works by pressing R, then N. requires autosmooth to be
active. Can be constrained to either of three axes, can work
by accepting num inputs or accepting inputs from UI. In short,
works exactly as standard rotation. Though of course, the
rotation center is local to each vertex.</div>
<div><br>
</div>
<div>When I tested it, it did crash once, so definitely needs
some bug testing.<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>What I plan on doing next week:</div>
<div>Finish point normals to target. Its a modal op, may require
workflow changes. Then begin work on Aligning normals. This is
a big part, but if possible I'd like to look back as well and
think about how to make lnor invalidation more cohesive with
BMOps and practical.</div>
<div><br>
</div>
<div><br>
</div>
<div>Links:</div>
<div>
<div style="font-size:12.8px">My proposal: <a href="https://wiki.blender.org/index.php/User:RohanRathi/GSoC_2017/Proposal" target="_blank">https://wiki.blender<wbr>.org/index.php/User:RohanRathi<wbr>/GSoC_2017/Proposal</a></div>
<div style="font-size:12.8px">Git branch: <a href="https://developer.blender.org/diffusion/B/browse/soc-2017-normal-tools/" target="_blank">https://developer.blen<wbr>der.org/diffusion/B/browse/<wbr>soc-2017-normal-tools/</a></div>
</div>
<div>Blender Artists Thread: <a href="https://blenderartists.org/forum/showthread.php?427746-GSoC-2017-Normal-Editing-Tools" target="_blank">https://<wbr>blenderartists.org/forum/<wbr>showthread.php?427746-GSoC-<wbr>2017-Normal-Editing-Tools</a></div>
<div><br>
</div>
<div>Thank You, </div>
<div><br>
</div>
<div>Rohan Rathi</div>
<div><br>
</div>
</div>
<br>
<fieldset class="m_-1578557968837757426mimeAttachmentHeader"></fieldset>
<br>
</div></div><pre>______________________________<wbr>_________________
Soc-2017-dev mailing list
<a class="m_-1578557968837757426moz-txt-link-abbreviated" href="mailto:Soc-2017-dev@blender.org" target="_blank">Soc-2017-dev@blender.org</a>
<a class="m_-1578557968837757426moz-txt-link-freetext" href="https://lists.blender.org/mailman/listinfo/soc-2017-dev" target="_blank">https://lists.blender.org/<wbr>mailman/listinfo/soc-2017-dev</a>
</pre>
</blockquote>
<br>
</div>
<br>______________________________<wbr>_________________<br>
Soc-2017-dev mailing list<br>
<a href="mailto:Soc-2017-dev@blender.org">Soc-2017-dev@blender.org</a><br>
<a href="https://lists.blender.org/mailman/listinfo/soc-2017-dev" rel="noreferrer" target="_blank">https://lists.blender.org/<wbr>mailman/listinfo/soc-2017-dev</a><br>
<br></blockquote></div><br></div>