<div dir="ltr">Hi,<div><br></div><div>Here's some thing about correspondences. Why you are not following approach where it is on Blender side to align track numbers so correspondence tracks from other clips simply has same number? That's</div><div><br></div><div>(a) Simpler from API point of view (so basically you reduce number of modifications)</div><div>(b) Simpler from use in Libmv itself (so you work with all tracks in similar way)</div><div>(c) This is actually what i've suggested in private mail which was not replied.</div><div><br></div><div>If you do some decisions i want them to be at least communicated. If it doesn't align with suggestions form my side i want to have reasoning. Not saying all the suggestions are always correct, but if hey are not this to be communicated.</div><div><br></div><div>As for code style. Libmv uses Google's code style [1]. It is to be followed in Lbmv. However, C-API of Libmv follows Blender's code style.</div><div><br></div><div>[1] <a href="https://google.github.io/styleguide/cppguide.html">https://google.github.io/styleguide/cppguide.html</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 18, 2016 at 5:25 PM, Tianwei Shen <span dir="ltr"><<a href="mailto:shentianweipku@gmail.com" target="_blank">shentianweipku@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi everyone,<br>
<br>
Here is my week 4 report. I didn’t get much done as my eyes did not feel well this week. I should be catching up with the schedule next week.<br>
<br>
What I did this week:<br>
* Filling the gap in mv::Reconstruction class of libmv/autotrack, namely AddIntrinsics method, AddCamera method, etc.<br>
* make correspondence data structure in libmv side, and pass this information from blender to libmv<br>
* add bundle.cpp/bundle.h in autotrack, begin migrating bundle from simple_pipeline to autotrack.<br>
<br>
Next week plan:<br>
* finish migrating bundle code<br>
* do the mid-term evaluation<br>
<br>
<br>
Question:<br>
1. libmv has a different and non-standard comment and indentation style. For example, blender uses tab (and set as =4 spaces) while libmv using 2-spaces. Should I stick with the libmv indentation style or feel free to comment and indent using blender style?<br>
_______________________________________________<br>
Soc-2016-dev mailing list<br>
<a href="mailto:Soc-2016-dev@blender.org">Soc-2016-dev@blender.org</a><br>
<a href="https://lists.blender.org/mailman/listinfo/soc-2016-dev" rel="noreferrer" target="_blank">https://lists.blender.org/mailman/listinfo/soc-2016-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div><span style="color:rgb(102,102,102)">With best regards, Sergey Sharybin</span></div></div>
</div>