<p dir="ltr">This is probably where I'm confused. I'm not totally sure what I need to do to officially start a review. I had Campbell review some code I just committed a couple of weeks ago, so I thought that would be enough.</p>
<p dir="ltr">Do I need to make a separate patch and then point you guys at it? If so I'll do that asap. </p>
<p dir="ltr"> The X11 code has gotten to a point that it works, at least for me, but I'm not sure if there are situations where it might fail.</p>
<div class="gmail_quote">On Jul 11, 2014 4:42 PM, "Sergey Sharybin" <<a href="mailto:sergey.vfx@gmail.com">sergey.vfx@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Even so GLX might take some time still, i don't see any reason why not to send current patch (which as i understand works on OSX?) to the code review system? Sooner all involved developers starts giving a feedback on the changes sooner you'll be able to commit stuff to master branch. Doubt reviewing such a larger changes would be reviewed sooner than week or so.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 9, 2014 at 10:52 PM, Antony Riakiotakis <span dir="ltr"><<a href="mailto:kalast@gmail.com" target="_blank">kalast@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Great, I will make sure to check it out on my linux box too when ready.<br></div><div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On 9 July 2014 17:12, Jason Wilkins <span dir="ltr"><<a href="mailto:jason.a.wilkins@gmail.com" target="_blank">jason.a.wilkins@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It took a bit more time than I expected but I have a GLX implementation now. I actually got it to work on OSX, so no need for me to setup a Linux box. (It didn't take much work to use x11 on osx actually)<div>
<br></div>
<div>I'll be committing it later today after cleaning it up.<br><br>This is a heads up for Antony since he indicated he wanted to look at the GLX context class. It actually works on OSX but there may be a surprise on Linux so that would be a good idea.<span></span></div>
<div><div>
<div><br>On Sunday, July 6, 2014, Jason Wilkins <<a href="mailto:jason.a.wilkins@gmail.com" target="_blank">jason.a.wilkins@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Beside GLX support I just need to get feedback.<span></span><br><br>On Sunday, July 6, 2014, Antony Riakiotakis <<a>kalast@gmail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div>Hi,<br><br></div>It's not entirely clear to us what the state of the project is. We had agreed before GSOC to have GHOST initialization reviewed and merged as soon as possible, so that we could at least have the basis on which to port the new vertex streaming code.<br>
<br>As far as I know this is not achieved yet.<br><br></div><div>I would really rather one target is finished, reviewed and merged first, then move on to other targets.<br></div><div>Not doing concentrated work will surely result again in unfinished work and the code in an uncertain state.<br>
</div><div>Let's avoid that this time.<br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 5 July 2014 16:36, Jason Wilkins <span dir="ltr"><<a>jason.a.wilkins@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I set a few modest goals last week and I was a little disappointed that that is about all I was able to do. Then I realized I lost a couple of days due to having to go home early one day (a pipe burst) and of course, the July 4th holiday.<div>
<br></div><div>This week:</div><div><br></div><div>* Extension Shims - This is just a way of reducing the amount of conditional compilation and branches that can happen due to the different possible OpenGL APIs that may be available.</div>
<div><br></div><div>* State Policy - Reducing the number of OpenGL API calls by choosing a "policy" for each state that results in the fewest calls. For example I eliminated a few dozen calls to glBlendFunc by just assuming that the state is GL_ALPHA/GL_ONE_MINUS_SRC_ALPHA.</div>
<div><br></div><div>At this point I regretted that I ignored the Game Engine last year because I'm not completely sure that all my state policies can hold across all of Blender, BlenderPlayer, and the embedded Game Engine without more testing.</div>
<div><br></div><div>Next Week:</div><div><br></div><div>One reason I was conservative about goals last week was that I wanted to think about my next move, since it wasn't completely clear to be at the time, but I think I figured it out.</div>
<div><br></div><div>There is a module called "gpu_immediate" that is meant as a replacement for immediate mode. Not a great name since it is more like a vertex buffer builder and is capable of saving vertex buffers for reuse. My goal for this week is to get that module into a reviewable state.</div>
<div><br></div><div>There is some overlap between it and gpu_buffers and some of the cases where Blender uses vertex arrays instead of immediate mode that should be combined to remove the redundancy. Also I've been meaning to use vertex array objects for over a year now and I want to get to that.</div>
<div><br></div></div>
<br>_______________________________________________<br>
Soc-2014-dev mailing list<br>
<a>Soc-2014-dev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/soc-2014-dev" target="_blank">http://lists.blender.org/mailman/listinfo/soc-2014-dev</a><br>
<br></blockquote></div><br></div>
</blockquote>
</blockquote></div>
</div></div><br>_______________________________________________<br>
Soc-2014-dev mailing list<br>
<a href="mailto:Soc-2014-dev@blender.org" target="_blank">Soc-2014-dev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/soc-2014-dev" target="_blank">http://lists.blender.org/mailman/listinfo/soc-2014-dev</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
Soc-2014-dev mailing list<br>
<a href="mailto:Soc-2014-dev@blender.org" target="_blank">Soc-2014-dev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/soc-2014-dev" target="_blank">http://lists.blender.org/mailman/listinfo/soc-2014-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><span style="color:rgb(102,102,102)">With best regards, Sergey Sharybin</span></div>
</div>
<br>_______________________________________________<br>
Soc-2014-dev mailing list<br>
<a href="mailto:Soc-2014-dev@blender.org">Soc-2014-dev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/soc-2014-dev" target="_blank">http://lists.blender.org/mailman/listinfo/soc-2014-dev</a><br>
<br></blockquote></div>