Hi,<br><br>I was going to rectify the situation with actions today by going back to having only bAction. <br><br>Regarding the freeing, I'm currently working on more fixes for that.<br><br>Regards.<br>Joshua<br><br><div class="gmail_quote">
On Sun, Jan 18, 2009 at 3:02 AM, Ton Roosendaal <span dir="ltr"><<a href="mailto:ton@blender.org">ton@blender.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
Warning; Joshuas commit will make reading files with Actions go<br>
horrible wrong.<br>
Do not attempt even, nor save such files. Should be fixed tomorrow.<br>
<br>
Joshua: if you want nAction to reside next to bAction, for conversions,<br>
you have to give nAction an own unique ID (DNA_ID.h), and add it to the<br>
Main (BKE_main.h), and make sure library lists recognize it<br>
(library.c:set_listbasepointers), and it can be found<br>
(library.c:which_libbase), allocated (library.c:alloc_libblock_notest)<br>
and freed (library.c: free_libblock).<br>
<br>
Also readfile.c should get this, and so on...<br>
<br>
I also noticed in your new code that freeing memory is not 100%<br>
failsafe... you should tag functions clearly whether or not they're<br>
supposed to free the data itself, and if not, always leave the pointers<br>
after free NULL. Do not free lists without a BLI_remlink()!<br>
<br>
-Ton-<br>
<br>
------------------------------------------------------------------------<br>
Ton Roosendaal Blender Foundation <a href="mailto:ton@blender.org">ton@blender.org</a> <a href="http://www.blender.org" target="_blank">www.blender.org</a><br>
Blender Institute BV Entrepotdok 57A 1018AD Amsterdam The Netherlands<br>
<br>
_______________________________________________<br>
Bf-taskforce25 mailing list<br>
<a href="mailto:Bf-taskforce25@blender.org">Bf-taskforce25@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-taskforce25" target="_blank">http://lists.blender.org/mailman/listinfo/bf-taskforce25</a><br>
</blockquote></div><br>