Hi Ton,<br><br>I was going to ask about this issue of where to place stuff that gets used in multiple places (like quite a few parts of animation stuff). IMO, we should have one of those modules like for "transform" (as shown in the source layout docs) for things that are called for multiple areas (most notably, quite a few of the animation things, such as markers, current-frame indicator drawing). Another example would be editing tools for specific types of data (i.e. curves/nurbs): do these fit under the space_view3d, do they get their own "module", or are they just lumped into a giant category "object editing stuff"?<br>
<br>Additionally, currently I've got a system which provides a uniform access to animation data in the Action Editor, which means that the amount of context-checking stuff per tool is greatly reduced. How this currently works, is that each tool (also the drawing code) firstly requests the context info from the Action Editor (in 2.5, I guess this step will probably not be needed in most cases as operators would get provided with a context to work with), and then uses this context + a few data-filters it defines to retrieve a list of channels which are suitable for its requirements. Currently, I have plans to introduce such abstraction to the IPO Editor which also needs such a system to deal cope with the requirement of multiple-ipoblocks. Now, it would be preferable to have a single system for animation stuff which defines such data, as there's a considerable amount of overlap, with the only differences being how the editors interpret the data.<br>
<br>Regards,<br>Joshua<br><br><br><div class="gmail_quote">On Tue, Nov 25, 2008 at 7:59 AM, Ton Roosendaal <span dir="ltr"><<a href="mailto:ton@blender.org">ton@blender.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Revision: 17560<br>
<a href="http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=17560" target="_blank">http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=17560</a><br>
Author: ton<br>
Date: 2008-11-24 19:59:59 +0100 (Mon, 24 Nov 2008)<br>
<br>
Log Message:<br>
-----------<br>
More testing with new system:<br>
<br>
- Added markers (partially) back, ed_markers.c (temporary in spacetime,<br>
where to put general stuff like this?), and added ED_markers.h for api.<br>
<br>
- Mkey in timewindow shows marker (no icon, doesnt work yet).<br>
(Adding operators gets easy :)<br>
<br>
- Noted some conflict for operator storage... with markers being used all<br>
over, added it to the screen level.<br>
<br>
- More todos: view2d is stored in space, for time, etc. With regions we<br>
could move this over, but better todo as post 2.5 project. Multiple 2d<br>
views in area would be cool though.<br>
<br>
Modified Paths:<br>
--------------<br>
branches/blender2.5/blender/source/blender/editors/include/UI_view2d.h<br>
branches/blender2.5/blender/source/blender/editors/interface/view2d.c<br>
branches/blender2.5/blender/source/blender/editors/screen/screen_ops.c<br>
branches/blender2.5/blender/source/blender/editors/space_time/space_time.c<br>
branches/blender2.5/blender/source/blender/editors/space_time/time_ops.c<br>
branches/blender2.5/blender/source/blender/windowmanager/intern/wm_operators.c<br>
<br>
Added Paths:<br>
-----------<br>
branches/blender2.5/blender/source/blender/editors/include/ED_markers.h<br>
branches/blender2.5/blender/source/blender/editors/include/ED_types.h<br>
branches/blender2.5/blender/source/blender/editors/space_time/ed_markers.c<br>
<br>
Added: branches/blender2.5/blender/source/blender/editors/include/ED_markers.h<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/editors/include/ED_markers.h (rev 0)<br>
+++ branches/blender2.5/blender/source/blender/editors/include/ED_markers.h 2008-11-24 18:59:59 UTC (rev 17560)<br>
@@ -0,0 +1,49 @@<br>
+/**<br>
+ * $Id:<br>
+ *<br>
+ * ***** BEGIN GPL LICENSE BLOCK *****<br>
+ *<br>
+ * This program is free software; you can redistribute it and/or<br>
+ * modify it under the terms of the GNU General Public License<br>
+ * as published by the Free Software Foundation; either version 2<br>
+ * of the License, or (at your option) any later version.<br>
+ *<br>
+ * This program is distributed in the hope that it will be useful,<br>
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>
+ * GNU General Public License for more details.<br>
+ *<br>
+ * You should have received a copy of the GNU General Public License<br>
+ * along with this program; if not, write to the Free Software Foundation,<br>
+ * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.<br>
+ *<br>
+ * The Original Code is Copyright (C) 2008 Blender Foundation.<br>
+ * All rights reserved.<br>
+ *<br>
+ *<br>
+ * Contributor(s): Blender Foundation<br>
+ *<br>
+ * ***** END GPL LICENSE BLOCK *****<br>
+ */<br>
+#ifndef ED_MARKERS_H<br>
+#define ED_MARKERS_H<br>
+<br>
+/* flags for drawing markers */<br>
+enum {<br>
+ DRAW_MARKERS_LINES = (1<<0),<br>
+ DRAW_MARKERS_LOCAL = (1<<1)<br>
+};<br>
+<br>
+<br>
+<br>
+struct wmOperatorType;<br>
+<br>
+<br>
+void draw_markers_time(const bContext *C, int flag);<br>
+<br>
+/* operators */<br>
+void ED_MARKER_OT_add(struct wmOperatorType *ot);<br>
+<br>
+<br>
+#endif /* ED_MARKERS_H */<br>
+<br>
<br>
Added: branches/blender2.5/blender/source/blender/editors/include/ED_types.h<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/editors/include/ED_types.h (rev 0)<br>
+++ branches/blender2.5/blender/source/blender/editors/include/ED_types.h 2008-11-24 18:59:59 UTC (rev 17560)<br>
@@ -0,0 +1,39 @@<br>
+/**<br>
+ * $Id:<br>
+ *<br>
+ * ***** BEGIN GPL LICENSE BLOCK *****<br>
+ *<br>
+ * This program is free software; you can redistribute it and/or<br>
+ * modify it under the terms of the GNU General Public License<br>
+ * as published by the Free Software Foundation; either version 2<br>
+ * of the License, or (at your option) any later version.<br>
+ *<br>
+ * This program is distributed in the hope that it will be useful,<br>
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>
+ * GNU General Public License for more details.<br>
+ *<br>
+ * You should have received a copy of the GNU General Public License<br>
+ * along with this program; if not, write to the Free Software Foundation,<br>
+ * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.<br>
+ *<br>
+ * The Original Code is Copyright (C) 2008 Blender Foundation.<br>
+ * All rights reserved.<br>
+ *<br>
+ *<br>
+ * Contributor(s): Blender Foundation<br>
+ *<br>
+ * ***** END GPL LICENSE BLOCK *****<br>
+ */<br>
+#ifndef ED_TYPES_H<br>
+#define ED_TYPES_H<br>
+<br>
+/* **************** GENERAL EDITOR-WIDE TYPES AND DEFINES ************************** */<br>
+<br>
+/* old blender defines... should be depricated? */<br>
+#define SELECT 1<br>
+#define ACTIVE 2<br>
+<br>
+<br>
+#endif /* ED_TYPES_H */<br>
+<br>
<br>
Modified: branches/blender2.5/blender/source/blender/editors/include/UI_view2d.h<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/editors/include/UI_view2d.h 2008-11-24 17:48:40 UTC (rev 17559)<br>
+++ branches/blender2.5/blender/source/blender/editors/include/UI_view2d.h 2008-11-24 18:59:59 UTC (rev 17560)<br>
@@ -65,5 +65,9 @@<br>
void UI_view2d_view_to_region(struct View2D *v2d, float x, float y, short *regionx, short *regiony);<br>
void UI_view2d_to_region_no_clip(struct View2D *v2d, float x, float y, short *regionx, short *region_y);<br>
<br>
+/* utilities */<br>
+void UI_view2d_getscale(View2D *v2d, float *x, float *y);<br>
+<br>
+<br>
#endif /* UI_VIEW2D_H */<br>
<br>
<br>
Modified: branches/blender2.5/blender/source/blender/editors/interface/view2d.c<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/editors/interface/view2d.c 2008-11-24 17:48:40 UTC (rev 17559)<br>
+++ branches/blender2.5/blender/source/blender/editors/interface/view2d.c 2008-11-24 18:59:59 UTC (rev 17560)<br>
@@ -323,4 +323,9 @@<br>
}<br>
}<br>
<br>
+void UI_view2d_getscale(View2D *v2d, float *x, float *y)<br>
+{<br>
+ if (x) *x = (v2d->mask.xmax-v2d->mask.xmin)/(v2d->cur.xmax-v2d->cur.xmin);<br>
+ if (y) *y = (v2d->mask.ymax-v2d->mask.ymin)/(v2d->cur.ymax-v2d->cur.ymin);<br>
+}<br>
<br>
<br>
Modified: branches/blender2.5/blender/source/blender/editors/screen/screen_ops.c<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/editors/screen/screen_ops.c 2008-11-24 17:48:40 UTC (rev 17559)<br>
+++ branches/blender2.5/blender/source/blender/editors/screen/screen_ops.c 2008-11-24 18:59:59 UTC (rev 17560)<br>
@@ -39,6 +39,7 @@<br>
#include "WM_types.h"<br>
<br>
#include "ED_area.h"<br>
+#include "ED_markers.h"<br>
#include "ED_screen.h"<br>
#include "ED_screen_types.h"<br>
<br>
@@ -1275,12 +1276,16 @@<br>
WM_operatortype_append(ED_SCR_OT_cursor_type);<br>
WM_operatortype_append(ED_SCR_OT_actionzone);<br>
<br>
- /* tools */<br>
+ /* screen tools */<br>
WM_operatortype_append(ED_SCR_OT_area_move);<br>
WM_operatortype_append(ED_SCR_OT_area_split);<br>
WM_operatortype_append(ED_SCR_OT_area_join);<br>
WM_operatortype_append(ED_SCR_OT_area_rip);<br>
<br>
+ /* tools shared by more space types */<br>
+ WM_operatortype_append(ED_MARKER_OT_add);<br>
+<br>
+<br>
/* for test only */<br>
WM_operatortype_append(ED_SCR_OT_border_select);<br>
}<br>
@@ -1298,9 +1303,6 @@<br>
<br>
/* for test only */<br>
WM_keymap_verify_item(&wm->screenkeymap, "ED_SCR_OT_border_select", BKEY, KM_PRESS, 0, 0);<br>
- WM_keymap_verify_item(&wm->screenkeymap, "WM_OT_tweak_gesture", LEFTMOUSE, KM_PRESS, 0, 0); /* generates event */<br>
<br>
- WM_keymap_add_item(&wm->screenkeymap, "ED_SCR_OT_area_split", EVT_TWEAK, EVT_GESTURE_S, 0, 0);<br>
-<br>
}<br>
<br>
<br>
Added: branches/blender2.5/blender/source/blender/editors/space_time/ed_markers.c<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/editors/space_time/ed_markers.c (rev 0)<br>
+++ branches/blender2.5/blender/source/blender/editors/space_time/ed_markers.c 2008-11-24 18:59:59 UTC (rev 17560)<br>
@@ -0,0 +1,242 @@<br>
+/**<br>
+ * $Id:<br>
+ *<br>
+ * ***** BEGIN GPL LICENSE BLOCK *****<br>
+ *<br>
+ * This program is free software; you can redistribute it and/or<br>
+ * modify it under the terms of the GNU General Public License<br>
+ * as published by the Free Software Foundation; either version 2<br>
+ * of the License, or (at your option) any later version.<br>
+ *<br>
+ * This program is distributed in the hope that it will be useful,<br>
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>
+ * GNU General Public License for more details.<br>
+ *<br>
+ * You should have received a copy of the GNU General Public License<br>
+ * along with this program; if not, write to the Free Software Foundation,<br>
+ * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.<br>
+ *<br>
+ * The Original Code is Copyright (C) 2008 Blender Foundation.<br>
+ * All rights reserved.<br>
+ *<br>
+ *<br>
+ * Contributor(s): Blender Foundation<br>
+ *<br>
+ * ***** END GPL LICENSE BLOCK *****<br>
+ */<br>
+<br>
+#include <stdlib.h><br>
+<br>
+#include "MEM_guardedalloc.h"<br>
+<br>
+#include "DNA_scene_types.h"<br>
+#include "DNA_screen_types.h"<br>
+#include "DNA_space_types.h"<br>
+#include "DNA_view2d_types.h"<br>
+#include "DNA_windowmanager_types.h"<br>
+<br>
+#include "RNA_access.h"<br>
+#include "RNA_define.h"<br>
+<br>
+#include "BLI_blenlib.h"<br>
+<br>
+#include "BKE_global.h"<br>
+<br>
+#include "WM_api.h"<br>
+#include "WM_types.h"<br>
+<br>
+#include "BIF_gl.h"<br>
+#include "BIF_glutil.h"<br>
+<br>
+#include "UI_interface.h"<br>
+#include "UI_view2d.h"<br>
+#include "UI_resources.h"<br>
+<br>
+#include "ED_markers.h"<br>
+#include "ED_types.h"<br>
+<br>
+/* ************* Marker Drawing ************ */<br>
+<br>
+/* XXX */<br>
+extern void ui_rasterpos_safe(float x, float y, float aspect);<br>
+<br>
+/* function to draw markers */<br>
+static void draw_marker(View2D *v2d, TimeMarker *marker, int cfra, int flag)<br>
+{<br>
+ float xpos, ypixels, xscale, yscale;<br>
+ int icon_id= 0;<br>
+<br>
+ xpos = marker->frame;<br>
+ /* no time correction for framelen! space is drawn with old values */<br>
+<br>
+ ypixels= v2d->mask.ymax-v2d->mask.ymin;<br>
+ UI_view2d_getscale(v2d, &xscale, &yscale);<br>
+<br>
+ glScalef( 1.0/xscale, 1.0/yscale, 1.0);<br>
+<br>
+ glEnable(GL_BLEND);<br>
+ glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);<br>
+<br>
+ /* verticle line */<br>
+ if (flag & DRAW_MARKERS_LINES) {<br>
+ setlinestyle(3);<br>
+ if(marker->flag & SELECT)<br>
+ glColor4ub(255,255,255, 96);<br>
+ else<br>
+ glColor4ub(0,0,0, 96);<br>
+<br>
+ glBegin(GL_LINES);<br>
+ glVertex2f((xpos*xscale)+0.5, 12);<br>
+ glVertex2f((xpos*xscale)+0.5, 34*yscale); /* a bit lazy but we know it cant be greater then 34 strips high*/<br>
+ glEnd();<br>
+ setlinestyle(0);<br>
+ }<br>
+<br>
+ /* 5 px to offset icon to align properly, space / pixels corrects for zoom */<br>
+ if (flag & DRAW_MARKERS_LOCAL) {<br>
+ icon_id= (marker->flag & ACTIVE) ? ICON_PMARKER_ACT :<br>
+ (marker->flag & SELECT) ? ICON_PMARKER_SEL :<br>
+ ICON_PMARKER;<br>
+ }<br>
+ else {<br>
+ icon_id= (marker->flag & SELECT) ? ICON_MARKER_HLT :<br>
+ ICON_MARKER;<br>
+ }<br>
+<br>
+ //BIF_icon_draw(xpos*xscale-5.0, 12.0, icon_id);<br>
+ glColor3ub(0, 100, 0);<br>
+ glRectf(xpos*xscale-5.0f, 12.0f, xpos*xscale, 17.0f);<br>
+<br>
+ glBlendFunc(GL_ONE, GL_ZERO);<br>
+ glDisable(GL_BLEND);<br>
+<br>
+ /* and the marker name too, shifted slightly to the top-right */<br>
+ if(marker->name && marker->name[0]) {<br>
+ if(marker->flag & SELECT) {<br>
+ //BIF_ThemeColor(TH_TEXT_HI);<br>
+ ui_rasterpos_safe(xpos*xscale+4.0, (ypixels<=39.0)?(ypixels-10.0):29.0, 1.0);<br>
+ }<br>
+ else {<br>
+ // BIF_ThemeColor(TH_TEXT);<br>
+ if((marker->frame <= cfra) && (marker->frame+5 > cfra))<br>
+ ui_rasterpos_safe(xpos*xscale+4.0, (ypixels<=39.0)?(ypixels-10.0):29.0, 1.0);<br>
+ else<br>
+ ui_rasterpos_safe(xpos*xscale+4.0, 17.0, 1.0);<br>
+ }<br>
+// BIF_DrawString(G.font, marker->name, 0);<br>
+ }<br>
+ glScalef(xscale, yscale, 1.0);<br>
+}<br>
+<br>
+/* Draw Scene-Markers in time window (XXX make generic) */<br>
+void draw_markers_time(const bContext *C, int flag)<br>
+{<br>
+ TimeMarker *marker;<br>
+ SpaceTime *stime= C->area->spacedata.first;<br>
+ View2D *v2d= &stime->v2d;<br>
+<br>
+ /* unselected markers are drawn at the first time */<br>
+ for (marker= C->scene->markers.first; marker; marker= marker->next) {<br>
+ if (!(marker->flag & SELECT)) draw_marker(v2d, marker, C->scene->r.cfra, flag);<br>
+ }<br>
+<br>
<br>
@@ Diff output truncated at 10240 characters. @@<br>
<br>
_______________________________________________<br>
Bf-blender-cvs mailing list<br>
<a href="mailto:Bf-blender-cvs@blender.org">Bf-blender-cvs@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-blender-cvs" target="_blank">http://lists.blender.org/mailman/listinfo/bf-blender-cvs</a><br>
</blockquote></div><br>