<div dir="ltr">Howard,<div><br></div><div>I haven't been able to test the above change yet, need to get my compiling fixed for the new XCode, but if a new algorithm could account for those cases that otherwise would fail, then I think this is the way to go.</div>
<div><br></div><div>Even though I would love to simply have it working right now, for a better user experience it'd be nice to cover more corner cases.</div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr">
Jonathan Williamson<div><a href="http://cgcookie.com" target="_blank">http://cgcookie.com</a></div></div></div>
<br><br><div class="gmail_quote">On Fri, Sep 13, 2013 at 6:16 AM, Howard Trickey <span dir="ltr"><<a href="mailto:howard.trickey@gmail.com" target="_blank">howard.trickey@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Walid's patch, to my amazement, does in fact make the case of beveling vertices that are outside corners of faces work as desired. I'm amazed because the algorithm for vertex beveling was designed only to handle the case of beveling an interior vertex.<div>
<br></div><div>We could commit this change, but it would expose other cases where beveling a valence-2 vertex doesn't work because the algorithm wasn't designed to:</div><div>1) segments > 1</div><div>2) the valence-2 vertex is in the interior of a face.</div>
<div><br></div><div>I or someone could write a different algorithm for handling external-face corners with segments > 1, and do something for the interior case. Question is, should we wait until that is done or commit the above change now?</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div>- Howard</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 12, 2013 at 9:35 PM, walid shouman <span dir="ltr"><<a href="mailto:eng.walidshouman@gmail.com" target="_blank">eng.walidshouman@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">believe that would make it fixed ... but i wouldn't risk applying the<br>
patch till Campbell approves it<br>
<br>
for the time being its working well in my version<br>
<br>
Index: source/blender/bmesh/tools/bmesh_bevel.c<br>
===================================================================<br>
--- source/blender/bmesh/tools/bmesh_bevel.c (revision 59907)<br>
+++ source/blender/bmesh/tools/bmesh_bevel.c (working copy)<br>
@@ -1962,7 +1962,7 @@<br>
if (!first_bme)<br>
first_bme = v->e;<br>
<br>
- if ((nsel == 0 && !bp->vertex_only) || (ntot < 3 && bp->vertex_only)) {<br>
+ if ((nsel == 0 && !bp->vertex_only) || (ntot < 2 && bp->vertex_only)) {<br>
/* signal this vert isn't being beveled */<br>
BM_elem_flag_disable(v, BM_ELEM_TAG);<br>
return;<br>
<div><div><br>
On Fri, Sep 13, 2013 at 1:02 AM, Jonathan Williamson<br>
<<a href="mailto:jonathan@cgcookie.com" target="_blank">jonathan@cgcookie.com</a>> wrote:<br>
> Hey Campbell,<br>
><br>
> Currently vertex bevel does not support beveling on vertices with only two<br>
> edges. Vertices much have three or more edges connected to it to bevel.<br>
><br>
> Is it possible to remove this limitation? In cases like this, where I want<br>
> to bevel the tips it'd be very useful: <a href="http://cl.ly/RMNA" target="_blank">http://cl.ly/RMNA</a><br>
><br>
> Using the above, beveling would allow me to make this quickly:<br>
> <a href="http://cl.ly/RNAM" target="_blank">http://cl.ly/RNAM</a><br>
><br>
> Jonathan Williamson<br>
> <a href="http://cgcookie.com" target="_blank">http://cgcookie.com</a><br>
><br>
</div></div>> _______________________________________________<br>
> Bf-modeling mailing list<br>
> <a href="mailto:Bf-modeling@blender.org" target="_blank">Bf-modeling@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-modeling" target="_blank">http://lists.blender.org/mailman/listinfo/bf-modeling</a><br>
><br>
<br>
<br>
<br>
--<br>
<br>
Sincerely,<br>
Walid E. Shouman<br>
Third year, CSE department, ASU.<br>
ACES'12 Media Vice-Head.<br>
Al-Manara kids instructor.<br>
CORD EGY'11 Vice-Director.<br>
Al-Shams Scouting Team Rover Scout.<br>
_______________________________________________<br>
Bf-modeling mailing list<br>
<a href="mailto:Bf-modeling@blender.org" target="_blank">Bf-modeling@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-modeling" target="_blank">http://lists.blender.org/mailman/listinfo/bf-modeling</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
Bf-modeling mailing list<br>
<a href="mailto:Bf-modeling@blender.org">Bf-modeling@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-modeling" target="_blank">http://lists.blender.org/mailman/listinfo/bf-modeling</a><br>
<br></blockquote></div><br></div>