<div dir="ltr"><div><div><div>I took a quick look over your patch (sorry for the delay), and I like your idea of an alternative data structure for managing filters. I also appreciate that you actually payed attention to the existing encapsulation and made a GLSL concrete implementation of the abstract filter type. The diff was a little noisy with a lot of white space changes, and it would be best if you kept the refactor separate from the offscreen render changes (which I am guessing are not complete yet).<br><br></div>Using a data class to reduce the number of arguments is fine, and is already done in the BGE in the physics code. In general, I find improving readability to rarely be bad practice.<br><br></div>Do you ever go onto any of the Blender IRC channels? I use the nick Kupoman in #bgecoders and #blendercoders. I would love to have a more in depth conversation about your plans for the 2D filter system as I have a few thoughts on that part of the BGE myself.<br><br></div>Regards,<br>Daniel Stokes<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 9:41 AM, Jacob Merrill <span dir="ltr"><<a href="mailto:blueprintrandom1@gmail.com" target="_blank">blueprintrandom1@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><a href="http://blenderartists.org/forum/showthread.php?358021-ogrender-blogre-something&p=2789237&viewfull=1#post2789237" target="_blank">http://blenderartists.org/forum/showthread.php?358021-ogrender-blogre-something&p=2789237&viewfull=1#post2789237</a><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 9:40 AM, Jacob Merrill <span dir="ltr"><<a href="mailto:blueprintrandom1@gmail.com" target="_blank">blueprintrandom1@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It looks like off screen rendering, and some cleanup from what I have read at BA.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 3, 2015 at 9:33 AM, Daniel Stokes <span dir="ltr"><<a href="mailto:kupomail@gmail.com" target="_blank">kupomail@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">I will take a look at your diff later (on a phone right now). Could you elaborate a bit on what your goals with the rewrite were?</p>
<p dir="ltr">Regards,<br>
Daniel Stokes</p>
<div class="gmail_quote"><div><div>On Jan 3, 2015 6:24 AM, "pgi" <<a href="mailto:pierluigi@tukano.it" target="_blank">pierluigi@tukano.it</a>> wrote:<br type="attribution"></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>Hello, happy new year and things.<br>
<br>
I rewrote the bge 2D filter system, there are a couple of minor things that I have to change (like naming conventions, formatting and so) and a few test I need to run before to have a real patch but I'd like someone to check how things are shaping because I made some design choices that might not be compatible with how blender is supposed to be.<br>
The new system is backward compatible. Well, it will be, I have to guess another two or three things before to be 100% sure about it.<br>
<br>
The attached diff contains the changes to the rasterizer package. There are maybe a couple of other minor changes in other parts of the code but they are not relevant.<br>
<br>
pgi<br>
<br></div></div>_______________________________________________<br>
Bf-gamedev mailing list<br>
<a href="mailto:Bf-gamedev@blender.org" target="_blank">Bf-gamedev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-gamedev" target="_blank">http://lists.blender.org/mailman/listinfo/bf-gamedev</a><br>
<br></blockquote></div>
<br>_______________________________________________<br>
Bf-gamedev mailing list<br>
<a href="mailto:Bf-gamedev@blender.org" target="_blank">Bf-gamedev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-gamedev" target="_blank">http://lists.blender.org/mailman/listinfo/bf-gamedev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
Bf-gamedev mailing list<br>
<a href="mailto:Bf-gamedev@blender.org">Bf-gamedev@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-gamedev" target="_blank">http://lists.blender.org/mailman/listinfo/bf-gamedev</a><br>
<br></blockquote></div><br></div>