[Bf-extensions-cvs] SVN commit: /data/svn/bf-extensions [4449] trunk/py/scripts/addons/ object_print3d_utils: resolve issues reported by dolf.

[Campbell Barton]

Revision: 4449
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-extensions&revision=4449
Author:   campbellbarton
Date:     2013-04-04 18:25:22 +0000 (Thu, 04 Apr 2013)
Log Message:
-----------
resolve issues reported by dolf.
(but not all)

1. Don't zoom out when selecting output. Often you want to recheck an area you're working on... and you have to zoom back in again and again.

3. The distorted check is a great tool.. I have the default value at 45 degrees... I think you had it at 15? That's a bit low.

4. The upper limit for thickness check needs to be much higher. If you're working in mm 1 is too low (coloured prints have a lower limit of 2mm)... so make the limit for the check 10 or so.

5. Sharp edge check seems to work for both negative and positive values. There is very much a difference between those when printing... You're usually looking for pointy stuff.

Modified Paths:
--------------
    trunk/py/scripts/addons/object_print3d_utils/__init__.py
    trunk/py/scripts/addons/object_print3d_utils/operators.py

Modified: trunk/py/scripts/addons/object_print3d_utils/__init__.py
===================================================================
--- trunk/py/scripts/addons/object_print3d_utils/__init__.py	2013-04-04 17:23:09 UTC (rev 4448)
+++ trunk/py/scripts/addons/object_print3d_utils/__init__.py	2013-04-04 18:25:22 UTC (rev 4449)
@@ -76,7 +76,7 @@
             description="Minimum thickness",
             subtype='DISTANCE',
             default=0.001,  # 1mm
-            min=0.0, max=1.0,
+            min=0.0, max=10.0,
             )
     threshold_zero = FloatProperty(
             name="Threshold",
@@ -89,7 +89,7 @@
             name="Angle",
             description="Limit for checking distorted faces",
             subtype='ANGLE',
-            default=math.radians(15.0),
+            default=math.radians(45.0),
             min=0.0, max=math.radians(180.0),
             )
     angle_sharp = FloatProperty(

Modified: trunk/py/scripts/addons/object_print3d_utils/operators.py
===================================================================
--- trunk/py/scripts/addons/object_print3d_utils/operators.py	2013-04-04 17:23:09 UTC (rev 4448)
+++ trunk/py/scripts/addons/object_print3d_utils/operators.py	2013-04-04 18:25:22 UTC (rev 4449)
@@ -256,7 +256,7 @@
         bm.normal_update()
 
         edges_sharp = [ele.index for ele in bm.edges
-                       if ele.is_manifold and ele.calc_face_angle() > angle_sharp]
+                       if ele.is_manifold and ele.calc_face_angle_signed() > angle_sharp]
 
         info.append(("Sharp Edge: %d" % len(edges_sharp),
                     (bmesh.types.BMEdge, edges_sharp)))
@@ -482,8 +482,8 @@
             # possible arrays are out of sync
             self.report({'WARNING'}, "Report is out of date, re-run check")
 
-        # Perhaps this is annoying? but also handy!
-        bpy.ops.view3d.view_selected(use_all_regions=False)
+        # cool, but in fact annoying
+        #~ bpy.ops.view3d.view_selected(use_all_regions=False)
 
         return {'FINISHED'}