<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Sorry does that mean I should?<br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 26/01/2015 10:53 PM, Greg Zaal
      wrote:<br>
    </div>
    <blockquote
cite="mid:CAN5-zsOQ-VAt2Jy06htJ8ZG-+Vhar8X30Dngc=Ukq50RQg9oiw@mail.gmail.com"
      type="cite">
      <div dir="ltr">Great - maybe just add a comment and attach it
        there.<br>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On 26 January 2015 at 14:22, Alban <span
            dir="ltr">&lt;<a moz-do-not-send="true"
              href="mailto:shopaaholiq@gmail.com" target="_blank">shopaaholiq@gmail.com</a>&gt;</span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div text="#000000" bgcolor="#FFFFFF"> No I didn't, thanks!<br>
              <br>
              Should I resubmit the diff?<span class="HOEnZb"><font
                  color="#888888"><br>
                  <br>
                  Alban.</font></span>
              <div>
                <div class="h5"><br>
                  <br>
                  <br>
                  <div>On 26/01/2015 10:44 PM, Gaia wrote:<br>
                  </div>
                  <blockquote type="cite">
                    <div>Did you try to add the new files to svn with:<br>
                      <br>
                      &nbsp;&nbsp; svn add&nbsp; path_to_new_file<br>
                      <br>
                      then svn diff should also find them.<br>
                      <br>
                      cheers,<br>
                      Gaia<br>
                      <br>
                      <br>
                      On 26.01.2015 13:10, Alban wrote:<br>
                    </div>
                    <blockquote type="cite"> Hi Greg,<br>
                      <br>
                      What I've done is remove most of the text from
                      manual/composite_nodes/types/filter.rst and placed
                      it into new files according to node which I've
                      then attached to the diff. Perhaps there is a
                      better way of doing this I don't know about,
                      otherwise any modifications in those files from
                      the original does not show up in the diff viewer.
                      It might make more sense when you look at it.<br>
                      <br>
                      I used 'svn diff manual/composite_nodes/types/
                      &gt; file.diff'. When I try 'svn diff &gt;&gt;
                      file.diff' It doesn't seem to include the new
                      files though it does include changes I've made to
                      other files.<br>
                      <br>
                      Thanks,<br>
                      <br>
                      Alban.<br>
                      <br>
                      <br>
                      <div>On 26/01/2015 10:18 PM, Greg Zaal wrote:<br>
                      </div>
                      <blockquote type="cite">
                        <div dir="ltr">
                          <div>
                            <div>Thanks Alban!<br>
                              <br>
                            </div>
                            I'll take a look at it when I get home
                            tonight.<br>
                            <br>
                          </div>
                          I know images can't be handled with diffs, but
                          I though adding/removing/renaming files works
                          fine? Are you using `svn diff &gt;&gt;
                          file.diff` or some other command?<br>
                        </div>
                        <div class="gmail_extra"><br>
                          <div class="gmail_quote">On 26 January 2015 at
                            13:33, Alban <span dir="ltr">&lt;<a
                                moz-do-not-send="true"
                                href="mailto:shopaaholiq@gmail.com"
                                target="_blank">shopaaholiq@gmail.com</a>&gt;</span>
                            wrote:<br>
                            <blockquote class="gmail_quote">Hi,<br>
                              <br>
                              I've created D1024 as an initial response
                              to T42947. Do I get some<br>
                              feedback on this at some point?<br>
                              <br>
                              It seems to me that taking on this task
                              requires editing a significant<br>
                              number of files in such a way that is not
                              very compatible with the diff<br>
                              revision system. Since I am splitting out
                              most of the content into<br>
                              attachments there is no easy way for a
                              reviewer to see what has changed.<br>
                              <br>
                              Do I keep working on this now or wait
                              until someone makes a decision<br>
                              which would affect this? If I can get this
                              reviewed now it will be a lot<br>
                              easier for me to make the changes I want
                              to make next.<br>
                              <br>
                              Regards,<br>
                              <br>
                              Alban O'Brien.<br>
_______________________________________________<br>
                              Bf-docboard mailing list<br>
                              <a moz-do-not-send="true"
                                href="mailto:Bf-docboard@blender.org"
                                target="_blank">Bf-docboard@blender.org</a><br>
                              <a moz-do-not-send="true"
                                href="http://lists.blender.org/mailman/listinfo/bf-docboard"
                                target="_blank">http://lists.blender.org/mailman/listinfo/bf-docboard</a><br>
                            </blockquote>
                          </div>
                          <br>
                        </div>
                        <br>
                        <fieldset></fieldset>
                        <br>
                        <pre>_______________________________________________
Bf-docboard mailing list
<a moz-do-not-send="true" href="mailto:Bf-docboard@blender.org" target="_blank">Bf-docboard@blender.org</a>
<a moz-do-not-send="true" href="http://lists.blender.org/mailman/listinfo/bf-docboard" target="_blank">http://lists.blender.org/mailman/listinfo/bf-docboard</a>
</pre>
                      </blockquote>
                      <br>
                      <br>
                      <fieldset></fieldset>
                      <br>
                      <pre>_______________________________________________
Bf-docboard mailing list
<a moz-do-not-send="true" href="mailto:Bf-docboard@blender.org" target="_blank">Bf-docboard@blender.org</a>
<a moz-do-not-send="true" href="http://lists.blender.org/mailman/listinfo/bf-docboard" target="_blank">http://lists.blender.org/mailman/listinfo/bf-docboard</a>
</pre>
                    </blockquote>
                    <br>
                    <br>
                    <fieldset></fieldset>
                    <br>
                    <pre>_______________________________________________
Bf-docboard mailing list
<a moz-do-not-send="true" href="mailto:Bf-docboard@blender.org" target="_blank">Bf-docboard@blender.org</a>
<a moz-do-not-send="true" href="http://lists.blender.org/mailman/listinfo/bf-docboard" target="_blank">http://lists.blender.org/mailman/listinfo/bf-docboard</a>
</pre>
                  </blockquote>
                  <br>
                </div>
              </div>
            </div>
            <br>
            _______________________________________________<br>
            Bf-docboard mailing list<br>
            <a moz-do-not-send="true"
              href="mailto:Bf-docboard@blender.org">Bf-docboard@blender.org</a><br>
            <a moz-do-not-send="true"
              href="http://lists.blender.org/mailman/listinfo/bf-docboard"
              target="_blank">http://lists.blender.org/mailman/listinfo/bf-docboard</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Bf-docboard mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Bf-docboard@blender.org">Bf-docboard@blender.org</a>
<a class="moz-txt-link-freetext" href="http://lists.blender.org/mailman/listinfo/bf-docboard">http://lists.blender.org/mailman/listinfo/bf-docboard</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>