<div dir="ltr">Discussed with Philip on IRC:<div><br></div><div>* I don't really see the need for type strings in the labels, but if it's really wanted i think it should be added secondary to the current label, i.e. "Add (Math)" or so instead of "Math - Add". The left side with the more detailed and useful info is then always visible even if strings get cut off.</div>
<div><br></div><div>* Changing node size automatically as in the patch should be avoided imo - width is defined by the user in the first place. It could be an operator "Fit optimal node size" or so. At least it should be an optional setting, maybe next to the snapping buttons in the header (snapping will also get some improvements to make it work on the grid)</div>
<div><br></div><div>* The way labels are returned in the code atm does not allow dynamic strings (returns const char*). The suggested patch would create a memory leak. I want to extend the node API for labels anway to allow using dynamic labels in python nodes, i'll make sure to make this more flexible then.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Nov 3, 2013 at 2:05 PM, Philipp Oeser <span dir="ltr"><<a href="mailto:info@graphics-engineer.com" target="_blank">info@graphics-engineer.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry, previous pic was a bit misleading (changed the operation _only_<br>
on the collapsed nodes). This one is more consistent:<br>
<br>
<a href="http://www.pasteall.org/pic/show.php?id=61839" target="_blank">http://www.pasteall.org/pic/show.php?id=61839</a><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Sun, 2013-11-03 at 13:46 +0100, Philipp Oeser wrote:<br>
> Not sure about the two liner, but what we can do is draw the (collapsed)<br>
> node a bit wider when the nodelabel gets longer? (patch below has<br>
> functionality that does this when you collapse a node)<br>
><br>
> <a href="http://www.pasteall.org/pic/61837" target="_blank">http://www.pasteall.org/pic/61837</a><br>
> (patch here <a href="http://www.pasteall.org/46982" target="_blank">http://www.pasteall.org/46982</a>)<br>
><br>
> Greetz<br>
> Philipp<br>
><br>
> P.S.: this doesnt seem to be specifically Cycles related btw. Its more<br>
> general NodeEditor stuff. Maybe lukas_t can comment?<br>
><br>
><br>
> On Sun, 2013-11-03 at 09:55 +0100, Constantin Rahn wrote:<br>
> > I like this solution.<br>
> ><br>
> > Would it be possible to make it a two liner, with a break in case of<br>
> > collapsed nodes?<br>
> ><br>
> > Happy blending<br>
> > Conz<br>
> ><br>
> > Am 03.11.2013 00:35, schrieb Philipp Oeser:<br>
> > > Hm, gave it a quick go, not sure if this is a step forward.<br>
> > > The default collapsed node seems too small to show _both_ nodetype and<br>
> > > operation (even though when the collapsed node is resized in width it<br>
> > > works quite well...) Anyways, if in doubt, I would prefer operation as<br>
> > > well.<br>
> > ><br>
> > > Have a look here: <a href="http://www.pasteall.org/pic/61802" target="_blank">http://www.pasteall.org/pic/61802</a><br>
> > > (patch here if someone wants to experiment more with this<br>
> > > <a href="http://www.pasteall.org/46976" target="_blank">http://www.pasteall.org/46976</a>)<br>
> > ><br>
> > > Greetz<br>
> > > Philipp<br>
> > ><br>
> > ><br>
> > > On Sat, 2013-11-02 at 21:00 +0100, Gottfried Hofmann wrote:<br>
> > >> On 11/02/2013 07:42 PM, Greg Zaal wrote:<br>
> > >>> Could we just make the automatic label something like "Mix - Multiply"?<br>
> > >> That is a very good idea indeed!<br>
> > >><br>
> > >> Gottfried<br>
> > >><br>
> > >><br>
> > >>> I'm actually not particularly bothered by this, people who get confused<br>
> > >>> by it are only confused once, and then know it. In this case I'd say<br>
> > >>> favour the experienced users and leave it as-is, or compromise and make<br>
> > >>> everyone happy with the cost of a longer label.<br>
> > >>><br>
> > >>><br>
> > >>> On 2 November 2013 19:18, Piotr Adamowicz <<a href="mailto:padamowicz@gmail.com">padamowicz@gmail.com</a><br>
> > >>> <mailto:<a href="mailto:padamowicz@gmail.com">padamowicz@gmail.com</a>>> wrote:<br>
> > >>><br>
> > >>> If the problem is making it easy for beginners to find the nodes, then<br>
> > >>> perhaps the solution would be to move the math node into its own<br>
> > >>> section and add a menu item for each of its modes while keeping the<br>
> > >>> math node itself as is? That way the beginners would find it easily<br>
> > >>> and the regular users would still keep their useful labels.<br>
> > >>><br>
> > >>> On Sat, Nov 2, 2013 at 6:13 PM, ishly habib <<a href="mailto:ishrox123@gmail.com">ishrox123@gmail.com</a><br>
> > >>> <mailto:<a href="mailto:ishrox123@gmail.com">ishrox123@gmail.com</a>>> wrote:<br>
> > >>> > I think that it would be enough if the search would understand<br>
> > >>> add as a<br>
> > >>> > version of the mix node and pop-up because the typical thing for<br>
> > >>> a beginner<br>
> > >>> > to do when I can't find the node is to search it. The solution of<br>
> > >>> headers is<br>
> > >>> > clunky in my opinion. if that matters<br>
> > >>> ><br>
> > >>> > On 01/11/2013 10:38 pm, "Brecht Van Lommel"<br>
> > >>> <<a href="mailto:brechtvanlommel@pandora.be">brechtvanlommel@pandora.be</a> <mailto:<a href="mailto:brechtvanlommel@pandora.be">brechtvanlommel@pandora.be</a>>><br>
> > >>> > wrote:<br>
> > >>> >><br>
> > >>> >> I'm not sure I agree, if you build a setup with math or color mix<br>
> > >>> >> nodes it's quite tedious to have to rename them manually I would<br>
> > >>> >> think? Although perhaps this is a non-issue for typical users,<br>
> > >>> just in<br>
> > >>> >> my experience I quite like this renaming.<br>
> > >>> >><br>
> > >>> >> Perhaps we should have tooltips when you are over a node (header),<br>
> > >>> >> with the node name and description of the node, that would solve the<br>
> > >>> >> issue in a different way.<br>
> > >>> >><br>
> > >>> >> Brecht.<br>
> > >>> >><br>
> > >>> >> On Fri, Nov 1, 2013 at 6:07 AM, Greg Zaal <<a href="mailto:gregzzmail@gmail.com">gregzzmail@gmail.com</a><br>
> > >>> <mailto:<a href="mailto:gregzzmail@gmail.com">gregzzmail@gmail.com</a>>> wrote:<br>
> > >>> >> > Hey David,<br>
> > >>> >> ><br>
> > >>> >> > I agree, it's especially difficult for beginners to look at<br>
> > >>> someone's<br>
> > >>> >> > node<br>
> > >>> >> > setup and wonder where this weird "Modulo" node (for example)<br>
> > >>> comes from<br>
> > >>> >> > that they can't find in the menus. The title of the node should be<br>
> > >>> >> > displayed<br>
> > >>> >> > exactly how it is in the Add menu, and only change when the user<br>
> > >>> >> > explicitly<br>
> > >>> >> > changes it's label in the properties region.<br>
> > >>> >> ><br>
> > >>> >> > It's not cycles specifically, but also the compositing (and I<br>
> > >>> assume<br>
> > >>> >> > texture) nodes as well that have this issue.<br>
> > >>> >> ><br>
> > >>> >> > Cheers,<br>
> > >>> >> > Greg<br>
> > >>> >> ><br>
> > >>> >> > On Nov 1, 2013 6:08 AM, "David Black" <<a href="mailto:db4tech@yahoo.co.uk">db4tech@yahoo.co.uk</a><br>
> > >>> <mailto:<a href="mailto:db4tech@yahoo.co.uk">db4tech@yahoo.co.uk</a>>> wrote:<br>
> > >>> >> >><br>
> > >>> >> >> Apologies, I do have dyslexia, subject should read...<br>
> > >>> seemingly not<br>
> > >>> >> >> seemly.<br>
> > >>> >> >><br>
> > >>> >> >> The following line should read...<br>
> > >>> >> >> (While nodes are collapsed) it becomes possible for math and<br>
> > >>> vector<br>
> > >>> >> >> math<br>
> > >>> >> >> nodes to have a seemingly identical name and appearance.<br>
> > >>> >> >><br>
> > >>> >> >> I notice the two nodes in question have different socket<br>
> > >>> inputs which<br>
> > >>> >> >> helps differentiate to some extent, still like how other<br>
> > >>> nodes provide<br>
> > >>> >> >> header names rather than function, this in itself is of course<br>
> > >>> >> >> subjective.<br>
> > >>> >> >><br>
> > >>> >> >> David<br>
> > >>> >> >> --<br>
> > >>> >> >><br>
> > >>> >> >> <a href="http://3d-designs-davidblack.blogspot.com" target="_blank">3d-designs-davidblack.blogspot.com</a><br>
> > >>> <<a href="http://3d-designs-davidblack.blogspot.com" target="_blank">http://3d-designs-davidblack.blogspot.com</a>><br>
> > >>> >> >><br>
> > >>> >> >> On 01/11/2013 03:38, David Black wrote:<br>
> > >>> >> >><br>
> > >>> >> >> Hi Brecht and other mailing list members.<br>
> > >>> >> >><br>
> > >>> >> >> While we are discussing nodes, what are peoples thoughts on<br>
> > >>> >> >> Converters\Math node displaying 'Math' and Converters\Vector Math<br>
> > >>> >> >> displaying<br>
> > >>> >> >> 'Vector Math' for their node names?<br>
> > >>> >> >><br>
> > >>> >> >> They are the only two nodes which change name depending on their<br>
> > >>> >> >> function,<br>
> > >>> >> >> while I can see this is useful, it can also cause identification<br>
> > >>> >> >> difficulties. (While nodes are collapsed) it becomes possible<br>
> > >>> for math<br>
> > >>> >> >> and<br>
> > >>> >> >> vector math nodes to have an identical name and appearance.<br>
> > >>> >> >><br>
> > >>> >> >> With all other nodes displaying header names rather than<br>
> > >>> function,<br>
> > >>> >> >> would<br>
> > >>> >> >> adding header names to these two nodes help with<br>
> > >>> identification and<br>
> > >>> >> >> maintain<br>
> > >>> >> >> consistency?<br>
> > >>> >> >><br>
> > >>> >> >> Thank you for your time,<br>
> > >>> >> >> David<br>
> > >>> >> >> --<br>
> > >>> >> >><br>
> > >>> >> >> <a href="http://3d-designs-davidblack.blogspot.com" target="_blank">3d-designs-davidblack.blogspot.com</a><br>
> > >>> <<a href="http://3d-designs-davidblack.blogspot.com" target="_blank">http://3d-designs-davidblack.blogspot.com</a>><br>
> > >>> >> >><br>
> > >>> >> >><br>
> > >>> >> >><br>
> > >>> >> >> _______________________________________________<br>
> > >>> >> >> Bf-cycles mailing list<br>
> > >>> >> >> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a> <mailto:<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a>><br>
> > >>> >> >> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>> >> >><br>
> > >>> >> >><br>
> > >>> >> >><br>
> > >>> >> >> _______________________________________________<br>
> > >>> >> >> Bf-cycles mailing list<br>
> > >>> >> >> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a> <mailto:<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a>><br>
> > >>> >> >> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>> >> >><br>
> > >>> >> ><br>
> > >>> >> > _______________________________________________<br>
> > >>> >> > Bf-cycles mailing list<br>
> > >>> >> > <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a> <mailto:<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a>><br>
> > >>> >> > <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>> >> ><br>
> > >>> >> _______________________________________________<br>
> > >>> >> Bf-cycles mailing list<br>
> > >>> >> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a> <mailto:<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a>><br>
> > >>> >> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>> ><br>
> > >>> ><br>
> > >>> > _______________________________________________<br>
> > >>> > Bf-cycles mailing list<br>
> > >>> > <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a> <mailto:<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a>><br>
> > >>> > <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>> ><br>
> > >>><br>
> > >>><br>
> > >>><br>
> > >>> --<br>
> > >>> Piotr "MadMinstrel" Adamowicz<br>
> > >>> <a href="mailto:padamowicz@gmail.com">padamowicz@gmail.com</a> <mailto:<a href="mailto:padamowicz@gmail.com">padamowicz@gmail.com</a>><br>
> > >>> _______________________________________________<br>
> > >>> Bf-cycles mailing list<br>
> > >>> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a> <mailto:<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a>><br>
> > >>> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>><br>
> > >>><br>
> > >>><br>
> > >>><br>
> > >>> _______________________________________________<br>
> > >>> Bf-cycles mailing list<br>
> > >>> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
> > >>> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > >>><br>
> > >><br>
> > ><br>
> > > _______________________________________________<br>
> > > Bf-cycles mailing list<br>
> > > <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
> > > <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
> > ><br>
> ><br>
> > _______________________________________________<br>
> > Bf-cycles mailing list<br>
> > <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
> > <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
><br>
><br>
> _______________________________________________<br>
> Bf-cycles mailing list<br>
> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
<br>
<br>
_______________________________________________<br>
Bf-cycles mailing list<br>
<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
</div></div></blockquote></div><br></div>