Thank you Thomas, so keeping only the struct declaration in <span style>rna_nodetree_types.h, the RNA system will ensure save/load the node socket values right?</span><div><font color="#222222" face="arial, sans-serif"><br>
</font></div><div><font color="#222222" face="arial, sans-serif">Regards</font></div><div><font color="#222222" face="arial, sans-serif">Agus<br></font><br><div class="gmail_quote">2012/6/5 Thomas Dinges <span dir="ltr"><<a href="mailto:blender@dingto.org" target="_blank">blender@dingto.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Agus,<br>
thanks for the patch. One thing that is obsolete in your patch is the<br>
declaration of intensity, bump and NodeTexBase in DNA / RNA. Sockets<br>
don't need to be exposed there, this can be removed. In fact you don't<br>
have to add this Node to DNA at all. :) Only thing which is needed is<br>
the declaration of the node in rna_nodetree_types.h.<br>
I attached a new patch to the patch tracker which removes those things. :)<br>
<br>
Regards,<br>
Thomas<br>
<br>
Am 05.06.2012 09:01, schrieb Agustin Benavidez:<br>
<div class="im HOEnZb">> Hi Brecht, I think i just finish this patch (only per BSDF bump<br>
> mapping), I follow your recommendations so i think is ready for review.<br>
> how it looks like in the ui:<br>
> <a href="http://www.pasteall.org/pic/show.php?id=32728" target="_blank">http://www.pasteall.org/pic/show.php?id=32728</a><br>
><br>
> I uploaded it in the patch tracker:<br>
> <a href="http://projects.blender.org/tracker/index.php?func=detail&aid=31716&group_id=9&atid=127" target="_blank">http://projects.blender.org/tracker/index.php?func=detail&aid=31716&group_id=9&atid=127</a><br>
> <<a href="http://projects.blender.org/tracker/index.php?func=detail&aid=31716&group_id=9&atid=127" target="_blank">http://projects.blender.org/tracker/index.php?func=detail&aid=31716&group_id=9&atid=127</a>><br>
><br>
> What is not included is normal mapping, I postponed it for the next<br>
> weekend.<br>
><br>
> I also optimized several part of the added code, so i think the very<br>
> little performance lost in the GPU tests have been<br>
> reduced considerably. for CPU there is not any noticeable performance<br>
> impact from my tests.<br>
><br>
> Thank you Brecht<br>
> Agus,<br>
</div><span class="HOEnZb"><font color="#888888">--<br>
Thomas Dinges<br>
Blender Developer, Artist and Musician<br>
<br>
<a href="http://www.dingto.org" target="_blank">www.dingto.org</a><br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Bf-cycles mailing list<br>
<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
</div></div></blockquote></div><br></div>