How about having it as a shader option like the glass/glossy shaders have, where you can choose between CGX, Sharp, and Beckmann? This is similar to how BI handles choosing shaders.<br><br>Davis<br><br><div class="gmail_quote">
On Wed, Nov 9, 2011 at 5:27 PM, Yasuhiro Fujii <span dir="ltr"><<a href="mailto:y-fujii@mimosa-pudica.net">y-fujii@mimosa-pudica.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
pros:<br>
+ Simplify the UI.<br>
+ Simplify the code.<br>
<br>
cons:<br>
+ oren_nayar() and diffuse() have different convergence behavior even<br>
if roughness == 0.0, yield very different looks if convergence is not<br>
sufficient. In some scene, designers may want to choose oren_nayar()<br>
even if roughness == 0.0.<br>
+ Thus users must know roughness = 0.0 is specialized.<br>
<br>
I can't decide it because of my poor experience, especially designer's side.<br>
What do you think about their cons?<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Wed, Nov 9, 2011 at 11:37 PM, Brecht Van Lommel<br>
<<a href="mailto:brechtvanlommel@pandora.be">brechtvanlommel@pandora.be</a>> wrote:<br>
> Hi,<br>
><br>
> What do you think about implement this as a Roughness input for the<br>
> Diffuse BSDF node, instead of a separate one? Internally it can still<br>
> be a separate closure/BSDF, but it could just check if(roughness ==<br>
> 0.0) diffuse() else oren_nayar().<br>
><br>
> Brecht.<br>
><br>
> On Wed, Nov 9, 2011 at 6:55 AM, Yasuhiro Fujii<br>
> <<a href="mailto:y-fujii@mimosa-pudica.net">y-fujii@mimosa-pudica.net</a>> wrote:<br>
>> The O-N patch must be updated, however, the compile errors don't seem<br>
>> to be caused by this patch. I guess that they are due to tomato branch<br>
>> merged.<br>
>><br>
>> Blender's source (including cycles) will be changed a lot this week,<br>
>> due to a Branch Merger hurricane week:<br>
>> <a href="http://www.blendernation.com/2011/11/07/developer-meeting-notes-november-6-2011/" target="_blank">http://www.blendernation.com/2011/11/07/developer-meeting-notes-november-6-2011/</a><br>
>><br>
>> I will update the patch when cycles get to be able to compile again.<br>
>><br>
>><br>
> _______________________________________________<br>
> Bf-cycles mailing list<br>
> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
><br>
_______________________________________________<br>
Bf-cycles mailing list<br>
<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
</div></div></blockquote></div><br>