Your patch doesn't compile. I get error 2 at around 76%.<br><br><div class="gmail_quote">On Mon, Nov 7, 2011 at 12:18 PM, Yasuhiro Fujii <span dir="ltr"><<a href="mailto:y-fujii@mimosa-pudica.net">y-fujii@mimosa-pudica.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I've submitted the O-N patch.<br>
<br>
<a href="http://projects.blender.org/tracker/index.php?func=detail&aid=29193&group_id=9&atid=127" target="_blank">http://projects.blender.org/tracker/index.php?func=detail&aid=29193&group_id=9&atid=127</a><br>
<br>
Sorry to bother you when you are busy with merging cycles to trunk.<br>
<br>
-- y.fujii<br>
<br>
On Tue, Nov 8, 2011 at 12:04 AM, Brecht Van Lommel<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:brechtvanlommel@pandora.be">brechtvanlommel@pandora.be</a>> wrote:<br>
> No, that's not necessary, when we actually start supporting OSL, we<br>
> can ensure it's all in sync. For now it's ok if this is untested.<br>
><br>
> Brecht.<br>
><br>
> On Mon, Nov 7, 2011 at 3:43 PM, Yasuhiro Fujii<br>
> <<a href="mailto:y-fujii@mimosa-pudica.net">y-fujii@mimosa-pudica.net</a>> wrote:<br>
>> Thanks for reply.<br>
>> Should I wait to submit my Oren-Nayar patch until OSL support will come back?<br>
>> Its OSL code is not tested.<br>
>><br>
>> -- y.fujii<br>
>><br>
>> On Mon, Nov 7, 2011 at 9:04 PM, Brecht Van Lommel<br>
>> <<a href="mailto:brechtvanlommel@pandora.be">brechtvanlommel@pandora.be</a>> wrote:<br>
>>> It's indeed broken currently, trailing behind the latest changes a<br>
>>> bit. I'd suggest to just keep it disabled for building for now.<br>
>>><br>
>>> Brecht.<br>
>>><br>
>>> On Mon, Nov 7, 2011 at 6:28 AM, Yasuhiro Fujii<br>
>>> <<a href="mailto:y-fujii@mimosa-pudica.net">y-fujii@mimosa-pudica.net</a>> wrote:<br>
>>>> Building cycles with OSL is currently broken?<br>
>>>> The error is below:<br>
>>>><br>
>>>> intern/cycles/kernel/kernel.cpp: ccl::kernel_globals_create():<br>
>>>> "struct ccl::KernelGlobals" has no member named "osl"<br>
>>>><br>
>>>> -- y.fujii<br>
>>>> _______________________________________________<br>
>>>> Bf-cycles mailing list<br>
>>>> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
>>>> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
>>>><br>
>>> _______________________________________________<br>
>>> Bf-cycles mailing list<br>
>>> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
>>> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
>>><br>
>> _______________________________________________<br>
>> Bf-cycles mailing list<br>
>> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
>> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
>><br>
> _______________________________________________<br>
> Bf-cycles mailing list<br>
> <a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
><br>
_______________________________________________<br>
Bf-cycles mailing list<br>
<a href="mailto:Bf-cycles@blender.org">Bf-cycles@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-cycles" target="_blank">http://lists.blender.org/mailman/listinfo/bf-cycles</a><br>
</div></div></blockquote></div><br>