<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi all, <br>
<br>
first patch is being reviewed for the thumbnail previews.<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="http://developer.blender.org/D69">http://developer.blender.org/D69</a><br>
<br>
Would be great to get some user feedback!<br>
<br>
Jeroen & Monique<br>
<br>
On 11/19/2013 07:43 PM, Sean Kennedy wrote:<br>
</div>
<blockquote cite="mid:COL127-W235AD617895E82E49E8278A3E70@phx.gbl"
type="cite">
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style>
<div dir="ltr">I LOVE these ideas!
<div><br>
</div>
<div>Default colors for nodes is great. It would be most useful
to color code them by the categories listed in the add menu
(Input, Output, Color, etc...). For example, all Input node
types would be green, outputs could be red, color nodes could
be blue, etc.</div>
<div><br>
</div>
<div>birds eye view is useful, but it would also be handy to be
able to turn it off. Personally, I would only find it useful
for very large complex node trees. Otherwise I'd want it off.
Also, if performance and speed takes a hit while it updates,
it's not worth having, in my opinion.</div>
<div><br>
</div>
<div>Comment node! Yes please! :) Something collapsable, so it
can be small and only opened and read when the user requests.
But the collapsed version should still show the name of the
node, or the first word or two of the comment.</div>
<div><br>
</div>
<div>Great list of minor upgrades!</div>
<div><br>
<div>
<hr id="stopSpelling">Date: Tue, 19 Nov 2013 19:29:02 +0100<br>
From: <a class="moz-txt-link-abbreviated" href="mailto:j.bakker@atmind.nl">j.bakker@atmind.nl</a><br>
To: <a class="moz-txt-link-abbreviated" href="mailto:bf-compositor@blender.org">bf-compositor@blender.org</a><br>
Subject: Re: [Bf-compositor] [enh] How to deal with
thumbnail previews<br>
<br>
<div class="ecxmoz-cite-prefix">Hi All, <br>
<br>
Showing thumbnails for input nodes (image, texture, movie
renderlayer) is ok, they are almost free of cost.<br>
<br>
As one usage of thumbnails is for navigation support, we
should also take other options into account like:<br>
- default colors for nodes. (a cheaper way for visual
clues). The framenode and node colors are already
possible, but take time to setup. So why not add some
default color templates.<br>
- add a bird eye view<br>
- adding possibilities to write a note/comment (comment
node, or directly on the grid)<br>
<br>
There are some special cases like:<br>
- Levels node does not output a preview, in the old
compositor it showed a histogram, but currently it ain't
displaying anything.<br>
- Compositor output preview is quite a heavy preview.
During mango it was disconnected when working, and
sometimes forgot to connect back when sending to the
render farm.<br>
<br>
@Lukas: We will pick this up!<br>
<br>
Cheers, <br>
Jeroen & Monique<br>
<br>
<br>
<br>
<br>
On 11/19/2013 10:01 AM, Bartek Skorupa (priv) wrote:<br>
</div>
<blockquote
cite="mid:C4C6A620-C550-4FD0-9EAA-E912C23C5308@bartekskorupa.com">
In case of thumbnails I'd suggest a bit different
approach:
<div>Let's maybe treat possibility of having thumbnails as
an additional feature.</div>
<div>Instead of saying "Hide Previews", let's say "Show
Previews" and have it off by default.</div>
<div><br>
</div>
<div>I wouldn't go for having different behaviors
depending on node type. It's not that difficult to hit H
when you really want the thumbnail on.</div>
<div><br>
<div> <span class="ecxApple-style-span"
style="border-collapse:separate;border-spacing:0px;"><span
class="ecxApple-style-span"
style="border-collapse:separate;color:rgb(0, 0,
0);font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;font-size:medium;"><span
class="ecxApple-style-span"
style="border-collapse:separate;color:rgb(0, 0,
0);font-family:Helvetica;font-size:medium;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;">
<div style="word-wrap:break-word;">
<div>Bartek Skorupa</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://www.bartekskorupa.com"
target="_blank">www.bartekskorupa.com</a></div>
</div>
</span></span></span> </div>
<br>
<div>
<div>On 19 lis 2013, at 08:42, Lukas Tönne <<a
moz-do-not-send="true"
href="mailto:lukas.toenne@gmail.com">lukas.toenne@gmail.com</a>>
wrote:</div>
<br class="ecxApple-interchange-newline">
<blockquote>
<div dir="ltr">I promised to look into this, but i
don't mind if somebody else will pick it up :)
<div><br>
</div>
<div>Currently there is the "Hide Previews" button
in compositor nodes, but this is not working atm
due to the new node categories system and it's
also not really solid enough (it switches off
previews in the <span style="">node_add_node
function, but this is only called for a
handful of C operators now). I think this
should be removed.</span></div>
<div><span style=""><br>
</span></div>
<div><span style="">Then there is the question at
which point the preview flag should be un-set.
It could be done as part of the node
categories system, which supports
initialization of nodes with a settings
dictionary (in python). But there are a number
of nodes that can be added with non-python
operators which would lack this behavior then
(viewers, file output, default nodes in new
trees). Also since the feature is common to
all the compo nodes i would suggest deeper
integration.</span></div>
<div><span style=""><br>
</span></div>
<div><span style="">It can be done as a common
init function for compo nodes (initfunc in
bNodeType). It's a bit of monkey work to add
superclass calls, but not too difficult:</span></div>
<div><span style=""><br>
</span></div>
<div>
<div>static void
node_composit_init_common(bNodeTree
*UNUSED(ntree), bNode *node)</div>
<div>{</div>
<div><span style="white-space:pre;"> /* disable
all compositor node previews by default */</span><br>
</div>
<div><span style="white-space:pre;"> </span>node->flag
&= ~NODE_PREVIEW;<br>
</div>
<div><span style="">}</span><br>
</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Subclasses with init() should call the
superclass method (a bit awkward in C, will
become nicer if we move nodes to python):</div>
<div><br>
</div>
<div>
<div>static void
node_composit_init_boxmask(bNodeTree *ntree,
bNode *node)</div>
<div>{</div>
<div><span style="white-space:pre;"> </span>NodeBoxMask
*data = MEM_callocN(sizeof(NodeBoxMask),
"NodeBoxMask");</div>
<div><br>
</div>
<div><span style="white-space:pre;"> </span><span
style="">node_composit_init_common(ntree,
node);</span><br>
</div>
<div><br>
</div>
<div><span style="white-space:pre;"> </span>data->x
= 0.5;</div>
<div><span style="white-space:pre;"> </span>data->y
= 0.5;</div>
<div><span style="white-space:pre;"> </span>data->width
= 0.2;</div>
<div><span style="white-space:pre;"> </span>data->height
= 0.1;</div>
<div> <span style="white-space:pre;"> </span>data->rotation
= 0.0;</div>
<div><span style="white-space:pre;"> </span>node->storage
= data;</div>
<div> }</div>
<div style=""><br>
</div>
</div>
<div><span style=""><br>
</span></div>
<div>Input nodes can then set the flag explicitly:</div>
<div>
<div><br>
</div>
<div>static void
node_composit_init_image(bNodeTree *ntree,
bNode *node)</div>
<div>{</div>
<div><span style="white-space:pre;"> </span>ImageUser
*iuser = MEM_callocN(sizeof(ImageUser), "node
image user");</div>
<div><br>
</div>
<div><span style="white-space:pre;"> </span><span
style="">node_composit_init_common(ntree,
node);</span><br>
</div>
<div><span style="white-space:pre;"> /* enable
previews for input nodes */</span><span
style=""><br>
</span></div>
<div><span style="white-space:pre;"> </span><span
style="">node->flag |= NODE_PREVIEW;</span><span
style="white-space:pre;"><br>
</span></div>
<div><br>
</div>
<div><span style="white-space:pre;"> </span>node->storage
= iuser;</div>
<div><span style="white-space:pre;"> </span>iuser->frames
= 1;</div>
<div><span style="white-space:pre;"> </span>iuser->sfra
= 1;</div>
<div><span style="white-space:pre;"> </span>iuser->fie_ima
= 2;</div>
<div><span style="white-space:pre;"> </span>iuser->ok
= 1;</div>
<div><span style="white-space:pre;"> </span></div>
<div><span style="white-space:pre;"> </span>/*
setup initial outputs */</div>
<div><span style="white-space:pre;"> </span>cmp_node_image_verify_outputs(ntree,
node);</div>
<div>}</div>
</div>
<div><br>
</div>
</div>
<div class="ecxgmail_extra"><br>
<br>
<div class="ecxgmail_quote">On Tue, Nov 19, 2013
at 8:16 AM, Sebastian König <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:sebastiankoenig@posteo.de"
target="_blank">sebastiankoenig@posteo.de</a>></span>
wrote:<br>
<blockquote class="ecxgmail_quote"
style="border-left:1px #ccc
solid;padding-left:1ex;">
<div style="word-wrap:break-word;">
<div style="font-family:Helvetica,
Arial;font-size:13px;">
<div style="">Hey!</div>
<div style=""><br>
</div>
<div style="">Yes, I think it would be
fine to make thumbnails just be hidden
by default.</div>
<div style="">However, it’s also true they
do provide some very helpful feedback
when it comes to input nodes.</div>
<div style=""><br>
</div>
<div style="">Even though it would make
the default „hidden preview“ a bit
inconsistent, i do believe this would be
the most desirable behavior:</div>
<div style="">- Input nodes are always
created with their previews enabled.</div>
<div style="">- Every other node has the
preview disabled, except for the viewer
node. </div>
<div style="">- Since the composite output
makes the whole node-tree calculate all
the time when it has thumbnail expanded
I think it should also be collapsed by
default. (also in startup.blend)</div>
<div style=""><br>
</div>
<div style=""><br>
</div>
<div style="">So, speaking as a non
developer I think you only would have to
exclude the input nodes from the button
that controls the default behavior for
new nodes, though in reality I suppose
there’d have to be some if/else stuff.
:)</div>
<div style=""><br>
</div>
<div style=""><br>
</div>
<div style="">Sebastian</div>
<div style=""><br>
</div>
<div style=""><br>
</div>
<div style="font-family:helvetica;"><span
style="font-family:helvetica,arial;"></span>-- <br>
Sebastian König<br>
Schenkendorfstrasse 45
<div>04275 Leipzig</div>
<div>Germany</div>
<div><a moz-do-not-send="true"
href="mailto:sebastiankoenig@posteo.de"
target="_blank">sebastiankoenig@posteo.de</a></div>
<div><a moz-do-not-send="true"
href="http://www.3dzentrale.com/"
target="_blank">www.3dzentrale.com</a></div>
</div>
</div>
<br>
<p style="color:#a0a0a8;">On 19. November
2013 at 05:46:31, LswaN (<a
moz-do-not-send="true"
href="mailto://subscription57@live.com"
target="_blank">subscription57@live.com</a>)
wrote:</p>
<blockquote><span>
<div>
<div>
<div>I'd like to add my 2 cents
here. Regarding the thumbnails, I
think hidden by default is a bit
better than removing them
altogether. I agree with David
that thumbs can be helpful when
you just need a quick at-a-glance
view of what is going on in a set
of nodes.<br>
<br>
Also, Blender did auto-link new
nodes to your selected node at one
time, but iirc the feature was
removed because people often found
its choices for linking
confusing/unpredictable. For
example, if you added a mix node,
you might end up with the
auto-link connected to the wrong
input of the mix node.<br>
Personally, I liked the feature
(even though it wasn't perfect),
so I wouldn't mind seeing it make
a comeback.<br>
<br>
On 11/18/2013 8:57 PM, Aditia A.
Pratama wrote:<br>
</div>
<blockquote> I agree with sean.
Thumbs take to much space for
me...but yeah for only for
non-footage nodes. I also propose
to hide node by default option in
user pref, so when calling node it
will in hidden mode which is very
easy to navigate and attach.<br>
There's also one usability request
by me, but need your opinion guys.
How about auto link nodes. Let say
I've selected image node and then
I called blur node, it will auto
linked by last selected node, so
instead drag your node around it
will be more faster that way IMO.<br>
For viewer node, i think it's
better to have canvas like vse.<br>
<div class="ecxgmail_quote">On Nov
19, 2013 5:37 AM, "David
McSween" <<a
moz-do-not-send="true"
href="mailto:3pointedit@gmail.com"
target="_blank">3pointedit@gmail.com</a>>
wrote:<br>
<blockquote
class="ecxgmail_quote"
style="border-left:1px #ccc
solid;padding-left:1ex;">
<p dir="ltr">Yes I agree that
thumbs can become clutter
and are often inaccurate but
they provide handy visual
ques or sign posts for your
process. Perhaps default to
closed/hidden would be
better. They can be replaced
with viewer nodes but you
can't send multiple viewer
nodes to the uv image
window. It would be really
helpful to allocate unique
names to viewer nodes, so
that you can call them
independently on their own
uv image windows. This would
allow the user to compare
details of node outputs.</p>
<div class="ecxgmail_quote">On
19 Nov 2013 07:30, "Sean
Kennedy" <<a
moz-do-not-send="true"
href="mailto:mack_dadd2@hotmail.com"
target="_blank">mack_dadd2@hotmail.com</a>>
wrote:<br>
<blockquote
class="ecxgmail_quote"
style="border-left:1px
#ccc
solid;padding-left:1ex;">
<div>
<div dir="ltr">I'm all
for removing
thumbnails, at least
on non-footage nodes.
It could be useful on
image nodes, movie
clips, etc, because if
you have a lot of
footage being used, it
could help keep it
visually organized.
But even on those,
making it default to
not show the thumbnail
is ideal.
<div><br>
</div>
<div>sean</div>
<div>
<div><br>
<div>
<hr> Date: Mon,
18 Nov 2013
22:20:08 +0100<br>
From: <a
moz-do-not-send="true"
href="mailto:m.dewanchand@atmind.nl" target="_blank">m.dewanchand@atmind.nl</a><br>
To: <a
moz-do-not-send="true"
href="mailto:bf-compositor@blender.org" target="_blank">bf-compositor@blender.org</a><br>
Subject: Re:
[Bf-compositor]
Wiki Page<br>
<br>
<div>Hi
Sebastian,<br>
<br>
Nice! Just
missing some
priorities....<br>
Regarding
status
updates; when
starting a
project the
developer can
create a page
for it,
containing
details about
the project /
solution /
progress, and
link it to the
main page.<br>
<br>
So should we
start removing
thumbnail
previews? If
yes, do you
also want to
remove the
preview from
the input- and
output nodes?<br>
<br>
Rgds,<br>
J & M<br>
<br>
Sebastian
König schreef
op 11/8/13
1:25 PM:<br>
</div>
<blockquote>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> Hey all!</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> I have started to fill in the wiki page.</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <a moz-do-not-send="true"
href="http://wiki.blender.org/index.php/Dev:Ref/Proposals/Compositor"
target="_blank">http://wiki.blender.org/index.php/Dev:Ref/Proposals/Compositor</a></div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> I'm not super experienced with Wiki editing, so
feel free to
edit and
elaborate.</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> I am also open to suggestions how to improve the
order/appearance/structure.</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> Probably there should also be some kind of
indication
what’s being
worked on,
what’s the
status etc.</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> More to come.</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> Cheers!</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> Sebastian</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<div
style="font-family:Helvetica,
Arial;font-size:13px;"> <br>
</div>
<br>
<br>
<pre>_______________________________________________
Bf-compositor mailing list
<a moz-do-not-send="true" href="mailto:Bf-compositor@blender.org" target="_blank">Bf-compositor@blender.org</a>
<a moz-do-not-send="true" href="http://lists.blender.org/mailman/listinfo/bf-compositor" target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a>
</pre>
</blockquote>
<br>
<br>
_______________________________________________
Bf-compositor
mailing list <a
moz-do-not-send="true" href="mailto:Bf-compositor@blender.org"
target="_blank">Bf-compositor@blender.org</a>
<a
moz-do-not-send="true"
href="http://lists.blender.org/mailman/listinfo/bf-compositor"
target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a></div>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
Bf-compositor mailing list<br>
<a moz-do-not-send="true"
href="mailto:Bf-compositor@blender.org" target="_blank">Bf-compositor@blender.org</a><br>
<a moz-do-not-send="true"
href="http://lists.blender.org/mailman/listinfo/bf-compositor"
target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a><br>
<br>
</blockquote>
</div>
<br>
_______________________________________________<br>
Bf-compositor mailing list<br>
<a moz-do-not-send="true"
href="mailto:Bf-compositor@blender.org"
target="_blank">Bf-compositor@blender.org</a><br>
<a moz-do-not-send="true"
href="http://lists.blender.org/mailman/listinfo/bf-compositor"
target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a><br>
<br>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Bf-compositor mailing list
<a moz-do-not-send="true" href="mailto:Bf-compositor@blender.org" target="_blank">Bf-compositor@blender.org</a>
<a moz-do-not-send="true" href="http://lists.blender.org/mailman/listinfo/bf-compositor" target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a>
</pre>
</blockquote>
<br>
_______________________________________________
<br>
Bf-compositor mailing list <br>
<a moz-do-not-send="true"
href="mailto:Bf-compositor@blender.org"
target="_blank">Bf-compositor@blender.org</a>
<br>
<a moz-do-not-send="true"
href="http://lists.blender.org/mailman/listinfo/bf-compositor"
target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a>
<br>
</div>
</div>
</span></blockquote>
</div>
<br>
_______________________________________________<br>
Bf-compositor mailing list<br>
<a moz-do-not-send="true"
href="mailto:Bf-compositor@blender.org">Bf-compositor@blender.org</a><br>
<a moz-do-not-send="true"
href="http://lists.blender.org/mailman/listinfo/bf-compositor"
target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a><br>
<br>
</blockquote>
</div>
<br>
</div>
_______________________________________________<br>
Bf-compositor mailing list<br>
<a moz-do-not-send="true"
href="mailto:Bf-compositor@blender.org">Bf-compositor@blender.org</a><br>
<a moz-do-not-send="true"
class="ecxmoz-txt-link-freetext"
href="http://lists.blender.org/mailman/listinfo/bf-compositor"
target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="ecxmimeAttachmentHeader"></fieldset>
<br>
<pre>_______________________________________________
Bf-compositor mailing list
<a moz-do-not-send="true" class="ecxmoz-txt-link-abbreviated" href="mailto:Bf-compositor@blender.org">Bf-compositor@blender.org</a>
<a moz-do-not-send="true" class="ecxmoz-txt-link-freetext" href="http://lists.blender.org/mailman/listinfo/bf-compositor" target="_blank">http://lists.blender.org/mailman/listinfo/bf-compositor</a>
</pre>
</blockquote>
<br>
<br>
_______________________________________________
Bf-compositor mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Bf-compositor@blender.org">Bf-compositor@blender.org</a>
<a class="moz-txt-link-freetext" href="http://lists.blender.org/mailman/listinfo/bf-compositor">http://lists.blender.org/mailman/listinfo/bf-compositor</a></div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Bf-compositor mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Bf-compositor@blender.org">Bf-compositor@blender.org</a>
<a class="moz-txt-link-freetext" href="http://lists.blender.org/mailman/listinfo/bf-compositor">http://lists.blender.org/mailman/listinfo/bf-compositor</a>
</pre>
</blockquote>
<br>
</body>
</html>