Hi,<br><br>The main intention of the comment there in DNA is to make sure that nobody attempts to use BLI_addtail/head, BLI_remlink, etc. on the Action Groups list. <br><br>This was really an attempt at getting channels to exist in more than one linked list at a time, with the actions-channels belonging to the action's chanbase list still (to reduce the overhead of having to add code to check in groups for channels AND in the action still because not all channels will be grouped). As a result, groups merely store pointers to the channels which mark the start/end of that group's list. This works because all the channels are arranged in such a way, that all of a group's channels are stored together in sequence, and these bunches of channels are stored after each other in the same way that the groups are ordered. Un-grouped channels are at the end of the list.<br>
<br>Therefore, adding/deleting/reordering channels/groups in Actions MUST go through the API functions for this (I still have to restore these in 2.5), otherwise, there is a very high chance of leaks (i.e. lost channels). That's why the comment there exists... <br>
<br>Now, if you're iterating over these channels in a group, to find the endpoint, you don't check for NULL as that will be the last channel in the Action. Rather, you check if the channel's group is still the group that you're looking at. I'll double check the RNA wrapping later :)<br>
<br>Regards,<br>Joshua<br><br><div class="gmail_quote">On Thu, Jan 8, 2009 at 1:10 AM, Roland Hess <span dir="ltr"><<a href="mailto:me@harkyman.com">me@harkyman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Revision: 18396<br>
<a href="http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=18396" target="_blank">http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=18396</a><br>
Author: harkyman<br>
Date: 2009-01-07 14:10:31 +0100 (Wed, 07 Jan 2009)<br>
<br>
Log Message:<br>
-----------<br>
Conflicts resolved. Hadn't used the Resolve command last time. Brilliant.<br>
<br>
Modified Paths:<br>
--------------<br>
branches/blender2.5/blender/source/blender/makesrna/intern/rna_action.c<br>
<br>
Modified: branches/blender2.5/blender/source/blender/makesrna/intern/rna_action.c<br>
===================================================================<br>
--- branches/blender2.5/blender/source/blender/makesrna/intern/rna_action.c 2009-01-07 11:27:17 UTC (rev 18395)<br>
+++ branches/blender2.5/blender/source/blender/makesrna/intern/rna_action.c 2009-01-07 13:10:31 UTC (rev 18396)<br>
@@ -30,20 +30,166 @@<br>
#include "rna_internal.h"<br>
<br>
#include "DNA_action_types.h"<br>
+#include "DNA_constraint_types.h"<br>
+#include "DNA_scene_types.h"<br>
<br>
+<br>
#ifdef RNA_RUNTIME<br>
<br>
-#else<br>
+#else<br>
<br>
+void rna_def_action_channel(BlenderRNA *brna)<br>
+{<br>
+ StructRNA *srna;<br>
+ PropertyRNA *prop;<br>
+<br>
+ srna= RNA_def_struct(brna, "ActionChannel", NULL);<br>
+ RNA_def_struct_sdna(srna, "bActionChannel");<br>
+ RNA_def_struct_ui_text(srna, "Action Channel", "A channel for one object or bone's Ipos in an Action.");<br>
+<br>
+ prop= RNA_def_property(srna, "name", PROP_STRING, PROP_NONE);<br>
+ RNA_def_property_ui_text(prop, "Name", "");<br>
+ RNA_def_struct_name_property(srna, prop);<br>
+<br>
+ prop= RNA_def_property(srna, "action_group", PROP_POINTER, PROP_NONE);<br>
+ RNA_def_property_pointer_sdna(prop, NULL, "grp");<br>
+ RNA_def_property_struct_type(prop, "ActionGroup");<br>
+ RNA_def_property_flag(prop, PROP_NOT_EDITABLE);<br>
+ RNA_def_property_ui_text(prop, "Action Group", "Action Group that this Action Channel belongs to.");<br>
+<br>
+ prop= RNA_def_property(srna, "ipo", PROP_POINTER, PROP_NONE);<br>
+ RNA_def_property_struct_type(prop, "Ipo");<br>
+ RNA_def_property_flag(prop, PROP_NOT_EDITABLE);<br>
+ RNA_def_property_ui_text(prop, "Ipo", "Ipo block this Action Channel uses.");<br>
+<br>
+ /* constraint channel rna not yet implemented */<br>
+ /*prop= RNA_def_property(srna, "constraint_channels", PROP_COLLECTION, PROP_NONE);<br>
+ RNA_def_property_collection_sdna(prop, NULL, "ConstraintChannel", NULL);<br>
+ RNA_def_property_struct_type(prop, "ConstraintChannel");<br>
+ RNA_def_property_ui_text(prop, "Constraint Channels", "Ipos of Constraints attached to this object or bone."); */<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_selected", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_SELECTED);<br>
+ RNA_def_property_ui_text(prop, "Selected", "Action Channel is selected.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_highlighted", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_HILIGHTED);<br>
+ RNA_def_property_ui_text(prop, "Highlighted", "Action Channel is highlighted.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_hidden", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_HIDDEN);<br>
+ RNA_def_property_ui_text(prop, "Hidden", "Action Channel is hidden.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_protected", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_PROTECTED);<br>
+ RNA_def_property_ui_text(prop, "Protected", "Action Channel is protected.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_expanded", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_EXPANDED);<br>
+ RNA_def_property_ui_text(prop, "Expanded", "Action Channel is expanded.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_show_ipo", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_SHOWIPO);<br>
+ RNA_def_property_ui_text(prop, "Show Ipo", "Action Channel's Ipos are visible.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_channel_show_constraints", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", ACHAN_SHOWCONS);<br>
+ RNA_def_property_ui_text(prop, "Show Constraints", "Action Channel's constraints are visible.");<br>
+}<br>
+<br>
+void rna_def_action_group(BlenderRNA *brna)<br>
+{<br>
+ StructRNA *srna;<br>
+ PropertyRNA *prop;<br>
+<br>
+ srna= RNA_def_struct(brna, "ActionGroup", NULL);<br>
+ RNA_def_struct_sdna(srna, "bActionGroup");<br>
+ RNA_def_struct_ui_text(srna, "Action Group", "Groups of Actions Channels.");<br>
+<br>
+ prop= RNA_def_property(srna, "name", PROP_STRING, PROP_NONE);<br>
+ RNA_def_property_ui_text(prop, "Name", "");<br>
+ RNA_def_struct_name_property(srna, prop);<br>
+<br>
+ /* dna warns not to treat the Action Channel listbase in the Action Group struct like a<br>
+ normal listbase. I'll leave this here but comment out, for Joshua to review. He can<br>
+ probably shed some more light on why this is */<br>
+ /*prop= RNA_def_property(srna, "action_channels", PROP_COLLECTION, PROP_NONE);<br>
+ RNA_def_property_collection_sdna(prop, NULL, "channels", NULL);<br>
+ RNA_def_property_struct_type(prop, "ActionChannel");<br>
+ RNA_def_property_ui_text(prop, "Action Channels", "DOC_BROKEN");*/<br>
+<br>
+ prop= RNA_def_property(srna, "action_group_selected", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", AGRP_SELECTED);<br>
+ RNA_def_property_ui_text(prop, "Selected", "Action Group is selected.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_group_protected", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", AGRP_PROTECTED);<br>
+ RNA_def_property_ui_text(prop, "Protected", "Action Group is protected.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_group_expanded", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", AGRP_EXPANDED);<br>
+ RNA_def_property_ui_text(prop, "Expanded", "Action Group is expanded.");<br>
+<br>
+ prop= RNA_def_property(srna, "custom_color", PROP_INT, PROP_NONE);<br>
+ RNA_def_property_int_sdna(prop, NULL, "customCol");<br>
+ RNA_def_property_ui_text(prop, "Custom Color", "Index of custom color set.");<br>
+}<br>
+<br>
void RNA_def_action(BlenderRNA *brna)<br>
{<br>
StructRNA *srna;<br>
PropertyRNA *prop;<br>
<br>
+ rna_def_action_channel(brna);<br>
+ rna_def_action_group(brna);<br>
+<br>
srna= RNA_def_struct(brna, "Action", "ID");<br>
RNA_def_struct_sdna(srna, "bAction");<br>
- RNA_def_struct_ui_text(srna, "Action", "DOC_BROKEN");<br>
+ RNA_def_struct_ui_text(srna, "Action", "A collection of Ipos for animation.");<br>
<br>
+ prop= RNA_def_property(srna, "action_channels", PROP_COLLECTION, PROP_NONE);<br>
+ RNA_def_property_collection_sdna(prop, NULL, "chanbase", NULL);<br>
+ RNA_def_property_struct_type(prop, "ActionChannel");<br>
+ RNA_def_property_ui_text(prop, "Action Channels", "The individual animation channels that make up the Action.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_groups", PROP_COLLECTION, PROP_NONE);<br>
+ RNA_def_property_collection_sdna(prop, NULL, "groups", NULL);<br>
+ RNA_def_property_struct_type(prop, "ActionGroup");<br>
+ RNA_def_property_ui_text(prop, "Action Groups", "Convenient groupings of Action Channels.");<br>
+<br>
+ prop= RNA_def_property(srna, "timeline_markers", PROP_COLLECTION, PROP_NONE);<br>
+ RNA_def_property_collection_sdna(prop, NULL, "markers", NULL);<br>
+ RNA_def_property_struct_type(prop, "UnknownType"); /* implement when timeline rna is wrapped */<br>
+ RNA_def_property_ui_text(prop, "Timeline Markers", "Markers specific to this Action, for labeling poses.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_show_sliders", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_SLIDERS);<br>
+ RNA_def_property_ui_text(prop, "Show Sliders", "Show Shape Key sliders.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_time_units", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_DRAWTIME);<br>
+ RNA_def_property_ui_text(prop, "Time Units", "Show seconds or frames in the timeline.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_show_all", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_NOHIDE);<br>
+ RNA_def_property_ui_text(prop, "Show All", "Show all channels regardless of hidden status.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_kill_overlapping_keys", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_NOTRANSKEYCULL);<br>
+ RNA_def_property_ui_text(prop, "Kill Overlapping Keys", "Remove overlapping keys after a transform.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_key_cull_to_view", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_HORIZOPTIMISEON);<br>
+ RNA_def_property_ui_text(prop, "Cull Keys to View", "Only consider keys that are within the view.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_group_colors", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_NODRAWGCOLORS);<br>
+ RNA_def_property_ui_text(prop, "Group Color", "Use custom color grouping and instead of default color scheme.");<br>
+<br>
+ prop= RNA_def_property(srna, "action_current_frame_number", PROP_BOOLEAN, PROP_NONE);<br>
+ RNA_def_property_boolean_sdna(prop, NULL, "flag", SACTION_NODRAWCFRANUM);<br>
+ RNA_def_property_ui_text(prop, "Current Frame Number", "Draw the frame number beside the current frame indicator.");<br>
+<br>
}<br>
<br>
#endif<br>
<br>
<br>
_______________________________________________<br>
Bf-blender-cvs mailing list<br>
<a href="mailto:Bf-blender-cvs@blender.org">Bf-blender-cvs@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-blender-cvs" target="_blank">http://lists.blender.org/mailman/listinfo/bf-blender-cvs</a><br>
</blockquote></div><br>