Hit Ton,<br><br><div class="gmail_quote"><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">
> I am interested in this kind of stuff and I can code it but as I said<br>
> if is going to be used by nodes, sequencer and image editor ther must<br>
> be a way to unify it.<br>
<br>
</div>I've seen the past years some professional colorcorrections programs<br>
work, and this is a truely amazing tool to manage footage or renders<br>
for final delivery (like for film, video, but also to match sequences).<br>
Especially real-time mask generating is a great tool to have.<br>
In that sense I'm very interested to look at ways how to extend the<br>
sequencer to use more of such tools. They definitely can be presented<br>
somewhat more friendly or consistant, feel invited to make a proposal<br>
one of these months for how to work on this in 2.5?<br>
</blockquote><div><br>I will try for sure, but I am new to blender code and not really a programmer but know image manipulation mathematics and c. For the moment I was just thinking on making some image minupulation functions accesible to nodes and sequencer code to avoid code duplication. I am a bit lost in the interface code but maybe some common UI controls can be grouped (like the curves control) to unify somme of the UI code also. For the moment I am thinking Lift/gamma/gain controls or Saturation/Value curves acording to hue.<br>
<br>Some kind of mask drawing (with primitives shape and/or bezier) tool is really useful too. It is possible for the moment but only using a 3d scene and animating bezier with hooks are not practical (can't animate handles or keeping the curve in "auto smooth"). Setting the camera, materal and bakground image in 3d for creating a 2d mask is also a bit frustrating. <br>
<br>If some kind of basic 2d vector drawing tool must be introduced, how will it fit in blender? how to make the render available in the nodes and in the sequencer? (but adding a "mask" option for some image filter in the sequencer is quite easy) <br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
In my vision it's very cool to keep the sequencer fast, providing<br>
near-realtime editing of many shots. Having excellent grading tools<br>
here, using simple stacks, and probably using GPU, would be a great<br>
step forward.</blockquote><div> </div><div>Color correction is not fast code, but not really complicated and programs using CUDA for it seems to have great peformance. Plus it should not be too hard to port. Staking image filter would be verry usefull when more one correction method will be available, but abusing it will result in bad performances.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
How ImageWindow fits in this... I'd stick for the time being on using a<br>
designated sequencer output window.</blockquote><div> </div><div>Yes, I suppose there is not a lot of use to have this kind of tools in the image widows, gimp is already here.<br> <br>Xavier<br><br><br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
-Ton-<br>
<br>
------------------------------------------------------------------------<br>
<font color="#888888">Ton Roosendaal Blender Foundation <a href="mailto:ton@blender.org">ton@blender.org</a> <a href="http://www.blender.org" target="_blank">www.blender.org</a><br>
Blender Institute BV Entrepotdok 57A 1018AD Amsterdam The Netherlands<br>
</font><div><div></div><div class="Wj3C7c"><br>
On 11 Dec, 2008, at 0:28, Xavier Thomas wrote:<br>
<br>
> they are not really intuitives, but they works like "Levels" in gimp<br>
> Lift must set the black level<br>
> Gain the white<br>
> and Gamme the mid point<br>
><br>
> The problem here is that the the values are manipulated for :<br>
> - "1,1,1" to be "no change value"<br>
> - Values between 0 and 1 to darken the image<br>
> - An "inverse" button tho permit values > 1 wich brighten the image<br>
> More than being unintuitives, it does not permit full control<br>
> (inversing gain invers for all channels)<br>
><br>
> What solution:<br>
> - Curves will take big UI<br>
> - Levels maybe also<br>
><br>
> But it is not preferable to do this as an sequencer effect, This will<br>
> permit the user to choose the effect acording to the type of<br>
> correction he wants to make (Level, curves, ...)<br>
><br>
> For primary color correction this is not really important as for me<br>
> "Levels" and "Lift/Gamma/Gain" are the same with different way of<br>
> setting the parameter and they can be done with curves.<br>
><br>
> But if complex secondary collor correction (like changing saturation <br>
> and value acording to hue with a curve, ...) is going to make is way<br>
> in blender the user must choose the one he wants<br>
><br>
> Note that with nodes doing a "not so complex secondary color<br>
> correction" (like the exemple below) requires:<br>
> -color space conversion<br>
> -doing a difference map with a constant value<br>
> -using this map as factor for color<br>
><br>
> It will need about 10 nodes and that is uaualy done in one in shake or<br>
> with one effect in finalcut.<br>
><br>
> I am interested in this kind of stuff and I can code it but as I said<br>
> if is going to be used by nodes, sequencer and image editor ther must<br>
> be a way to unify it.<br>
><br>
> xavier<br>
><br>
> 2008/12/10 Campbell Barton <<a href="mailto:ideasman42@gmail.com">ideasman42@gmail.com</a>><br>
>> On Thu, Dec 11, 2008 at 9:33 AM, Xavier Thomas<br>
>> <<a href="mailto:xavier.thomas.1980@gmail.com">xavier.thomas.1980@gmail.com</a>> wrote:<br>
>> > Yes, that is what I ment but is it ok to add an UI parameter<br>
>> "ofset" with is<br>
>> > button "Inv ofset" at the side of the Lift gamma and gain<br>
>> parameters because<br>
>> > the UI will get really charged.<br>
>> ><br>
>> > And what about an image treatment library, because I already have<br>
>> made this<br>
>> > function in my keyer node and crating a color correction node with<br>
>> these<br>
>> > controls might be usefull also: this will result in a lot of code<br>
>> > duplication.<br>
>> ><br>
>> ><br>
>> > 2008/12/10 Dalai Felinto <<a href="mailto:dfelinto@gmail.com">dfelinto@gmail.com</a>><br>
>> >><br>
>> >> Hi Xavier.<br>
>> >><br>
>> >> Can't you do a do_version()?<br>
>> >> In readfile.c you can see a lot of parameters that need to be<br>
>> updated<br>
>> >> over Blender version.<br>
>> >> If what you need is a simple offset for old blender files work in<br>
>> the<br>
>> >> same way as new blender files (with this bug fixed), this should<br>
>> work.<br>
>> >><br>
>> >> I didn't see the bug or this part of the code, but do_version()<br>
>> >> sometimes is the better way to go.<br>
>> >><br>
>> >> Cheers,<br>
>> >> Dalai<br>
>> >> <a href="http://blenderecia.orgfree.com" target="_blank">http://blenderecia.orgfree.com</a><br>
>> >><br>
>> >> 2008/12/10 Xavier Thomas <<a href="mailto:xavier.thomas.1980@gmail.com">xavier.thomas.1980@gmail.com</a>>:<br>
>> >> > Hello,<br>
>> >> ><br>
>> >> > Lately, I was trying to implicate me in blender developement,<br>
>> and<br>
>> >> > begining<br>
>> >> > with small things (after the keyr node) I desided to correct<br>
>> this bug:<br>
>> >> ><br>
>> >> ><br>
>> <a href="http://projects.blender.org/tracker/index.php" target="_blank">http://projects.blender.org/tracker/index.php</a>?<br>
>> func=detail&aid=18010&group_id=9&atid=125<br>
>> >> ><br>
>> >> > Basicly the lift parameter of color correction in sequencer<br>
>> works more<br>
>> >> > like<br>
>> >> > a "value" color correction than a "lift" (exept that it work on<br>
>> RGB<br>
>> >> > channel<br>
>> >> > separately so I think "ofset" is more apropriate then "value")<br>
>> >> ><br>
>> >> > Fixing it would be simple but old files that use this parameter<br>
>> will<br>
>> >> > have a<br>
>> >> > diferent render result, and after discussing with Matt Ebb on<br>
>> IRC it<br>
>> >> > seems<br>
>> >> > that this is not acceptable.<br>
>> >> > So the only solution to have a proper color correction in the<br>
>> sequencer<br>
>> >> > is<br>
>> >> > to add an "ofset" parameter. Is this OK ? (maybe the UI will<br>
>> get too<br>
>> >> > compact)<br>
>> >> ><br>
>> >> > Further, why do not put this kind of function in an image<br>
>> library so it<br>
>> >> > will<br>
>> >> > be accesible form other part of the program (nodes and maybe<br>
>> image<br>
>> >> > editor)<br>
>> >> > like the quick blur function in the nodes CMP_util.h<br>
>> >> ><br>
>> >> > Sorry to disturb, I know lot of you are really buzzy but I<br>
>> prefer to get<br>
>> >> > good directions before coding.<br>
>> >> ><br>
>> >> > Thanks<br>
>> >> ><br>
>> >> > Xavier<br>
>> >> ><br>
>> >> > _______________________________________________<br>
>> >> > Bf-committers mailing list<br>
>> >> > <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
>> >> > <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
>> >> ><br>
>> >> ><br>
>> >> _______________________________________________<br>
>> >> Bf-committers mailing list<br>
>> >> <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
>> >> <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Bf-committers mailing list<br>
>> > <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
>> > <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
>><br>
>> Recently I tried making sense of the sequencer's color functions and<br>
>> found them quite confusing. Even after tweaking them for 5min I don't<br>
>> really understand what they do exactly.<br>
>><br>
>> Id much prefer convert these values into either, gimp/photoshop color<br>
>> 'Levels' or 'Curves'.<br>
>> Curves are already used in other parts of blender so I'ts probably<br>
>> not<br>
>> that hard to make this change,<br>
>><br>
>> Peter, if your reading, Could these settings be converted to curves?<br>
>> (even a close approximation would be ok I think)<br>
>><br>
>> --<br>
>> - Campbell<br>
>> _______________________________________________<br>
>> Bf-committers mailing list<br>
>> <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
>> <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
> _______________________________________________<br>
> Bf-committers mailing list<br>
> <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
<br>
_______________________________________________<br>
Bf-committers mailing list<br>
<a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
</div></div></blockquote></div><br>