they are not really intuitives, but they works like "Levels" in gimp<br>Lift must set the black level<br>Gain the white<br>and Gamme the mid point<br><br>The problem here is that the the values are manipulated for :<br>
- "1,1,1" to be "no change value" <br>- Values between 0 and 1 to darken the image<br>- An "inverse" button tho permit values > 1 wich brighten the image<br>More than being unintuitives, it does not permit full control (inversing gain invers for all channels)<br>
<br>What solution:<br>- Curves will take big UI<br>- Levels maybe also<br><br>But it is not preferable to do this as an sequencer effect, This will permit the user to choose the effect acording to the type of correction he wants to make (Level, curves, ...)<br>
<br>For primary color correction this is not really important as for me "Levels" and "Lift/Gamma/Gain" are the same with different way of setting the parameter and they can be done with curves. <br><br>
But if complex secondary collor correction (like changing saturation and value acording to hue with a curve, ...) is going to make is way in blender the user must choose the one he wants<br><br>Note that with nodes doing a "not so complex secondary color correction" (like the exemple below) requires:<br>
-color space conversion<br>-doing a difference map with a constant value<br>-using this map as factor for color<br><br>It will need about 10 nodes and that is uaualy done in one in shake or with one effect in finalcut.<br>
<br>I am interested in this kind of stuff and I can code it but as I said if is going to be used by nodes, sequencer and image editor ther must be a way to unify it.<br><br>xavier<br><br><div class="gmail_quote">2008/12/10 Campbell Barton <span dir="ltr"><<a href="mailto:ideasman42@gmail.com">ideasman42@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="Wj3C7c">On Thu, Dec 11, 2008 at 9:33 AM, Xavier Thomas<br>
<<a href="mailto:xavier.thomas.1980@gmail.com">xavier.thomas.1980@gmail.com</a>> wrote:<br>
> Yes, that is what I ment but is it ok to add an UI parameter "ofset" with is<br>
> button "Inv ofset" at the side of the Lift gamma and gain parameters because<br>
> the UI will get really charged.<br>
><br>
> And what about an image treatment library, because I already have made this<br>
> function in my keyer node and crating a color correction node with these<br>
> controls might be usefull also: this will result in a lot of code<br>
> duplication.<br>
><br>
><br>
> 2008/12/10 Dalai Felinto <<a href="mailto:dfelinto@gmail.com">dfelinto@gmail.com</a>><br>
>><br>
>> Hi Xavier.<br>
>><br>
>> Can't you do a do_version()?<br>
>> In readfile.c you can see a lot of parameters that need to be updated<br>
>> over Blender version.<br>
>> If what you need is a simple offset for old blender files work in the<br>
>> same way as new blender files (with this bug fixed), this should work.<br>
>><br>
>> I didn't see the bug or this part of the code, but do_version()<br>
>> sometimes is the better way to go.<br>
>><br>
>> Cheers,<br>
>> Dalai<br>
>> <a href="http://blenderecia.orgfree.com" target="_blank">http://blenderecia.orgfree.com</a><br>
>><br>
>> 2008/12/10 Xavier Thomas <<a href="mailto:xavier.thomas.1980@gmail.com">xavier.thomas.1980@gmail.com</a>>:<br>
>> > Hello,<br>
>> ><br>
>> > Lately, I was trying to implicate me in blender developement, and<br>
>> > begining<br>
>> > with small things (after the keyr node) I desided to correct this bug:<br>
>> ><br>
>> > <a href="http://projects.blender.org/tracker/index.php?func=detail&aid=18010&group_id=9&atid=125" target="_blank">http://projects.blender.org/tracker/index.php?func=detail&aid=18010&group_id=9&atid=125</a><br>
>> ><br>
>> > Basicly the lift parameter of color correction in sequencer works more<br>
>> > like<br>
>> > a "value" color correction than a "lift" (exept that it work on RGB<br>
>> > channel<br>
>> > separately so I think "ofset" is more apropriate then "value")<br>
>> ><br>
>> > Fixing it would be simple but old files that use this parameter will<br>
>> > have a<br>
>> > diferent render result, and after discussing with Matt Ebb on IRC it<br>
>> > seems<br>
>> > that this is not acceptable.<br>
>> > So the only solution to have a proper color correction in the sequencer<br>
>> > is<br>
>> > to add an "ofset" parameter. Is this OK ? (maybe the UI will get too<br>
>> > compact)<br>
>> ><br>
>> > Further, why do not put this kind of function in an image library so it<br>
>> > will<br>
>> > be accesible form other part of the program (nodes and maybe image<br>
>> > editor)<br>
>> > like the quick blur function in the nodes CMP_util.h<br>
>> ><br>
>> > Sorry to disturb, I know lot of you are really buzzy but I prefer to get<br>
>> > good directions before coding.<br>
>> ><br>
>> > Thanks<br>
>> ><br>
>> > Xavier<br>
>> ><br>
>> > _______________________________________________<br>
>> > Bf-committers mailing list<br>
>> > <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
>> > <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
>> ><br>
>> ><br>
>> _______________________________________________<br>
>> Bf-committers mailing list<br>
>> <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
>> <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
><br>
><br>
> _______________________________________________<br>
> Bf-committers mailing list<br>
> <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
<br>
</div></div>Recently I tried making sense of the sequencer's color functions and<br>
found them quite confusing. Even after tweaking them for 5min I don't<br>
really understand what they do exactly.<br>
<br>
Id much prefer convert these values into either, gimp/photoshop color<br>
'Levels' or 'Curves'.<br>
Curves are already used in other parts of blender so I'ts probably not<br>
that hard to make this change,<br>
<br>
Peter, if your reading, Could these settings be converted to curves?<br>
(even a close approximation would be ok I think)<br>
<br>
--<br>
<font color="#888888">- Campbell<br>
</font><div><div></div><div class="Wj3C7c">_______________________________________________<br>
Bf-committers mailing list<br>
<a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
</div></div></blockquote></div><br>