Yes, that is what I ment but is it ok to add an UI parameter "ofset" with is button "Inv ofset" at the side of the Lift gamma and gain parameters because the UI will get really charged.<br><br>And what about an image treatment library, because I already have made this function in my keyer node and crating a color correction node with these controls might be usefull also: this will result in a lot of code duplication.<br>
<br><br><div class="gmail_quote">2008/12/10 Dalai Felinto <span dir="ltr"><<a href="mailto:dfelinto@gmail.com">dfelinto@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Xavier.<br>
<br>
Can't you do a do_version()?<br>
In readfile.c you can see a lot of parameters that need to be updated<br>
over Blender version.<br>
If what you need is a simple offset for old blender files work in the<br>
same way as new blender files (with this bug fixed), this should work.<br>
<br>
I didn't see the bug or this part of the code, but do_version()<br>
sometimes is the better way to go.<br>
<br>
Cheers,<br>
Dalai<br>
<a href="http://blenderecia.orgfree.com" target="_blank">http://blenderecia.orgfree.com</a><br>
<br>
2008/12/10 Xavier Thomas <<a href="mailto:xavier.thomas.1980@gmail.com">xavier.thomas.1980@gmail.com</a>>:<br>
<div><div></div><div class="Wj3C7c">> Hello,<br>
><br>
> Lately, I was trying to implicate me in blender developement, and begining<br>
> with small things (after the keyr node) I desided to correct this bug:<br>
> <a href="http://projects.blender.org/tracker/index.php?func=detail&aid=18010&group_id=9&atid=125" target="_blank">http://projects.blender.org/tracker/index.php?func=detail&aid=18010&group_id=9&atid=125</a><br>
><br>
> Basicly the lift parameter of color correction in sequencer works more like<br>
> a "value" color correction than a "lift" (exept that it work on RGB channel<br>
> separately so I think "ofset" is more apropriate then "value")<br>
><br>
> Fixing it would be simple but old files that use this parameter will have a<br>
> diferent render result, and after discussing with Matt Ebb on IRC it seems<br>
> that this is not acceptable.<br>
> So the only solution to have a proper color correction in the sequencer is<br>
> to add an "ofset" parameter. Is this OK ? (maybe the UI will get too<br>
> compact)<br>
><br>
> Further, why do not put this kind of function in an image library so it will<br>
> be accesible form other part of the program (nodes and maybe image editor)<br>
> like the quick blur function in the nodes CMP_util.h<br>
><br>
> Sorry to disturb, I know lot of you are really buzzy but I prefer to get<br>
> good directions before coding.<br>
><br>
> Thanks<br>
><br>
> Xavier<br>
><br>
</div></div>> _______________________________________________<br>
> Bf-committers mailing list<br>
> <a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
> <a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
><br>
><br>
_______________________________________________<br>
Bf-committers mailing list<br>
<a href="mailto:Bf-committers@blender.org">Bf-committers@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-committers" target="_blank">http://lists.blender.org/mailman/listinfo/bf-committers</a><br>
</blockquote></div><br>