[Bf-committers] Patch: OCIO Parse Colorspace From Filename

[Xavier Thomas]

>
> This patch seems to have the following priority:
> - Image loader sets color space (based on either image header or other
> assumptions)
> - The higher level reader then might override the color space based on file
> name.
> If we allow such an automatic guess, it should be other way around. If the
> file knows it's color space, it should be trusted, as it is more trustful
> than a file name.


Then it might be wiser to join all the "color space auto detection magic"
at the same place (image loader) and only try to guess from the filename if
the header/metadata detection failed.

In any case, in my opinion, the colorspace displayed in the UI/RNA
(possibly manually set by the user afterwards) should always be respected
and never silently overridden.

Xavier

2017-12-11 12:45 GMT-02:00 Troy Sobotka <troy.sobotka at gmail.com>:

> On Mon, Dec 11, 2017, 5:57 AM Sergey Sharybin <sergey.vfx at gmail.com>
> wrote:
> > - Image loader sets color space (based on either image header or other
> > assumptions)
> > The higher level reader then might override the color space based on file
> > name.
>
> > If we allow such an automatic guess, it should be other way around. If
> the
> > file knows it's color space, it should be trusted, as it is more trustful
> > than a file name.
>
> >
> Ok. So if we do that, what is the best method to set the defaults? Each
> filetype has the colourspace set to the default role.
>
> Would the following order work?
>
>  * Set the filetype default to Null.
>  * Test the colorspace variable for a Blender file setting.
>  * If Blender file remains unset, test for filename.
>  * If it remains unset, set to default role.
>
> Is there a means to differentiate between whether the colorspace variable
> was set via default role or user based setting?
>
> With respect,
> TJS
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> https://lists.blender.org/mailman/listinfo/bf-committers
>